[opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)
Boroondas Gupte
sllists at boroon.dasgupta.ch
Tue May 24 15:32:08 PDT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/307/#review712
-----------------------------------------------------------
indra/llvfs/lldiriterator.cpp
<http://codereview.secondlife.com/r/307/#comment681>
Meh, my backwards-compatibility approach does not work: The existance of fs::path::native() will be checked by the compiler, even when this method is never called and thus (as it's inlined) would never even show up in the binary.
- Boroondas
On May 18, 2011, 1:13 p.m., Boroondas Gupte wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/307/
> -----------------------------------------------------------
>
> (Updated May 18, 2011, 1:13 p.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> Some trickery needed to make this forward compatible to newer Boost versions while keeping compatibility to the currently used Boost version.
>
>
> This addresses bug OPEN-67.
> http://jira.secondlife.com/browse/OPEN-67
>
>
> Diffs
> -----
>
> doc/contributions.txt 959f9340da92
> indra/llvfs/lldiriterator.cpp 959f9340da92
>
> Diff: http://codereview.secondlife.com/r/307/diff
>
>
> Testing
> -------
>
> * Compiled Viewer (standalone) with Boost 1.46
> * Started Viewer
> * Logged in
>
> Not tested:
> * non-standalone
> * other boost versions (At least one version <= 1.43 should be tested! Preferably the one LL currently uses.)
>
>
> Thanks,
>
> Boroondas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110524/eb9f40eb/attachment-0001.htm
More information about the opensource-dev
mailing list