[opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)
Boroondas Gupte
sllists at boroon.dasgupta.ch
Tue May 24 15:41:42 PDT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/307/
-----------------------------------------------------------
(Updated May 24, 2011, 3:41 p.m.)
Review request for Viewer.
Changes
-------
unsuccessful test with boost 1.45
Summary
-------
Some trickery needed to make this forward compatible to newer Boost versions while keeping compatibility to the currently used Boost version.
This addresses bug OPEN-67.
http://jira.secondlife.com/browse/OPEN-67
Diffs
-----
doc/contributions.txt 959f9340da92
indra/llvfs/lldiriterator.cpp 959f9340da92
Diff: http://codereview.secondlife.com/r/307/diff
Testing (updated)
-------
* Compiled Viewer (standalone) with Boost 1.46
* Started Viewer
* Logged in
* Tried to compile Viewer (standalone) with Boost 1.45 (which has the new API, but apparently defaults to the old one)
** this fails with
indra/llvfs/lldiriterator.cpp:143: error: ‘const struct boost::filesystem2::path’ has no member named ‘native’
Not tested:
* non-standalone
Thanks,
Boroondas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110524/f9ac0c6c/attachment.htm
More information about the opensource-dev
mailing list