From tillie at xp2.de Tue Nov 1 05:58:55 2011 From: tillie at xp2.de (Tillie Ariantho) Date: Tue, 01 Nov 2011 13:58:55 +0100 Subject: [opensource-dev] Real Time Animation with Kinect In-Reply-To: <4EAE772C.3020406@solar-system.tuis.ac.jp> References: <4EAE772C.3020406@solar-system.tuis.ac.jp> Message-ID: <4EAFED0F.4080208@xp2.de> On 31.10.2011 11:23, Fumi.Iseki wrote: > We are developing the system of real time animation on SL with Kinect. > > Please see > http://www.nsl.tuis.ac.jp/xoops/modules/x_movie/x_movie_view.php?cid=2&lid=33 > > Is this interesting? Wow, great idea! :D From vsavchuk at productengine.com Tue Nov 1 07:20:50 2011 From: vsavchuk at productengine.com (Vadim Savchuk) Date: Tue, 1 Nov 2011 16:20:50 +0200 Subject: [opensource-dev] Redundant 'typedef' causing compiliation to fail on GCC 4.4/4.5 In-Reply-To: <1320106694.30400.7.camel@CHANDRA> References: <1320106694.30400.7.camel@CHANDRA> Message-ID: Fixed , thank you. On Tue, Nov 1, 2011 at 2:18 AM, Jamie Quinlan wrote: > Hi all, > > It's rare I post on here, but I think I need to bring something to > light. With the latest viewer-development branch, I noticed that a > warning, treated like an error, causes compilation of the viewer to fail > under GCC 4.4 and 4.5 versions. > > (Note, I haven't mentioned GCC 4.6, as it fails to compile anyway, but > that's a moot point, as I have 4.4 and 4.5 built and installed from > source. :) ) > > As far as my knowledge of C++ goes, typedef functions are only used in C > to declare structs, in C++, it's not used that way. Fortunatly the fix > is simple. > > All you have to do is to delete the 'typedef' from line 54 of > indra/llui/llkeywords.h, and off you go. Just don't delete anything else > from that line, that would be Very Bad(TM). > > Sorry if it does seem a little harsh, but if it breaks a Linden-used > version of GCC, it might end up being a major PITA, and we don't want > that. :) > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -- Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111101/78abf83d/attachment.htm From vsavchuk at productengine.com Tue Nov 1 07:36:46 2011 From: vsavchuk at productengine.com (Vadim ProductEngine) Date: Tue, 01 Nov 2011 14:36:46 -0000 Subject: [opensource-dev] Review Request: STORM-1676 "powered by Google" text is shown in the Nearby chat window when Bing translation service is used Message-ID: <20111101143646.16585.6159@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/511/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Removed "Powered by Google" label from the nearby chat floater. This addresses bug STORM-1676. http://jira.secondlife.com/browse/STORM-1676 Diffs ----- indra/newview/skins/default/xui/da/floater_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/da/panel_preferences_chat.xml 6b887df85f95 indra/newview/skins/default/xui/de/floater_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/de/panel_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/de/panel_preferences_chat.xml 6b887df85f95 indra/newview/skins/default/xui/en/panel_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/es/floater_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/es/panel_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/es/panel_preferences_chat.xml 6b887df85f95 indra/newview/skins/default/xui/fr/floater_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/fr/panel_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/fr/panel_preferences_chat.xml 6b887df85f95 indra/newview/skins/default/xui/it/floater_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/it/panel_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/it/panel_preferences_chat.xml 6b887df85f95 indra/newview/skins/default/xui/ja/floater_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/ja/panel_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/ja/panel_preferences_chat.xml 6b887df85f95 indra/newview/skins/default/xui/pl/floater_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/pl/panel_preferences_chat.xml 6b887df85f95 indra/newview/skins/default/xui/pt/floater_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/pt/panel_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/pt/panel_preferences_chat.xml 6b887df85f95 indra/newview/skins/default/xui/ru/floater_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/ru/panel_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/ru/panel_preferences_chat.xml 6b887df85f95 indra/newview/skins/default/xui/tr/floater_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/tr/panel_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/tr/panel_preferences_chat.xml 6b887df85f95 indra/newview/skins/default/xui/zh/floater_nearby_chat.xml 6b887df85f95 indra/newview/skins/default/xui/zh/panel_preferences_chat.xml 6b887df85f95 Diff: http://codereview.secondlife.com/r/511/diff Testing ------- Thanks, Vadim -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111101/cfcb8bea/attachment.htm From jhwelch at gmail.com Tue Nov 1 10:40:46 2011 From: jhwelch at gmail.com (Jonathan Welch) Date: Tue, 1 Nov 2011 13:40:46 -0400 Subject: [opensource-dev] Viewer-develop-commits emails Message-ID: The last few messages I have received from viewer-develop-commits in digest form have included every single diff. Could someone at LL look at what changed and restore the previous behavior of only sending the summary headers? From slitovchuk at productengine.com Wed Nov 2 09:16:16 2011 From: slitovchuk at productengine.com (Seth ProductEngine) Date: Wed, 02 Nov 2011 16:16:16 -0000 Subject: [opensource-dev] Review Request: STORM-1676 "powered by Google" text is shown in the Nearby chat window when Bing translation service is used In-Reply-To: <20111101143646.16585.6159@domU-12-31-38-00-90-68.compute-1.internal> References: <20111101143646.16585.6159@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111102161616.15278.61690@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/511/#review1071 ----------------------------------------------------------- Ship it! - Seth On Nov. 1, 2011, 7:36 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/511/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2011, 7:36 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Removed "Powered by Google" label from the nearby chat floater. > > > This addresses bug STORM-1676. > http://jira.secondlife.com/browse/STORM-1676 > > > Diffs > ----- > > indra/newview/skins/default/xui/da/floater_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/da/panel_preferences_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/de/floater_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/de/panel_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/de/panel_preferences_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/en/panel_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/es/floater_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/es/panel_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/es/panel_preferences_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/fr/floater_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/fr/panel_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/fr/panel_preferences_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/it/floater_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/it/panel_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/it/panel_preferences_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/ja/floater_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/ja/panel_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/ja/panel_preferences_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/pl/floater_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/pl/panel_preferences_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/pt/floater_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/pt/panel_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/pt/panel_preferences_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/ru/floater_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/ru/panel_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/ru/panel_preferences_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/tr/floater_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/tr/panel_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/tr/panel_preferences_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/zh/floater_nearby_chat.xml 6b887df85f95 > indra/newview/skins/default/xui/zh/panel_preferences_chat.xml 6b887df85f95 > > Diff: http://codereview.secondlife.com/r/511/diff > > > Testing > ------- > > > Thanks, > > Vadim > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111102/c4cfcf4e/attachment.htm From oz at lindenlab.com Wed Nov 2 17:18:05 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Wed, 02 Nov 2011 17:18:05 -0700 Subject: [opensource-dev] Snowstorm Meeting schedule changes Message-ID: <4EB1DDBD.7010802@lindenlab.com> I'm making some changes to meeting times .... my public calendars are updated, so the various notices driven by them should be correct. The daily scrum meetings are cancelled, effective immediately. The Monday open meeting has not changed, but the Tuesday meeting has moved to the same time on Thursday effective next week. Starting next week, I'll have a few 15 minute appointment slots that you can book on Tuesdays, Wednesdays, and Fridays; the booking page is here and linked from the Snowstorm Calendar . -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111102/79e08daa/attachment.htm From wolfpup67 at earthlink.net Thu Nov 3 04:14:29 2011 From: wolfpup67 at earthlink.net (WolfPup Lowenhar) Date: Thu, 3 Nov 2011 07:14:29 -0400 Subject: [opensource-dev] Snowstorm Meeting schedule changes In-Reply-To: <4EB1DDBD.7010802@lindenlab.com> References: <4EB1DDBD.7010802@lindenlab.com> Message-ID: <000301cc9a19$c196fee0$44c4fca0$@net> I have 2 questions for you Oz. 1. Will the daily meeting be coming back at all? 2. Those of us that have something that we are already working on how are we to let you know of our progress or if we have something blocking progress on that task? From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Oz Linden (Scott Lawrence) Sent: Wednesday, November 02, 2011 8:18 PM To: opensource-dev Subject: [opensource-dev] Snowstorm Meeting schedule changes I'm making some changes to meeting times .... my public calendars are updated, so the various notices driven by them should be correct. The daily scrum meetings are cancelled, effective immediately. The Monday open meeting has not changed, but the Tuesday meeting has moved to the same time on Thursday effective next week. Starting next week, I'll have a few 15 minute appointment slots that you can book on Tuesdays, Wednesdays, and Fridays; the booking page is here and linked from the Snowstorm Calendar . _____ No virus found in this message. Checked by AVG - www.avg.com Version: 2012.0.1834 / Virus Database: 2092/4591 - Release Date: 11/02/11 -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111103/0adc7d28/attachment.htm From tillie at xp2.de Fri Nov 4 02:55:54 2011 From: tillie at xp2.de (Tillie Ariantho) Date: Fri, 04 Nov 2011 10:55:54 +0100 Subject: [opensource-dev] Client: Library description + how to a add a new library best Message-ID: <4EB3B6AA.7050104@xp2.de> Hello, so after 1 day fiddling with stuffs I got the client compiled on windows finally with Visual Studio 2010 Express (yay!). So now I want to try adding the EXIF stuff to 'Snapshot to Disk' again. Do we have a description of all the libraries being used by the client so I can find out if we already have what's neede somewhere in there or do I have to look them up all on google and find out myself? :) If there is nothing usedful I would try to go for Exiv2. Is this one usable? --snip-- http://www.exiv2.org/download.html#license Exiv2 is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. Alternatively, Exiv2 is also available with a commercial license, which allows it to be used in closed-source projects. Contact me for more information. --snip-- What's the best way to add a new library, where do I start? I had exiv2 in some year ago in an older version of the client, and I know adding the library was the worst part, adding the couple lines of code was lots easier. Maybe some hints where and how to add it? Thank you! Tillie From thomas.shikami at online.de Fri Nov 4 10:12:49 2011 From: thomas.shikami at online.de (Thomas Shikami) Date: Fri, 04 Nov 2011 18:12:49 +0100 Subject: [opensource-dev] Client: Library description + how to a add a new library best In-Reply-To: <4EB3B6AA.7050104@xp2.de> References: <4EB3B6AA.7050104@xp2.de> Message-ID: <4EB41D11.7000302@online.de> libexif is LGPLv2.1 licensed, so matches the viewer license. As you just want to write exif data only, you might take a look at exif.org and write a simple static exif data generator from scratch. Am 04.11.2011 10:55, schrieb Tillie Ariantho: > Hello, > > so after 1 day fiddling with stuffs I got the client compiled on windows finally with Visual Studio 2010 Express (yay!). > > So now I want to try adding the EXIF stuff to 'Snapshot to Disk' again. Do we have a description of all the libraries being used by the client so I can find out if we already have what's neede > somewhere in there or do I have to look them up all on google and find out myself? :) > > If there is nothing usedful I would try to go for Exiv2. Is this one usable? > -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 4471 bytes Desc: S/MIME Kryptografische Unterschrift Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111104/bfc97fa5/attachment.bin From iseki at solar-system.tuis.ac.jp Sat Nov 5 01:38:51 2011 From: iseki at solar-system.tuis.ac.jp (Fumi.Iseki) Date: Sat, 05 Nov 2011 17:38:51 +0900 Subject: [opensource-dev] Real Time Animation with Kinect In-Reply-To: <20111102072533.00007879.0824@affrs.tuis.ac.jp> References: <20111102072533.00007879.0824@affrs.tuis.ac.jp> Message-ID: <4EB4F61B.8090105@solar-system.tuis.ac.jp> Hi responders, Thank you for the attention. We released the system as open source. Please see our wiki, if you are interested. http://www.nsl.tuis.ac.jp/xoops/modules/xpwiki/?SLKinect Thanks. -- Fumikazu Iseki Tokyo Univ. of Info. Sci. mailto:iseki at solar-system.tuis.ac.jp http://www.nsl.tuis.ac.jp/ From patnad at griderz.com Sat Nov 5 08:08:29 2011 From: patnad at griderz.com (Pat Nad) Date: Sat, 5 Nov 2011 11:08:29 -0400 Subject: [opensource-dev] Real Time Animation with Kinect In-Reply-To: <4EB4F61B.8090105@solar-system.tuis.ac.jp> References: <20111102072533.00007879.0824@affrs.tuis.ac.jp>, <4EB4F61B.8090105@solar-system.tuis.ac.jp> Message-ID: Would be awesome if it can be integrated in all 3rd party viewer as well as SL official viewer, im sure lots of resident has the Kinect. > Date: Sat, 5 Nov 2011 17:38:51 +0900 > From: iseki at solar-system.tuis.ac.jp > To: opensource-dev at lists.secondlife.com > Subject: Re: [opensource-dev] Real Time Animation with Kinect > > Hi responders, > > Thank you for the attention. > > We released the system as open source. > Please see our wiki, if you are interested. > http://www.nsl.tuis.ac.jp/xoops/modules/xpwiki/?SLKinect > > Thanks. > > > -- > > Fumikazu Iseki > Tokyo Univ. of Info. Sci. > mailto:iseki at solar-system.tuis.ac.jp > http://www.nsl.tuis.ac.jp/ > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111105/eae33a1e/attachment.htm From nickyperian at yahoo.com Sun Nov 6 08:59:38 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Sun, 06 Nov 2011 16:59:38 -0000 Subject: [opensource-dev] Review Request: Pull mesh-upload from Firestorm viewer. Message-ID: <20111106165938.4100.16354@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/512/ ----------------------------------------------------------- Review request for Viewer. Summary ------- This is from the firestorm viewer project. At commit it passes hg policy. The only changes made were to pull in the windows archive from http://bitbucket.org/NickyP/viewer-development-os-mesh-upload/downloads/nd_hacd-0.131-windows-20111105.tar.bz2. Linux and mac are using phoenix viewer archives for HACD. Diffs ----- autobuild.xml 6b887df85f95 doc/contributions.txt 6b887df85f95 indra/cmake/CMakeLists.txt 6b887df85f95 indra/cmake/FindHACD.cmake PRE-CREATION indra/cmake/HACD.cmake PRE-CREATION indra/cmake/LLConvexDecomposition.cmake 6b887df85f95 indra/cmake/ViewerMiscLibs.cmake 6b887df85f95 indra/newview/CMakeLists.txt 6b887df85f95 indra/newview/llmeshrepository.cpp 6b887df85f95 Diff: http://codereview.secondlife.com/r/512/diff Testing ------- Built the viewer, logged to aditi, uploaded a self made primstar tutorial mesh. Future work will be to obtain linux and mac pre-built libraries from OPEN-122 project and repeat mesh upload. Thanks, Nicky -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111106/32a96f3e/attachment.htm From Lance.Corrimal at eregion.de Sun Nov 6 09:54:51 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Sun, 06 Nov 2011 17:54:51 -0000 Subject: [opensource-dev] Review Request: Pull mesh-upload from Firestorm viewer. In-Reply-To: <20111106165938.4100.16354@domU-12-31-38-00-90-68.compute-1.internal> References: <20111106165938.4100.16354@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111106175451.5077.53442@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/512/#review1072 ----------------------------------------------------------- doesn't build on debian lenny. here's the error: In function `nd_hacdConvexDecomposition::registerCallback(int, int (*)(char const*, int, int))': nd_hacdConvexDecomposition.cpp:(.text+0xd99): undefined reference to `std::ctype::_M_widen_init() const' /usr/src/dolphin/dolphinviewer3/build-linux-i686/packages/lib/release/libhacd.a(hacdHACD.cpp.o): In function `HACD::HACD::Compute(bool, bool)': hacdHACD.cpp:(.text+0x4c79): undefined reference to `std::ctype::_M_widen_init() const' hacdHACD.cpp:(.text+0x4c9c): undefined reference to `std::ctype::_M_widen_init() const' hacdHACD.cpp:(.text+0x4cc5): undefined reference to `std::ctype::_M_widen_init() const' hacdHACD.cpp:(.text+0x4cee): undefined reference to `std::ctype::_M_widen_init() const' - Lance On Nov. 6, 2011, 8:59 a.m., Nicky Perian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/512/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2011, 8:59 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is from the firestorm viewer project. At commit it passes hg policy. The only changes made were to pull in the windows archive from http://bitbucket.org/NickyP/viewer-development-os-mesh-upload/downloads/nd_hacd-0.131-windows-20111105.tar.bz2. Linux and mac are using phoenix viewer archives for HACD. > > > Diffs > ----- > > autobuild.xml 6b887df85f95 > doc/contributions.txt 6b887df85f95 > indra/cmake/CMakeLists.txt 6b887df85f95 > indra/cmake/FindHACD.cmake PRE-CREATION > indra/cmake/HACD.cmake PRE-CREATION > indra/cmake/LLConvexDecomposition.cmake 6b887df85f95 > indra/cmake/ViewerMiscLibs.cmake 6b887df85f95 > indra/newview/CMakeLists.txt 6b887df85f95 > indra/newview/llmeshrepository.cpp 6b887df85f95 > > Diff: http://codereview.secondlife.com/r/512/diff > > > Testing > ------- > > Built the viewer, logged to aditi, uploaded a self made primstar tutorial mesh. > > Future work will be to obtain linux and mac pre-built libraries from OPEN-122 project and repeat mesh upload. > > > Thanks, > > Nicky > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111106/c7a0bf04/attachment.htm From nickyperian at yahoo.com Sun Nov 6 14:51:32 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Sun, 6 Nov 2011 14:51:32 -0800 (PST) Subject: [opensource-dev] linux build errors Message-ID: <1320619892.83499.YahooMailNeo@web43508.mail.sp1.yahoo.com> anyone else receiving this and is there a workaround? [ 59%] [ 59%] Building CXX object newview/CMakeFiles/secondlife-bin.dir/llvopartgroup.o Building CXX object newview/CMakeFiles/secondlife-bin.dir/llvosurfacepatch.o cc1plus: warnings being treated as errors /home/bill/viewer-development-os-mesh-upload/indra/newview/llvopartgroup.cpp: In member function ?virtual void LLVOPartGroup::getGeometry(S32, LLStrider&, LLStrider&, LLStrider&, LLStrider&, LLStrider&)?: /home/bill/viewer-development-os-mesh-upload/indra/newview/llvopartgroup.cpp:332: error: array subscript is above array bounds /home/bill/viewer-development-os-mesh-upload/indra/newview/llvopartgroup.cpp:334: error: array subscript is above array bounds /home/bill/viewer-development-os-mesh-upload/indra/newview/llvopartgroup.cpp:336: error: array subscript is above array bounds /home/bill/viewer-development-os-mesh-upload/indra/newview/llvopartgroup.cpp:338: error: array subscript is above array bounds make[2]: *** [newview/CMakeFiles/secondlife-bin.dir/llvopartgroup.o] Er -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111106/7ab8016e/attachment.htm From sl.nicky.ml at googlemail.com Sun Nov 6 16:34:19 2011 From: sl.nicky.ml at googlemail.com (Nicky D.) Date: Mon, 7 Nov 2011 01:34:19 +0100 Subject: [opensource-dev] linux build errors In-Reply-To: <1320619892.83499.YahooMailNeo@web43508.mail.sp1.yahoo.com> References: <1320619892.83499.YahooMailNeo@web43508.mail.sp1.yahoo.com> Message-ID: > anyone else receiving this and is there a workaround? It had been once discussed on the mailinglist. That code is really a bit hackerish and would need some love. One of the (still hacked) workarounds can be found here https://bitbucket.org/NickyD/viewer-development/changeset/0c2cb53f7 Cheers, Nicky From jamesh at bluewallgroup.com Mon Nov 7 13:12:21 2011 From: jamesh at bluewallgroup.com (James Hughes) Date: Mon, 07 Nov 2011 16:12:21 -0500 Subject: [opensource-dev] Build errors with Linux with updated llqtwebkit (API 16) Message-ID: <4EB849B5.4040004@bluewallgroup.com> Trying to build recent llqtwebkit into viewer-develop [ 52%] Building CXX object media_plugins/webkit/CMakeFiles/media_plugin_webkit.dir/media_plugin_webkit.o [ 52%] Building CXX object media_plugins/webkit/CMakeFiles/media_plugin_webkit.dir/dummy_volume_catcher.o Linking CXX shared library libmedia_plugin_webkit.so /usr/lib/gcc/i586-suse-linux/4.5/../../../../i586-suse-linux/bin/ld: cannot find -lQtWebKit /usr/lib/gcc/i586-suse-linux/4.5/../../../../i586-suse-linux/bin/ld: cannot find -lQtOpenGL /usr/lib/gcc/i586-suse-linux/4.5/../../../../i586-suse-linux/bin/ld: cannot find -lQtNetwork /usr/lib/gcc/i586-suse-linux/4.5/../../../../i586-suse-linux/bin/ld: cannot find -lQtGui /usr/lib/gcc/i586-suse-linux/4.5/../../../../i586-suse-linux/bin/ld: cannot find -lQtCore /usr/lib/gcc/i586-suse-linux/4.5/../../../../i586-suse-linux/bin/ld: cannot find -lqgif /usr/lib/gcc/i586-suse-linux/4.5/../../../../i586-suse-linux/bin/ld: cannot find -lqjpeg collect2: ld returned 1 exit status make[2]: *** [media_plugins/webkit/libmedia_plugin_webkit.so] Error 1 make[1]: *** [media_plugins/webkit/CMakeFiles/media_plugin_webkit.dir/all] Error 2 make: *** [all] Error 2 From nickyperian at yahoo.com Mon Nov 7 13:20:22 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Mon, 7 Nov 2011 13:20:22 -0800 (PST) Subject: [opensource-dev] Build errors with Linux with updated llqtwebkit (API 16) In-Reply-To: <4EB849B5.4040004@bluewallgroup.com> References: <4EB849B5.4040004@bluewallgroup.com> Message-ID: <1320700822.98743.YahooMailNeo@web43506.mail.sp1.yahoo.com> Ran into this last week and solved by adding Python-Qt4 package. ________________________________ From: James Hughes To: Opensource Viewer Dev Sent: Monday, November 7, 2011 3:12 PM Subject: [opensource-dev] Build errors with Linux with updated llqtwebkit (API 16) Trying to build recent llqtwebkit into viewer-develop [ 52%] Building CXX object media_plugins/webkit/CMakeFiles/media_plugin_webkit.dir/media_plugin_webkit.o [ 52%] Building CXX object media_plugins/webkit/CMakeFiles/media_plugin_webkit.dir/dummy_volume_catcher.o Linking CXX shared library libmedia_plugin_webkit.so /usr/lib/gcc/i586-suse-linux/4.5/../../../../i586-suse-linux/bin/ld: cannot find -lQtWebKit /usr/lib/gcc/i586-suse-linux/4.5/../../../../i586-suse-linux/bin/ld: cannot find -lQtOpenGL /usr/lib/gcc/i586-suse-linux/4.5/../../../../i586-suse-linux/bin/ld: cannot find -lQtNetwork /usr/lib/gcc/i586-suse-linux/4.5/../../../../i586-suse-linux/bin/ld: cannot find -lQtGui /usr/lib/gcc/i586-suse-linux/4.5/../../../../i586-suse-linux/bin/ld: cannot find -lQtCore /usr/lib/gcc/i586-suse-linux/4.5/../../../../i586-suse-linux/bin/ld: cannot find -lqgif /usr/lib/gcc/i586-suse-linux/4.5/../../../../i586-suse-linux/bin/ld: cannot find -lqjpeg collect2: ld returned 1 exit status make[2]: *** [media_plugins/webkit/libmedia_plugin_webkit.so] Error 1 make[1]: *** [media_plugins/webkit/CMakeFiles/media_plugin_webkit.dir/all] Error 2 make: *** [all] Error 2 _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111107/4b1a8705/attachment.htm From jamesh at bluewallgroup.com Tue Nov 8 12:01:29 2011 From: jamesh at bluewallgroup.com (BlueWall) Date: Tue, 08 Nov 2011 15:01:29 -0500 Subject: [opensource-dev] Build errors with Linux with updated llqtwebkit (API 16) In-Reply-To: <4EB849B5.4040004@bluewallgroup.com> References: <4EB849B5.4040004@bluewallgroup.com> Message-ID: <4EB98A99.7010305@bluewallgroup.com> I have been able to get a running viewer with the llqtwebkit API 16. I will need to work through the issues and make patches to the build system to automate it. Basically a lot of the library files aren't getting packaged in autobuild, and a couple aren't sent with the packged viewer. I was able to login to my development grid, then jump to Wright Plaza on OSGrid and run for 2-3 minutes before crashing. I had a popup... ERROR: genVolumeBBoxes: ASSERT (less_than_max_mag(newMin)) Thanks, BlueWall From Lance.Corrimal at eregion.de Sat Nov 12 04:07:12 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Sat, 12 Nov 2011 12:07:12 -0000 Subject: [opensource-dev] Review Request: Mouse pointer flickers when hovering over any active/clickable UI item Message-ID: <20111112120712.4099.97155@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/513/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Mouse pointer flickers when hovering over any active/clickable UI item, for example the links on the login screen or in search. This addresses bug VWR-27477. http://jira.secondlife.com/browse/VWR-27477 Diffs ----- doc/contributions.txt ae5236b6f788 indra/llui/llview.cpp ae5236b6f788 Diff: http://codereview.secondlife.com/r/513/diff Testing ------- built on linux, tested, works as expected Thanks, Lance -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111112/26ebdf80/attachment.htm From laurent.bechir at madonie.org Sat Nov 12 06:08:47 2011 From: laurent.bechir at madonie.org (Laurent Bechir) Date: Sat, 12 Nov 2011 15:08:47 +0100 Subject: [opensource-dev] Build of the viewer with Xcode on Leopard Message-ID: <4EBE7DEF.4020200@madonie.org> Hello, My Mac is on Lion and I don't have anymore Snow Leopard DVD. Will I be able to build the viewer with Xcode on Leopard ? When will we be able to build the viewer using Xcode on Lion ? Thank you From jhwelch at gmail.com Sat Nov 12 09:21:12 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Sat, 12 Nov 2011 17:21:12 -0000 Subject: [opensource-dev] Review Request: Mouse pointer flickers when hovering over any active/clickable UI item In-Reply-To: <20111112120712.4099.97155@domU-12-31-38-00-90-68.compute-1.internal> References: <20111112120712.4099.97155@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111112172112.5064.98632@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/513/#review1073 ----------------------------------------------------------- indra/llui/llview.cpp If the fix is to not call setCursor then just delete the line, and you can also delete the now-unneeded comment as well. - Jonathan On Nov. 12, 2011, 4:07 a.m., Lance Corrimal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/513/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2011, 4:07 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Mouse pointer flickers when hovering over any active/clickable UI item, for example the links on the login screen or in search. > > > This addresses bug VWR-27477. > http://jira.secondlife.com/browse/VWR-27477 > > > Diffs > ----- > > doc/contributions.txt ae5236b6f788 > indra/llui/llview.cpp ae5236b6f788 > > Diff: http://codereview.secondlife.com/r/513/diff > > > Testing > ------- > > built on linux, tested, works as expected > > > Thanks, > > Lance > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111112/2ecad6b3/attachment.htm From stone at lindenlab.com Sat Nov 12 09:40:27 2011 From: stone at lindenlab.com (Stone Linden) Date: Sat, 12 Nov 2011 09:40:27 -0800 Subject: [opensource-dev] Build of the viewer with Xcode on Leopard In-Reply-To: <4EBE7DEF.4020200@madonie.org> References: <4EBE7DEF.4020200@madonie.org> Message-ID: You can build with Xcode 3.2 on Lion right now. If you have Xcode 4.2 on Lion, you'll need this patch to the Viewer's indra/cmake/Variables.cmake config: https://codereview.secondlife.com/r/502/ It compiles and runs for me, but all UI textures are marked missing with messages like this: 2011-11-12T17:38:28Z WARNING: LLViewerTexture::setIsMissingAsset: file:///Users/aaron/Code/Linden/viewer-development/indra/newview/skins/default/textures/icons/Progress_2.png: Marking image as missing 2011-11-12T17:38:28Z WARNING: LLViewerTextureList::getImageFromFile: Failed to find local image file: inv_folder_mesh.tga I think once that texture issue is worked out, that patch above could be proposed for mainline. (It behaves identically as the current cmake config when running on Leopard/Snow Leopard with Xcode 3.2.) Stone On Sat, Nov 12, 2011 at 6:08 AM, Laurent Bechir wrote: > > Hello, > > My Mac is on Lion and I don't have anymore Snow Leopard DVD. Will I be > able to build the viewer with Xcode on Leopard ? When will we be able to > build the viewer using Xcode on Lion ? > > Thank you > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111112/d6934a0d/attachment.htm From geenz at geenzo.com Sat Nov 12 09:47:53 2011 From: geenz at geenzo.com (Geenz) Date: Sat, 12 Nov 2011 12:47:53 -0500 Subject: [opensource-dev] Build of the viewer with Xcode on Leopard In-Reply-To: References: <4EBE7DEF.4020200@madonie.org> Message-ID: There is a way around the UI texture problem that's proven to work (though seems to cut OS X 10.5 out of the equation in the process). At this point, until 3p-apr is patched, you have to compile against the system's APR libraries. This seemingly fixes the UI issue, and you can find more details here: https://jira.secondlife.com/browse/STORM-938?. Mimika Oh's specific changes to compile against the system's APR libraries can be found here: https://bitbucket.org/Mimika_Oh/viewer-development/changeset/b63ec6bcf64d. -- Geenz Sent with Sparrow (http://www.sparrowmailapp.com/?sig) On Saturday, November 12, 2011 at 12:40 PM, Stone Linden wrote: > You can build with Xcode 3.2 on Lion right now. If you have Xcode 4.2 on Lion, you'll need this patch to the Viewer's indra/cmake/Variables.cmake config: > > https://codereview.secondlife.com/r/502/ > > It compiles and runs for me, but all UI textures are marked missing with messages like this: > > 2011-11-12T17:38:28Z WARNING: LLViewerTexture::setIsMissingAsset: file:///Users/aaron/Code/Linden/viewer-development/indra/newview/skins/default/textures/icons/Progress_2.png: Marking image as missing > 2011-11-12T17:38:28Z WARNING: LLViewerTextureList::getImageFromFile: Failed to find local image file: inv_folder_mesh.tga > > I think once that texture issue is worked out, that patch above could be proposed for mainline. (It behaves identically as the current cmake config when running on Leopard/Snow Leopard with Xcode 3.2.) > > Stone > > > On Sat, Nov 12, 2011 at 6:08 AM, Laurent Bechir wrote: > > > > Hello, > > > > My Mac is on Lion and I don't have anymore Snow Leopard DVD. Will I be > > able to build the viewer with Xcode on Leopard ? When will we be able to > > build the viewer using Xcode on Lion ? > > > > Thank you > > _______________________________________________ > > Policies and (un)subscribe information available here: > > http://wiki.secondlife.com/wiki/OpenSource-Dev > > Please read the policies before posting to keep unmoderated posting privileges > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111112/4d9ad310/attachment.htm From ardylay at gmail.com Sat Nov 12 11:03:57 2011 From: ardylay at gmail.com (ardylay at gmail.com) Date: Sat, 12 Nov 2011 19:03:57 -0000 Subject: [opensource-dev] Review Request: Mouse pointer flickers when hovering over any active/clickable UI item In-Reply-To: <20111112120712.4099.97155@domU-12-31-38-00-90-68.compute-1.internal> References: <20111112120712.4099.97155@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111112190357.5064.92517@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/513/#review1074 ----------------------------------------------------------- Mouse cursor behavior is much better with this patch applied. - ardy.lay On Nov. 12, 2011, 4:07 a.m., Lance Corrimal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/513/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2011, 4:07 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Mouse pointer flickers when hovering over any active/clickable UI item, for example the links on the login screen or in search. > > > This addresses bug VWR-27477. > http://jira.secondlife.com/browse/VWR-27477 > > > Diffs > ----- > > doc/contributions.txt ae5236b6f788 > indra/llui/llview.cpp ae5236b6f788 > > Diff: http://codereview.secondlife.com/r/513/diff > > > Testing > ------- > > built on linux, tested, works as expected > > > Thanks, > > Lance > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111112/61e1a8bf/attachment-0001.htm From Lance.Corrimal at eregion.de Sat Nov 12 11:14:54 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Sat, 12 Nov 2011 19:14:54 -0000 Subject: [opensource-dev] Review Request: Mouse pointer flickers when hovering over any active/clickable UI item In-Reply-To: <20111112120712.4099.97155@domU-12-31-38-00-90-68.compute-1.internal> References: <20111112120712.4099.97155@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111112191454.4098.8704@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/513/ ----------------------------------------------------------- (Updated Nov. 12, 2011, 11:14 a.m.) Review request for Viewer. Changes ------- Yep, removing would have been better right from the start, but commenting out is easier to undo in case that would have *not* been the solution ;) anyway, patch updated. Summary ------- Mouse pointer flickers when hovering over any active/clickable UI item, for example the links on the login screen or in search. This addresses bug VWR-27477. http://jira.secondlife.com/browse/VWR-27477 Diffs (updated) ----- doc/contributions.txt ae5236b6f788 indra/llui/llview.cpp ae5236b6f788 Diff: http://codereview.secondlife.com/r/513/diff Testing ------- built on linux, tested, works as expected Thanks, Lance -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111112/dc289c0e/attachment.htm From jhwelch at gmail.com Sat Nov 12 11:55:32 2011 From: jhwelch at gmail.com (Jonathan Welch) Date: Sat, 12 Nov 2011 14:55:32 -0500 Subject: [opensource-dev] Mac & Linux testers needed Message-ID: I need someone who has built the viewer from tip on the 11th or later on both mac and linux to perform a quick test: can you resize your viewer window below 1024x768? If so would you please comment on VWR-27482 (Unable to resize viewer window below 1024x768)? https://jira.secondlife.com/browse/VWR-27482 It is not clear that all operating systems have the same new window size limits. Thank you, -Jonathan From Lance.Corrimal at eregion.de Sat Nov 12 13:54:23 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Sat, 12 Nov 2011 22:54:23 +0100 Subject: [opensource-dev] I could use a little help with boost and callbacks and stuff Message-ID: <201111122254.24153.Lance.Corrimal@eregion.de> Hi there, I'm banging my head against a problem here... I want to add buttons to the toolboxes. The actuall adding is easy, but I have trouble figuring out what I need to do to register some callbacks into the classes I need. I have two classes that I need to "buttonize"... one represents the graphical UI for a set of new features, and that one I managed to set up as a toolbox button just fine. The other one is troublesome though. I need to establish a method that gets called (with no parameter, or a dummy), to toggle an internal switch in my class, and I need another callback, that returns the boolean value of that internal switch, to turn the button green or not. Think of a simple "on/off switch". What I can't figure out is what I actually have to do with my class to implement the callbacks properly, and what I have to pass to the function that registers the callback. Any hints/tips for me? thanks, LC From kf6kjg at gmail.com Sat Nov 12 18:29:36 2011 From: kf6kjg at gmail.com (Ricky) Date: Sat, 12 Nov 2011 18:29:36 -0800 Subject: [opensource-dev] Mac & Linux testers needed In-Reply-To: References: Message-ID: Can an official build be used to test this, or does the test actually require a custom build? Ricky Cron Stardust On Sat, Nov 12, 2011 at 11:55 AM, Jonathan Welch wrote: > I need someone who has built the viewer from tip on the 11th or later > on both mac and linux to perform a quick test: can you resize your > viewer window below 1024x768? > > If so would you please comment on VWR-27482 (Unable to resize viewer > window below 1024x768)? > https://jira.secondlife.com/browse/VWR-27482 > > It is not clear that all operating systems have the same new window size limits. > > Thank you, > > -Jonathan > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges > From kf6kjg at gmail.com Sat Nov 12 18:43:00 2011 From: kf6kjg at gmail.com (Ricky) Date: Sat, 12 Nov 2011 18:43:00 -0800 Subject: [opensource-dev] I could use a little help with boost and callbacks and stuff In-Reply-To: <201111122254.24153.Lance.Corrimal@eregion.de> References: <201111122254.24153.Lance.Corrimal@eregion.de> Message-ID: Is something like: std::bind1st(std::mem_fun(&MyClass::MyMethod), myParameter) what you are looking for? You can see working code using that on lines 350-390 of https://bitbucket.org/kf6kjg/gsp-420-engine-design-graphics/src/120a2081bb2f/src/audio_core/AudioCore.cpp (This was code I wrote while helping out another team in one of my classes.) Boost's Bind function (http://www.boost.org/doc/libs/1_47_0/libs/bind/bind.html) generalizes the standard call I used, and so might be easier to use. Here's the same using Boost: bind(&MyClass::MyMethod, myParameter) I hope this helps, Ricky Cron Stardust On Sat, Nov 12, 2011 at 1:54 PM, Lance Corrimal wrote: > Hi there, > > > I'm banging my head against a problem here... > I want to add buttons to the toolboxes. > > The actuall adding is easy, but I have trouble figuring out what I > need to do to register some callbacks into the classes I need. > > I have two classes that I need to "buttonize"... one represents the > graphical UI for a set of new features, and that one I managed to set > up as a toolbox button just fine. > > The other one is troublesome though. I need to establish a method that > gets called (with no parameter, or a dummy), to toggle an internal > switch in my class, and I need another callback, that returns the > boolean value of that internal switch, to turn the button green or > not. Think of a simple "on/off switch". > > What I can't figure out is what I actually have to do with my class to > implement the callbacks properly, and what I have to pass to the > function that registers the callback. > > Any hints/tips for me? > > thanks, > > LC > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges > From Lance.Corrimal at eregion.de Sat Nov 12 23:51:14 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Sun, 13 Nov 2011 08:51:14 +0100 Subject: [opensource-dev] I could use a little help with boost and callbacks and stuff In-Reply-To: References: <201111122254.24153.Lance.Corrimal@eregion.de> Message-ID: <201111130851.14542.Lance.Corrimal@eregion.de> I guess I wasn't exactly clear... What I need to know is how I have to modify my classes to make them work with boost::bind and the CallbackRegistry. When I try to just duplicate the way that other classes in the viewer use to register methods in the CallbackRegistry, I get tons of boost errors when building, all culminating from some missing function or such that is called get_pointer... So I think I need to inherit some special class or something, but I can't find which one! And what do I pass to the bind() call, there are several different ways to call it, with one, two, or three parameters, and what's the _(number) that usually gets passed last? As you can see, I don't really know what I'm doing there. bye, LC Am Sonntag, 13. November 2011 schrieb Ricky: > Is something like: > std::bind1st(std::mem_fun(&MyClass::MyMethod), myParameter) > what you are looking for? > > You can see working code using that on lines 350-390 of > https://bitbucket.org/kf6kjg/gsp-420-engine-design-graphics/src/120 > a2081bb2f/src/audio_core/AudioCore.cpp (This was code I wrote while > helping out another team in one of my classes.) > > Boost's Bind function > (http://www.boost.org/doc/libs/1_47_0/libs/bind/bind.html) > generalizes the standard call I used, and so might be easier to > use. Here's the same using Boost: > bind(&MyClass::MyMethod, myParameter) > > I hope this helps, > Ricky > Cron Stardust > > On Sat, Nov 12, 2011 at 1:54 PM, Lance Corrimal > > wrote: > > Hi there, > > > > > > I'm banging my head against a problem here... > > I want to add buttons to the toolboxes. > > > > The actuall adding is easy, but I have trouble figuring out what > > I need to do to register some callbacks into the classes I need. > > > > I have two classes that I need to "buttonize"... one represents > > the graphical UI for a set of new features, and that one I > > managed to set up as a toolbox button just fine. > > > > The other one is troublesome though. I need to establish a method > > that gets called (with no parameter, or a dummy), to toggle an > > internal switch in my class, and I need another callback, that > > returns the boolean value of that internal switch, to turn the > > button green or not. Think of a simple "on/off switch". > > > > What I can't figure out is what I actually have to do with my > > class to implement the callbacks properly, and what I have to > > pass to the function that registers the callback. > > > > Any hints/tips for me? > > > > thanks, > > > > LC > > _______________________________________________ > > Policies and (un)subscribe information available here: > > http://wiki.secondlife.com/wiki/OpenSource-Dev > > Please read the policies before posting to keep unmoderated > > posting privileges From Lance.Corrimal at eregion.de Sat Nov 12 23:54:57 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Sun, 13 Nov 2011 08:54:57 +0100 Subject: [opensource-dev] Mac & Linux testers needed In-Reply-To: References: Message-ID: <201111130854.57322.Lance.Corrimal@eregion.de> Am Samstag, 12. November 2011 schrieb Jonathan Welch: > I need someone who has built the viewer from tip on the 11th or > later on both mac and linux to perform a quick test: can you > resize your viewer window below 1024x768? > > If so would you please comment on VWR-27482 (Unable to resize > viewer window below 1024x768)? > https://jira.secondlife.com/browse/VWR-27482 > > It is not clear that all operating systems have the same new window > size limits. I have a linux build here where the latest changeset is 21493:ae5236b6f788 which is the current tip so that one should qualify. Smallest I could resize: 18x27 pixel. bye, LC From kf6kjg at gmail.com Sun Nov 13 00:24:11 2011 From: kf6kjg at gmail.com (Ricky) Date: Sun, 13 Nov 2011 00:24:11 -0800 Subject: [opensource-dev] I could use a little help with boost and callbacks and stuff In-Reply-To: <201111130851.14542.Lance.Corrimal@eregion.de> References: <201111122254.24153.Lance.Corrimal@eregion.de> <201111130851.14542.Lance.Corrimal@eregion.de> Message-ID: IIRC that _number thing has to do with iteration. The example code I gave in the email here passes one parameter (myParameter). I'm not as strong with Boost or the Standard Lib methods as I was a couple of months ago, but I don't recall there being a no-parameter version. The count of parameters is entirely dependent upon the function/method being passed. I discovered this technique online after searching the 'net looking for how to work with functions and methods as first-class types in C++: I wanted to pass the method of a class instance off to another function (in my case, a template) so that is could call it in a centralized manner. I was able to do so this way, though it feels a bit hackish - like a lot of C++ I'm afraid. (Yes, C++ isn't my fav language, but D isn't what we are working in.) Sorry I can't help much farther: my experience is limited, and my SL viewer hacking experience is even more limited! Ricky Cron Stardus On Sat, Nov 12, 2011 at 11:51 PM, Lance Corrimal wrote: > I guess I wasn't exactly clear... > > > What I need to know is how I have to modify my classes to make them > work with boost::bind and the CallbackRegistry. > > When I try to just duplicate the way that other classes in the viewer > use to register methods in the CallbackRegistry, I get tons of boost > errors when building, all culminating from some missing function or > such that is called get_pointer... > > So I think I need to inherit some special class or something, but I > can't find which one! > > And what do I pass to the bind() call, there are several different > ways to call it, with one, two, or three parameters, and what's the > _(number) that usually gets passed last? > > > As you can see, I don't really know what I'm doing there. > > bye, > LC > > > Am Sonntag, 13. November 2011 schrieb Ricky: >> Is something like: >> std::bind1st(std::mem_fun(&MyClass::MyMethod), myParameter) >> what you are looking for? >> >> You can see working code using that on lines 350-390 of >> https://bitbucket.org/kf6kjg/gsp-420-engine-design-graphics/src/120 >> a2081bb2f/src/audio_core/AudioCore.cpp (This was code I wrote while >> helping out another team in one of my classes.) >> >> Boost's Bind function >> (http://www.boost.org/doc/libs/1_47_0/libs/bind/bind.html) >> generalizes the standard call I used, and so might be easier to >> use. ?Here's the same using Boost: >> bind(&MyClass::MyMethod, myParameter) >> >> I hope this helps, >> Ricky >> Cron Stardust >> >> On Sat, Nov 12, 2011 at 1:54 PM, Lance Corrimal >> >> wrote: >> > Hi there, >> > >> > >> > I'm banging my head against a problem here... >> > I want to add buttons to the toolboxes. >> > >> > The actuall adding is easy, but I have trouble figuring out what >> > I need to do to register some callbacks into the classes I need. >> > >> > I have two classes that I need to "buttonize"... one represents >> > the graphical UI for a set of new features, and that one I >> > managed to set up as a toolbox button just fine. >> > >> > The other one is troublesome though. I need to establish a method >> > that gets called (with no parameter, or a dummy), to toggle an >> > internal switch in my class, and I need another callback, that >> > returns the boolean value of that internal switch, to turn the >> > button green or not. Think of a simple "on/off switch". >> > >> > What I can't figure out is what I actually have to do with my >> > class to implement the callbacks properly, and what I have to >> > pass to the function that registers the callback. >> > >> > Any hints/tips for me? >> > >> > thanks, >> > >> > LC >> > _______________________________________________ >> > Policies and (un)subscribe information available here: >> > http://wiki.secondlife.com/wiki/OpenSource-Dev >> > Please read the policies before posting to keep unmoderated >> > posting privileges > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges > From kf6kjg at gmail.com Sun Nov 13 00:46:04 2011 From: kf6kjg at gmail.com (Ricky) Date: Sun, 13 Nov 2011 00:46:04 -0800 Subject: [opensource-dev] VD Build Page Hacking Message-ID: I finally got so annoyed with the build page that I decided to do some hacking on it. Turns out that the reason why it isn't displaying changesets or JIRA entries is because the JSON format was changed without correcting the Javascript. What's more, the JSON information doesn't have the needed data anymore. So. I dug and I hacked, and I hacked and I dug, and voila, I'd mashed up a facsimile of what I think it did in the past. And yes, I used the phrase "mashed up" on purpose: the page I built taps into BitBucket's REST API to get the missing data. It's not all that pretty to go that route, but it works. Here's a demonstration: http://rwcproductions.com/~ricky/snowstorm/ And here's the patch: http://rwcproductions.com/~ricky/snowstorm/index.js.patch.txt Yes, there are some whitespace changes, and render_description() could be cleaned up further, but I tried to not affect more than the areas needed to make it "workable." Suggestions, thoughts, etc. welcome. Ricky Cron Stardust From Lance.Corrimal at eregion.de Sun Nov 13 01:27:56 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Sun, 13 Nov 2011 10:27:56 +0100 Subject: [opensource-dev] I could use a little help with boost and callbacks and stuff In-Reply-To: References: <201111122254.24153.Lance.Corrimal@eregion.de> Message-ID: <201111131027.56950.Lance.Corrimal@eregion.de> Am Sonntag, 13. November 2011 schrieb Jonathan Welch: > Did you try creating a new debug variable and linking it to your > xml file that defines the new UI element you have created? the ui element is doing fine, it's the "non-ui" class that I can't get to work with the buttons... I'm trying to get Zi Ree's client side AO to work with toolbox buttons. There's a class "FLoaterAO" which is basically the setup dialog, and that works fine after "buttonizing" it. There's another class AOEngine which is the actual running AO, and that one needs to get two methods: void AOEngine::Toggle() { toggles the AO on or off } bool AOEngine::isRunning() { returns true or false depending on the state of things } I'm having trouble getting those two methods registered in the callback registry, so that I can use them in app_settings/commands.xml Any help is appreciated! bye, LC From oz at lindenlab.com Mon Nov 14 13:59:00 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Mon, 14 Nov 2011 16:59:00 -0500 Subject: [opensource-dev] Build of the viewer with Xcode on Leopard In-Reply-To: <4EBE7DEF.4020200@madonie.org> References: <4EBE7DEF.4020200@madonie.org> Message-ID: <4EC18F24.2010403@lindenlab.com> On 2011-11-12 9:08, Laurent Bechir wrote: > Hello, > > My Mac is on Lion and I don't have anymore Snow Leopard DVD. Will I be > able to build the viewer with Xcode on Leopard ? When will we be able to > build the viewer using Xcode on Lion ? > We're actively working on supporting Lion as a build environment (we'd all like to upgrade our systems too). Stay tuned.... In the mean time, the workarounds other respondents point you to may help... From nickyperian at yahoo.com Tue Nov 15 21:19:28 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Wed, 16 Nov 2011 05:19:28 -0000 Subject: [opensource-dev] Review Request: OPEN-125 Open source mesh upload using hacd. Message-ID: <20111116051928.26919.63934@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/515/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Provide viewer development changes to link a modified HACD library to provide an open source mesh upload capability. This addresses bug https://jira.secondlife.com/browse/OPEN-125. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/OPEN-125 Diffs ----- autobuild.xml 6b887df85f95 doc/contributions.txt 6b887df85f95 indra/cmake/CMakeLists.txt 6b887df85f95 indra/cmake/FindHACD.cmake PRE-CREATION indra/cmake/HACD.cmake PRE-CREATION indra/cmake/LLConvexDecomposition.cmake 6b887df85f95 indra/cmake/ViewerMiscLibs.cmake 6b887df85f95 indra/newview/CMakeLists.txt 6b887df85f95 indra/newview/llmeshrepository.cpp 6b887df85f95 Diff: http://codereview.secondlife.com/r/515/diff Testing ------- Refer to https://jira.secondlife.com/browse/OPEN-124 for modified library detail. Built viewer-development and TPV kokua under windows 7/64 bit and Debian Squeeze 32 bit linux with modified HACD. Logged to aditi, local opensim host and osgrid. Uploaded a several mesh models without problem. Thanks, Nicky -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111116/530765d4/attachment.htm From Lance.Corrimal at eregion.de Wed Nov 16 00:42:00 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Wed, 16 Nov 2011 08:42:00 -0000 Subject: [opensource-dev] Review Request: OPEN-125 Open source mesh upload using hacd. In-Reply-To: <20111116051928.26919.63934@domU-12-31-38-00-90-68.compute-1.internal> References: <20111116051928.26919.63934@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111116084200.28175.36625@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/515/#review1075 ----------------------------------------------------------- the hacd library provided does not build cleanly on mac os without manual intervention... had to manually create the "lib" folder, and then Makefile_mac is missing. - Lance On Nov. 15, 2011, 9:19 p.m., Nicky Perian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/515/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2011, 9:19 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Provide viewer development changes to link a modified HACD library to provide an open source mesh upload capability. > > > This addresses bug https://jira.secondlife.com/browse/OPEN-125. > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/OPEN-125 > > > Diffs > ----- > > autobuild.xml 6b887df85f95 > doc/contributions.txt 6b887df85f95 > indra/cmake/CMakeLists.txt 6b887df85f95 > indra/cmake/FindHACD.cmake PRE-CREATION > indra/cmake/HACD.cmake PRE-CREATION > indra/cmake/LLConvexDecomposition.cmake 6b887df85f95 > indra/cmake/ViewerMiscLibs.cmake 6b887df85f95 > indra/newview/CMakeLists.txt 6b887df85f95 > indra/newview/llmeshrepository.cpp 6b887df85f95 > > Diff: http://codereview.secondlife.com/r/515/diff > > > Testing > ------- > > Refer to https://jira.secondlife.com/browse/OPEN-124 for modified library detail. Built viewer-development and TPV kokua under windows 7/64 bit and Debian Squeeze 32 bit linux with modified HACD. Logged to aditi, local opensim host and osgrid. Uploaded a several mesh models without problem. > > > Thanks, > > Nicky > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111116/7f1e1681/attachment.htm From nickyperian at yahoo.com Wed Nov 16 04:43:19 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Wed, 16 Nov 2011 04:43:19 -0800 (PST) Subject: [opensource-dev] Review Request: OPEN-125 Open source mesh upload using hacd. In-Reply-To: <20111116084200.28175.36625@domU-12-31-38-00-90-68.compute-1.internal> References: <20111116051928.26919.63934@domU-12-31-38-00-90-68.compute-1.internal> <20111116084200.28175.36625@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <1321447399.57169.YahooMailNeo@web43512.mail.sp1.yahoo.com> Lance, I have no mac I you are willing to share I'll include you work. ________________________________ From: Lance Corrimal To: Nicky Perian ; Lance Corrimal ; Viewer Sent: Wednesday, November 16, 2011 2:42 AM Subject: Re: Review Request: OPEN-125 Open source mesh upload using hacd. This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/515/ the hacd library provided does not build cleanly on mac os without manual intervention... had to manually create the "lib" folder, and then Makefile_mac is missing. - Lance On November 15th, 2011, 9:19 p.m., Nicky Perian wrote: Review request for Viewer. By Nicky Perian. Updated Nov. 15, 2011, 9:19 p.m. Description Provide viewer development changes to link a modified HACD library to provide an open source mesh upload capability. Testing Refer to https://jira.secondlife.com/browse/OPEN-124 for modified library detail. Built viewer-development and TPV kokua under windows 7/64 bit and Debian Squeeze 32 bit linux with modified HACD. Logged to aditi, local opensim host and osgrid. Uploaded a several mesh models without problem. Bugs: http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/OPEN-125 Diffs * autobuild.xml (6b887df85f95) * doc/contributions.txt (6b887df85f95) * indra/cmake/CMakeLists.txt (6b887df85f95) * indra/cmake/FindHACD.cmake (PRE-CREATION) * indra/cmake/HACD.cmake (PRE-CREATION) * indra/cmake/LLConvexDecomposition.cmake (6b887df85f95) * indra/cmake/ViewerMiscLibs.cmake (6b887df85f95) * indra/newview/CMakeLists.txt (6b887df85f95) * indra/newview/llmeshrepository.cpp (6b887df85f95) View Diff -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111116/153a27f8/attachment.htm From Ima.Mechanique at blueyonder.co.uk Thu Nov 17 15:08:34 2011 From: Ima.Mechanique at blueyonder.co.uk (Ima Mechanique) Date: Thu, 17 Nov 2011 23:08:34 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. Message-ID: <20111117230834.26924.30320@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Changes to allow opened script window to save/load to/from files on the users computer. This addresses bug https://jira.secondlife.com/browse/storm-1708. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 Diffs ----- indra/newview/llfilepicker.h a1319d553db9 indra/newview/llfilepicker.cpp a1319d553db9 indra/newview/llfloaternamedesc.h a1319d553db9 indra/newview/llfloaternamedesc.cpp a1319d553db9 indra/newview/llpreviewscript.h a1319d553db9 indra/newview/llpreviewscript.cpp a1319d553db9 indra/newview/llviewerfloaterreg.cpp a1319d553db9 indra/newview/llviewermenufile.cpp a1319d553db9 indra/newview/skins/default/xui/en/menu_viewer.xml a1319d553db9 indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 Diff: http://codereview.secondlife.com/r/516/diff Testing ------- Successfully opened and saved scripts from/to local files. Thanks, Ima -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111117/328282c6/attachment.htm From Lance.Corrimal at eregion.de Fri Nov 18 00:56:08 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Fri, 18 Nov 2011 09:56:08 +0100 Subject: [opensource-dev] I could use a little help with boost and callbacks and stuff In-Reply-To: <201111122254.24153.Lance.Corrimal@eregion.de> References: <201111122254.24153.Lance.Corrimal@eregion.de> Message-ID: <1893829.gpzn7QEnYf@nb-20> OK. I'm coming out of the closet here. I am *HOPELESSLY LOST* with this stuff. No matter what I put where in the source, the stuff builds but it does not work at all. All I get is this in the logfile: 2011-11-18T08:16:18Z WARNING: initCommitCallback: No callback found for: 'Agent.ToggleAO' in control: aoswitch and my AO button does not work. The source is here: http://dolphinsource.eregion.de/dolphinviewer3-beta/ The logic that I'm trying to build is this: There is a button defined in app_settings/commands.xml that acts as a simple on/off switch. The callback gets registered (supposedly) in llagent.cpp, and the callback function itself is member of LLAgent. There's another callback that returns the state of the AO engine as TRUE or FALSE to tint the button. The callback LLAgent::ToggleAO() simply calls AOEngine::getinstance()- >Toggle(); ... why the *beep* does this *beep* not *beeping* work. Any help would be **GREATLY** appreciated. oh right, the files involved: llagent.* and aoengine.* the xml / ui stuff is just fine, also, dragging the AO button *from* the toolbox to the toolbox button window correctly switches the AO off... just the effing on/off button refuses to do anything. HELP!!!! thanks, LC From Lance.Corrimal at eregion.de Fri Nov 18 06:06:39 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Fri, 18 Nov 2011 14:06:39 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111117230834.26924.30320@domU-12-31-38-00-90-68.compute-1.internal> References: <20111117230834.26924.30320@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111118140639.26922.10382@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1076 ----------------------------------------------------------- Built it into dolphin 3.2 beta, tested it. found a few issues: - main menu option Build/Upload/Script does nothing at all - saving a script that you open from your inventory to disk only works after you edit the script - saving a script to disk does not add .lsl to the filename by default - Lance On Nov. 17, 2011, 3:08 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2011, 3:08 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changes to allow opened script window to save/load to/from files on the users computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/llviewermenufile.cpp a1319d553db9 > indra/newview/skins/default/xui/en/menu_viewer.xml a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111118/2293ab72/attachment.htm From oz at lindenlab.com Fri Nov 18 06:27:25 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Fri, 18 Nov 2011 09:27:25 -0500 Subject: [opensource-dev] User input solicited picking a number... Message-ID: <4EC66B4D.4040106@lindenlab.com> Jonathan Yap and Robin Cornelius have collaborated on a nice new feature... it causes parcel media streams to fade in gradually when you cross into the parcel and fade out gradually if you cross out. If you cross between parcels with the same stream, there is no fading. If you cross between parcels that have different streams, the old one fades out and then the new one fades in. I think it's a big improvement. The jira issue is STORM-591 , and trial builds are available at http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_project-2/rev/245002/index.html The current test implementation has a pair of debug variables for controlling the fade time: AudioMusicFadeIn and AudioMusicFadeOut are the number of seconds that each fade takes. In the test version above, these default to 5 seconds. We're going to integrate this feature, but without the variables: the times will just be fixed at some reasonable values. Hence this mail ... this is your chance to help pick what those values should be. Try it out, and comment in the issue (or reply to this thread, either way) with the values you think are best. Early next week we'll pick the final values and move the issue forward. /If instead you would prefer to have a debate about whether or not there should be debug variables or preferences for this, please _do not_ put those comments in the issue, and I'd appreciate it if you started a new email thread for that. That is a settled question: the additional testing complexity of having variables is not worth the flexibility./ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111118/522a8eb4/attachment.htm From oz at lindenlab.com Fri Nov 18 07:07:25 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Fri, 18 Nov 2011 10:07:25 -0500 Subject: [opensource-dev] User input solicited picking a number... In-Reply-To: References: <4EC66B4D.4040106@lindenlab.com> Message-ID: <4EC674AD.9020005@lindenlab.com> On 2011-11-18 9:53, Jonathan Welch wrote: > Any TPV that wants to pick up this new feature before the two debug > settings are eliminated should do so quickly, or else you will have to > reimplement them. > > Source here: > https://bitbucket.org/JonathanYap/storm-591b > Actually, since I'll just pull your whole repo when I merge, all they'll have to do is reverse the commit that removes the variables - it'll be in the history. I would strongly prefer that TPVs not incorporate early versions of features that we've already said we're incorporating... it only makes life more difficult for them if problems are found... ... speaking of which, I just did a whole bunch of TPing around between parcels to test the fade times I was playing with, and eventually I stopped getting any parcel audio at all. I even went back to one I'd been too earlier that had been playing ok, but I got nothing. I've kept the associated log file for you if you think it might be useful, Jonathan. From tillie at xp2.de Fri Nov 18 09:20:34 2011 From: tillie at xp2.de (Tillie Ariantho) Date: Fri, 18 Nov 2011 18:20:34 +0100 Subject: [opensource-dev] [viewer-development-builds] Successful Build Nr. 245237 for snowstorm_viewer-development (cfa78777453c) on CYGWIN In-Reply-To: <20111116005744.9D062E2CADD@viognier.lindenlab.com> References: <20111116005744.9D062E2CADD@viognier.lindenlab.com> Message-ID: <4EC693E2.4090600@xp2.de> On 16.11.2011 01:57, Automatic notification for viewer-development builds wrote: > installer_CYGWIN: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/rev/245237/arch/CYGWIN/installer/Second_Life_3-2-4-245237_Development_Setup.exe That build crashes the nVidia driver pretty often. Right now I can't even log in with the dev client, crashes the driver right after clicking Login. nVidia driver 285.62 on Win7 64bit Tillie From Lance.Corrimal at eregion.de Fri Nov 18 09:39:23 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Fri, 18 Nov 2011 18:39:23 +0100 Subject: [opensource-dev] SOLVED. I could use a little help with boost and callbacks and stuff In-Reply-To: <1893829.gpzn7QEnYf@nb-20> References: <201111122254.24153.Lance.Corrimal@eregion.de> <1893829.gpzn7QEnYf@nb-20> Message-ID: <201111181839.23778.Lance.Corrimal@eregion.de> sheesh. there are two separate callback registries... of course you have to use the right one. 0.o From jhwelch at gmail.com Fri Nov 18 11:25:55 2011 From: jhwelch at gmail.com (Jonathan Welch) Date: Fri, 18 Nov 2011 14:25:55 -0500 Subject: [opensource-dev] User input solicited picking a number... In-Reply-To: <4EC674AD.9020005@lindenlab.com> References: <4EC66B4D.4040106@lindenlab.com> <4EC674AD.9020005@lindenlab.com> Message-ID: There is also a fade in when you login, but there is an internal delay between when the stream is started and when the audio system starts to present it, so unless the fade time is very long it appears as if there is no fade. Even if it is possible to address this issue with code changes it would have to be handled in a new jira. On Fri, Nov 18, 2011 at 10:07 AM, Oz Linden (Scott Lawrence) wrote: > > On 2011-11-18 9:53, Jonathan Welch wrote: >> >> Any TPV that wants to pick up this new feature before the two debug >> settings are eliminated should do so quickly, or else you will have to >> reimplement them. >> >> Source here: >> https://bitbucket.org/JonathanYap/storm-591b >> > > Actually, since I'll just pull your whole repo when I merge, all they'll > have to do is reverse the commit that removes the variables - it'll be in > the history. > > I would strongly prefer that TPVs not incorporate early versions of features > that we've already said we're incorporating... it only makes life more > difficult for them if problems are found... > > ... speaking of which, I just did a whole bunch of TPing around between > parcels to test the fade times I was playing with, and eventually I stopped > getting any parcel audio at all. I even went back to one I'd been too > earlier that had been playing ok, but I got nothing. I've kept the > associated log file for you if you think it might be useful, Jonathan. > From Lance.Corrimal at eregion.de Fri Nov 18 13:00:17 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Fri, 18 Nov 2011 22:00:17 +0100 Subject: [opensource-dev] User input solicited picking a number... In-Reply-To: <4EC674AD.9020005@lindenlab.com> References: <4EC66B4D.4040106@lindenlab.com> <4EC674AD.9020005@lindenlab.com> Message-ID: <201111182200.18005.Lance.Corrimal@eregion.de> I don't think that fading the audio in and out is going to work for TPVs anyway, the average TPV has the media filter... and people are supposed to actually use it, courtesy to redzone :( bye, LC Am Freitag, 18. November 2011 schrieb Oz Linden (Scott Lawrence): > On 2011-11-18 9:53, Jonathan Welch wrote: > > Any TPV that wants to pick up this new feature before the two > > debug settings are eliminated should do so quickly, or else you > > will have to reimplement them. > > > > Source here: > > https://bitbucket.org/JonathanYap/storm-591b > > Actually, since I'll just pull your whole repo when I merge, all > they'll have to do is reverse the commit that removes the > variables - it'll be in the history. > > I would strongly prefer that TPVs not incorporate early versions of > features that we've already said we're incorporating... it only > makes life more difficult for them if problems are found... > > ... speaking of which, I just did a whole bunch of TPing around > between parcels to test the fade times I was playing with, and > eventually I stopped getting any parcel audio at all. I even went > back to one I'd been too earlier that had been playing ok, but I > got nothing. I've kept the associated log file for you if you > think it might be useful, Jonathan. > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges From Ima.Mechanique at blueyonder.co.uk Fri Nov 18 13:12:49 2011 From: Ima.Mechanique at blueyonder.co.uk (Ima Mechanique) Date: Fri, 18 Nov 2011 21:12:49 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111118140639.26922.10382@domU-12-31-38-00-90-68.compute-1.internal> References: <20111118140639.26922.10382@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111118211249.26923.3830@domU-12-31-38-00-90-68.compute-1.internal> > On Nov. 18, 2011, 6:06 a.m., Lance Corrimal wrote: > > Built it into dolphin 3.2 beta, tested it. found a few issues: > > - main menu option Build/Upload/Script does nothing at all > > - saving a script that you open from your inventory to disk only works after you edit the script > > - saving a script to disk does not add .lsl to the filename by default > > Thanks for the feedback. - The Build => Upload => Script entry shouldn't be there, I'll correct the code. It's a follow up project, which I haven't completed yet. - Saving only works after editing. This is normal behaviour for scripts, I was doubtful of doing it this way, but did so to maintain consistency. If there is a consensus to alter this behaviour I would happily agree to do so. - Hmm, .lsl should be added by default, I'll look into this. - Ima ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1076 ----------------------------------------------------------- On Nov. 17, 2011, 3:08 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2011, 3:08 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changes to allow opened script window to save/load to/from files on the users computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/llviewermenufile.cpp a1319d553db9 > indra/newview/skins/default/xui/en/menu_viewer.xml a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111118/1597c19e/attachment.htm From kelly at lindenlab.com Fri Nov 18 13:19:21 2011 From: kelly at lindenlab.com (Kelly Washington) Date: Fri, 18 Nov 2011 21:19:21 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111118140639.26922.10382@domU-12-31-38-00-90-68.compute-1.internal> References: <20111118140639.26922.10382@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111118211921.27096.84047@domU-12-31-38-00-90-68.compute-1.internal> > On Nov. 18, 2011, 6:06 a.m., Lance Corrimal wrote: > > Built it into dolphin 3.2 beta, tested it. found a few issues: > > - main menu option Build/Upload/Script does nothing at all > > - saving a script that you open from your inventory to disk only works after you edit the script > > - saving a script to disk does not add .lsl to the filename by default > > > > Ima Mechanique wrote: > Thanks for the feedback. > - The Build => Upload => Script entry shouldn't be there, I'll correct the code. It's a follow up project, which I haven't completed yet. > - Saving only works after editing. This is normal behaviour for scripts, I was doubtful of doing it this way, but did so to maintain consistency. If there is a consensus to alter this behaviour I would happily agree to do so. > - Hmm, .lsl should be added by default, I'll look into this. Unless opening the script from file automatically saves (uploads and compiles) the script then it makes more sense for the save button to be enabled as soon as the script is loaded. No need to wait for an edit to enable the save. - Kelly ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1076 ----------------------------------------------------------- On Nov. 17, 2011, 3:08 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2011, 3:08 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changes to allow opened script window to save/load to/from files on the users computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/llviewermenufile.cpp a1319d553db9 > indra/newview/skins/default/xui/en/menu_viewer.xml a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111118/d61cd087/attachment.htm From Ima.Mechanique at blueyonder.co.uk Fri Nov 18 13:21:27 2011 From: Ima.Mechanique at blueyonder.co.uk (Ima Mechanique) Date: Fri, 18 Nov 2011 21:21:27 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111117230834.26924.30320@domU-12-31-38-00-90-68.compute-1.internal> References: <20111117230834.26924.30320@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111118212127.28175.58548@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ ----------------------------------------------------------- (Updated Nov. 18, 2011, 1:21 p.m.) Review request for Viewer. Changes ------- Reverted Build => Upload menu change. Summary ------- Changes to allow opened script window to save/load to/from files on the users computer. This addresses bug https://jira.secondlife.com/browse/storm-1708. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 Diffs (updated) ----- doc/contributions.txt a1319d553db9 indra/newview/llfilepicker.h a1319d553db9 indra/newview/llfilepicker.cpp a1319d553db9 indra/newview/llfloaternamedesc.h a1319d553db9 indra/newview/llfloaternamedesc.cpp a1319d553db9 indra/newview/llpreviewscript.h a1319d553db9 indra/newview/llpreviewscript.cpp a1319d553db9 indra/newview/llviewerfloaterreg.cpp a1319d553db9 indra/newview/llviewermenufile.cpp a1319d553db9 indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 Diff: http://codereview.secondlife.com/r/516/diff Testing ------- Successfully opened and saved scripts from/to local files. Thanks, Ima -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111118/f6bd8b2b/attachment-0001.htm From Ima.Mechanique at blueyonder.co.uk Fri Nov 18 13:36:53 2011 From: Ima.Mechanique at blueyonder.co.uk (Ima Mechanique) Date: Fri, 18 Nov 2011 21:36:53 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111118140639.26922.10382@domU-12-31-38-00-90-68.compute-1.internal> References: <20111118140639.26922.10382@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111118213653.31343.6667@domU-12-31-38-00-90-68.compute-1.internal> > On Nov. 18, 2011, 6:06 a.m., Lance Corrimal wrote: > > Built it into dolphin 3.2 beta, tested it. found a few issues: > > - main menu option Build/Upload/Script does nothing at all > > - saving a script that you open from your inventory to disk only works after you edit the script > > - saving a script to disk does not add .lsl to the filename by default > > > > Ima Mechanique wrote: > Thanks for the feedback. > - The Build => Upload => Script entry shouldn't be there, I'll correct the code. It's a follow up project, which I haven't completed yet. > - Saving only works after editing. This is normal behaviour for scripts, I was doubtful of doing it this way, but did so to maintain consistency. If there is a consensus to alter this behaviour I would happily agree to do so. > - Hmm, .lsl should be added by default, I'll look into this. > > Kelly Washington wrote: > Unless opening the script from file automatically saves (uploads and compiles) the script then it makes more sense for the save button to be enabled as soon as the script is loaded. No need to wait for an edit to enable the save. @Kelly. No it doesn't upload and save, that would be the job for the Build => Upload => Script entry that I'm also working on separately. So far as my own testing, uploading a file into the window does automatically enable the save to inventory button. The saving that Lance mentioned is for saving to disc, which is not automatically enabled, currently, unless the script's state is not clean. - Ima ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1076 ----------------------------------------------------------- On Nov. 18, 2011, 1:21 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2011, 1:21 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changes to allow opened script window to save/load to/from files on the users computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > doc/contributions.txt a1319d553db9 > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/llviewermenufile.cpp a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111118/d0b8a38d/attachment.htm From Ima.Mechanique at blueyonder.co.uk Fri Nov 18 14:55:14 2011 From: Ima.Mechanique at blueyonder.co.uk (Ima Mechanique) Date: Fri, 18 Nov 2011 22:55:14 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111118212127.28175.58548@domU-12-31-38-00-90-68.compute-1.internal> References: <20111118212127.28175.58548@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111118225514.26924.28764@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ ----------------------------------------------------------- (Updated Nov. 18, 2011, 2:55 p.m.) Review request for Viewer. Changes ------- * Removed some code associated with the reverted Build => Upload => Script changes. * Fixed the .lsl extension not being applied correctly. Summary ------- Changes to allow opened script window to save/load to/from files on the users computer. This addresses bug https://jira.secondlife.com/browse/storm-1708. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 Diffs (updated) ----- doc/contributions.txt a1319d553db9 indra/newview/llfilepicker.h a1319d553db9 indra/newview/llfilepicker.cpp a1319d553db9 indra/newview/llfloaternamedesc.h a1319d553db9 indra/newview/llfloaternamedesc.cpp a1319d553db9 indra/newview/llpreviewscript.h a1319d553db9 indra/newview/llpreviewscript.cpp a1319d553db9 indra/newview/llviewerfloaterreg.cpp a1319d553db9 indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 Diff: http://codereview.secondlife.com/r/516/diff Testing ------- Successfully opened and saved scripts from/to local files. Thanks, Ima -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111118/a7915e0a/attachment.htm From Ima.Mechanique at blueyonder.co.uk Fri Nov 18 15:06:47 2011 From: Ima.Mechanique at blueyonder.co.uk (Ima Mechanique) Date: Fri, 18 Nov 2011 23:06:47 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111118225514.26924.28764@domU-12-31-38-00-90-68.compute-1.internal> References: <20111118225514.26924.28764@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111118230647.26919.83154@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ ----------------------------------------------------------- (Updated Nov. 18, 2011, 3:06 p.m.) Review request for Viewer. Changes ------- For those wanting to try the "Save to file.." option without having to edit the file first, this version has that isDirty check commented out. otherwise it is the same as the previous diff. Summary ------- Changes to allow opened script window to save/load to/from files on the users computer. This addresses bug https://jira.secondlife.com/browse/storm-1708. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 Diffs (updated) ----- doc/contributions.txt a1319d553db9 indra/newview/llfilepicker.h a1319d553db9 indra/newview/llfilepicker.cpp a1319d553db9 indra/newview/llfloaternamedesc.h a1319d553db9 indra/newview/llfloaternamedesc.cpp a1319d553db9 indra/newview/llpreviewscript.h a1319d553db9 indra/newview/llpreviewscript.cpp a1319d553db9 indra/newview/llviewerfloaterreg.cpp a1319d553db9 indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 Diff: http://codereview.secondlife.com/r/516/diff Testing ------- Successfully opened and saved scripts from/to local files. Thanks, Ima -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111118/a84f6e3f/attachment.htm From dave at meadowlakearts.com Fri Nov 18 15:58:09 2011 From: dave at meadowlakearts.com (Dave Booth) Date: Fri, 18 Nov 2011 17:58:09 -0600 Subject: [opensource-dev] [viewer-development-builds] Successful Build Nr. 245237 for snowstorm_viewer-development (cfa78777453c) on CYGWIN In-Reply-To: <4EC693E2.4090600@xp2.de> References: <20111116005744.9D062E2CADD@viognier.lindenlab.com> <4EC693E2.4090600@xp2.de> Message-ID: <4EC6F111.4050205@meadowlakearts.com> On 11/18/2011 11:20 AM, Tillie Ariantho wrote: > > That build crashes the nVidia driver pretty often. Right now I can't > even log in with the dev client, crashes the driver right after > clicking Login. Confirmed here too, same driver. Previous workaround does not work, viewer crashes as soon as basic shaders are enabled no matter what point it's done - on my system this is a regression from previous behavior when the GL bug could be avoided by setting gfx prefs to mid or lower for login and setting them back up to desired settings after everything rezzed. Only workaraound for current behavior is a registry tweak: Create or set the following key in HKLM\System\CurrentControlSet\Control\GraphicsDrivers TdrDelay:REG_DWORD set to 60 decimal to allow a 60s graphics driver timeout rather than the 2s default. Note that changing this value from default is considered a serious failure by Microsoft and absolutely precludes an app from gaining windows logo certification if it is required for normal operation. From laurent.bechir at madonie.org Fri Nov 18 18:29:08 2011 From: laurent.bechir at madonie.org (Laurent Bechir) Date: Sat, 19 Nov 2011 03:29:08 +0100 Subject: [opensource-dev] Camera UI in Second Life beta viewer is broken Message-ID: <4EC71474.8010605@madonie.org> Hello, I've opened a Jira about the camera in Second Life beta viewer since it is impossible to take pictures with it. I don't know if this jira has already been submitted, but there is something to do about that : https://jira.secondlife.com/browse/VWR-27652 From cinder at cinderblocks.biz Fri Nov 18 18:55:40 2011 From: cinder at cinderblocks.biz (Cinder Roxley) Date: Fri, 18 Nov 2011 19:55:40 -0700 Subject: [opensource-dev] Camera UI in Second Life beta viewer is broken In-Reply-To: <4EC71474.8010605@madonie.org> References: <4EC71474.8010605@madonie.org> Message-ID: <000001cca666$b9750230$2c5f0690$@biz> Hi, The video linked in the jira doesn't work in my browser. I'm able to take snapshots in all modes using the new snapshot workflow. Kind regards, Cinder Roxley -----Original Message----- From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Laurent Bechir Sent: Friday, November 18, 2011 7:29 PM To: opensource-dev at lists.secondlife.com Subject: [opensource-dev] Camera UI in Second Life beta viewer is broken Hello, I've opened a Jira about the camera in Second Life beta viewer since it is impossible to take pictures with it. I don't know if this jira has already been submitted, but there is something to do about that : https://jira.secondlife.com/browse/VWR-27652 From Lance.Corrimal at eregion.de Sat Nov 19 05:54:04 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Sat, 19 Nov 2011 13:54:04 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111118230647.26919.83154@domU-12-31-38-00-90-68.compute-1.internal> References: <20111118230647.26919.83154@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111119135404.26925.52029@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1081 ----------------------------------------------------------- I've put the last revision (4) in, and it still doesn't add .lsl to filenames on saving... I'm building on linux here, maybe that's the reason? - Lance On Nov. 18, 2011, 3:06 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2011, 3:06 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changes to allow opened script window to save/load to/from files on the users computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > doc/contributions.txt a1319d553db9 > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111119/6332a6b0/attachment.htm From nickyperian at yahoo.com Sat Nov 19 12:26:16 2011 From: nickyperian at yahoo.com (Nicky Perian) Date: Sat, 19 Nov 2011 20:26:16 -0000 Subject: [opensource-dev] Review Request: OPEN-125 Open source mesh upload using hacd. Message-ID: <20111119202616.28175.81323@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/519/ ----------------------------------------------------------- Review request for Viewer and Lance Corrimal. Summary ------- Refer to https://jira.secondlife.com/browse/OPEN-124 for modified library detail. Built viewer-development and TPV kokua under windows 7/64 bit and Debian Squeeze 32 bit linux with modified HACD. Logged to aditi, local opensim host and osgrid. Uploaded a several mesh models without problem. This addresses bug https://jira.secondlife.com/browse/OPEN-125. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/OPEN-125 Diffs ----- autobuild.xml 36e901f3531c indra/cmake/CMakeLists.txt 36e901f3531c indra/cmake/FindHACD.cmake PRE-CREATION indra/cmake/HACD.cmake PRE-CREATION indra/cmake/LLConvexDecomposition.cmake 36e901f3531c indra/cmake/ViewerMiscLibs.cmake 36e901f3531c indra/newview/CMakeLists.txt 36e901f3531c indra/newview/llmeshrepository.cpp 36e901f3531c Diff: http://codereview.secondlife.com/r/519/diff Testing ------- Logged to aditi, local opensim host and osgrid. Uploaded a several mesh models without problem. Thanks, Nicky -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111119/8a0e436b/attachment.htm From laurent.bechir at madonie.org Sat Nov 19 18:59:19 2011 From: laurent.bechir at madonie.org (Laurent Bechir) Date: Sun, 20 Nov 2011 03:59:19 +0100 Subject: [opensource-dev] Camera UI in Second Life beta viewer is broken In-Reply-To: <000001cca666$b9750230$2c5f0690$@biz> References: <4EC71474.8010605@madonie.org> <000001cca666$b9750230$2c5f0690$@biz> Message-ID: <4EC86D07.8000806@madonie.org> It seems my answer has not arrived. I send a new link to show what happens when I try to take pictures. The version of the viewer is 3.2.2 (244666) Nov 8 2011 17:17:35 : http://youtu.be/93JYlOwYjY0 the Jira is here : https://jira.secondlife.com/browse/VWR-27652 > Cinder Roxley > 19 novembre 2011 03:55 > Hi, > > The video linked in the jira doesn't work in my browser. I'm able to take > snapshots in all modes using the new snapshot workflow. > > Kind regards, > Cinder Roxley > > -----Original Message----- > From: opensource-dev-bounces at lists.secondlife.com > [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Laurent > Bechir > Sent: Friday, November 18, 2011 7:29 PM > To: opensource-dev at lists.secondlife.com > Subject: [opensource-dev] Camera UI in Second Life beta viewer is broken > > > Hello, > > I've opened a Jira about the camera in Second Life beta viewer since it > is impossible to take pictures with it. I don't know if this jira has > already been submitted, but there is something to do about that : > > https://jira.secondlife.com/browse/VWR-27652 > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > Laurent Bechir > 19 novembre 2011 03:29 > Hello, > > I've opened a Jira about the camera in Second Life beta viewer since it > is impossible to take pictures with it. I don't know if this jira has > already been submitted, but there is something to do about that : > > https://jira.secondlife.com/browse/VWR-27652 > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/c413fc46/attachment.htm -------------- next part -------------- A non-text attachment was scrubbed... Name: postbox-contact.jpg Type: image/jpeg Size: 1206 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/c413fc46/attachment.jpg -------------- next part -------------- A non-text attachment was scrubbed... Name: postbox-contact.jpg Type: image/jpeg Size: 1273 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/c413fc46/attachment-0001.jpg From laurent.bechir at madonie.org Sat Nov 19 18:59:54 2011 From: laurent.bechir at madonie.org (Laurent Bechir) Date: Sun, 20 Nov 2011 03:59:54 +0100 Subject: [opensource-dev] Camera UI in Second Life beta viewer is broken In-Reply-To: <4EC86D07.8000806@madonie.org> References: <4EC71474.8010605@madonie.org> <000001cca666$b9750230$2c5f0690$@biz> <4EC86D07.8000806@madonie.org> Message-ID: <4EC86D2A.4030209@madonie.org> It seems my answer has not arrived. I send a new link to show what happens when I try to take pictures. The version of the viewer is 3.2.2 (244666) Nov 8 2011 17:17:35 : http://youtu.be/93JYlOwYjY0 the Jira is here : https://jira.secondlife.com/browse/VWR-27652 > Cinder Roxley > 19 novembre 2011 03:55 > Hi, > > The video linked in the jira doesn't work in my browser. I'm able to take > snapshots in all modes using the new snapshot workflow. > > Kind regards, > Cinder Roxley > > -----Original Message----- > From: opensource-dev-bounces at lists.secondlife.com > [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Laurent > Bechir > Sent: Friday, November 18, 2011 7:29 PM > To: opensource-dev at lists.secondlife.com > Subject: [opensource-dev] Camera UI in Second Life beta viewer is broken > > > Hello, > > I've opened a Jira about the camera in Second Life beta viewer since it > is impossible to take pictures with it. I don't know if this jira has > already been submitted, but there is something to do about that : > > https://jira.secondlife.com/browse/VWR-27652 > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > Laurent Bechir > 19 novembre 2011 03:29 > Hello, > > I've opened a Jira about the camera in Second Life beta viewer since it > is impossible to take pictures with it. I don't know if this jira has > already been submitted, but there is something to do about that : > > https://jira.secondlife.com/browse/VWR-27652 > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/d171f83a/attachment-0001.htm -------------- next part -------------- A non-text attachment was scrubbed... Name: postbox-contact.jpg Type: image/jpeg Size: 1206 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/d171f83a/attachment-0002.jpg -------------- next part -------------- A non-text attachment was scrubbed... Name: postbox-contact.jpg Type: image/jpeg Size: 1273 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/d171f83a/attachment-0003.jpg From cinder at cinderblocks.biz Sat Nov 19 19:09:29 2011 From: cinder at cinderblocks.biz (Cinder Roxley) Date: Sat, 19 Nov 2011 20:09:29 -0700 Subject: [opensource-dev] Camera UI in Second Life beta viewer is broken In-Reply-To: <4EC86D2A.4030209@madonie.org> References: <4EC71474.8010605@madonie.org> <000001cca666$b9750230$2c5f0690$@biz> <4EC86D07.8000806@madonie.org> <4EC86D2A.4030209@madonie.org> Message-ID: <000c01cca731$d24fc120$76ef4360$@biz> Hi, There's a little Refresh button (the itty bitty arrow that makes a circle.) You need to click that to refresh the picture, which will then make the Save button clickable again. Probably not ideal, but it works. In previous viewers, you needed to refresh the snapshot the same way anytime a setting was changed. Kind regards, Cinder Roxley From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Laurent Bechir Sent: Saturday, November 19, 2011 8:00 PM To: opensource-dev at lists.secondlife.com Subject: Re: [opensource-dev] Camera UI in Second Life beta viewer is broken It seems my answer has not arrived. I send a new link to show what happens when I try to take pictures. The version of the viewer is 3.2.2 (244666) Nov 8 2011 17:17:35 : http://youtu.be/93JYlOwYjY0 the Jira is here : https://jira.secondlife.com/browse/VWR-27652 Cinder Roxley 19 novembre 2011 03:55 Hi, The video linked in the jira doesn't work in my browser. I'm able to take snapshots in all modes using the new snapshot workflow. Kind regards, Cinder Roxley Laurent Bechir 19 novembre 2011 03:29 Hello, I've opened a Jira about the camera in Second Life beta viewer since it is impossible to take pictures with it. I don't know if this jira has already been submitted, but there is something to do about that : https://jira.secondlife.com/browse/VWR-27652 _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111119/5e058165/attachment.htm -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/jpeg Size: 1206 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111119/5e058165/attachment.jpeg -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/jpeg Size: 1273 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111119/5e058165/attachment-0001.jpeg From cinciasingh at gmail.com Sat Nov 19 19:26:02 2011 From: cinciasingh at gmail.com (Cincia Singh) Date: Sat, 19 Nov 2011 21:26:02 -0600 Subject: [opensource-dev] Is the build machine stuck? Message-ID: I have seen it saying "in progress" for 2 days now. Is it not finishing? Both Snowstorm and the shining fixes web page for the OpenGL builds. -- *?We can't solve problems by using the same kind of thinking we used when we created them.? Albert Einstein* -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111119/f881acbd/attachment.htm From laurent.bechir at madonie.org Sat Nov 19 19:26:44 2011 From: laurent.bechir at madonie.org (Laurent Bechir) Date: Sun, 20 Nov 2011 04:26:44 +0100 Subject: [opensource-dev] Camera UI in Second Life beta viewer is broken In-Reply-To: <000c01cca731$d24fc120$76ef4360$@biz> References: <4EC71474.8010605@madonie.org> <000001cca666$b9750230$2c5f0690$@biz> <4EC86D07.8000806@madonie.org> <4EC86D2A.4030209@madonie.org> <000c01cca731$d24fc120$76ef4360$@biz> Message-ID: <4EC87374.8000502@madonie.org> I did the refresh. The problem is not there. The problem is that when I click on a button (Save, Cancel, or another) the viewer react like if I was clicking behind it. For example, if the background of the picture window is the ground, clicking on a button is going to make move my avatar instead of the action the button is supposed to do. The is a turnaround for such buttons as Save to my inventory which consist on clicking on the part which is above the sidebar. But since Save and Cancel buttons are not above this part, they are unusable. I hope I'm more clear :) https://skitch.com/laurentr2d2/gkybs/second-life https://skitch.com/laurentr2d2/gkyb4/second-life > Cinder Roxley > 20 novembre 2011 04:09 > > Hi, > > There's a little Refresh button (the itty bitty arrow that makes a > circle.) You need to click that to refresh the picture, > > which will then make the Save button clickable again. Probably not > ideal, but it works. In previous viewers, you needed > > to refresh the snapshot the same way anytime a setting was changed. > > Kind regards, > > Cinder Roxley > > *From:*opensource-dev-bounces at lists.secondlife.com > [mailto:opensource-dev-bounces at lists.secondlife.com] *On Behalf Of > *Laurent Bechir > *Sent:* Saturday, November 19, 2011 8:00 PM > *To:* opensource-dev at lists.secondlife.com > *Subject:* Re: [opensource-dev] Camera UI in Second Life beta viewer > is broken > > > It seems my answer has not arrived. I send a new link to show what > happens when I try to take pictures. The version of the viewer is > 3.2.2 (244666) Nov 8 2011 17:17:35 : > > http://youtu.be/93JYlOwYjY0 > > the Jira is here : > > https://jira.secondlife.com/browse/VWR-27652 > > *Cinder Roxley* > > 19 novembre 2011 03:55 > > Hi, > > The video linked in the jira doesn't work in my browser. I'm able to take > snapshots in all modes using the new snapshot workflow. > > Kind regards, > Cinder Roxley > > *Laurent Bechir* > > 19 novembre 2011 03:29 > > Hello, > > I've opened a Jira about the camera in Second Life beta viewer since it > is impossible to take pictures with it. I don't know if this jira has > already been submitted, but there is something to do about that : > > https://jira.secondlife.com/browse/VWR-27652 > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > Laurent Bechir > 20 novembre 2011 03:59 > > It seems my answer has not arrived. I send a new link to show what > happens when I try to take pictures. The version of the viewer is > 3.2.2 (244666) Nov 8 2011 17:17:35 : > > http://youtu.be/93JYlOwYjY0 > > the Jira is here : > > https://jira.secondlife.com/browse/VWR-27652 > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > Laurent Bechir > 20 novembre 2011 03:59 > > It seems my answer has not arrived. I send a new link to show what > happens when I try to take pictures. The version of the viewer is > 3.2.2 (244666) Nov 8 2011 17:17:35 : > > http://youtu.be/93JYlOwYjY0 > > the Jira is here : > > https://jira.secondlife.com/browse/VWR-27652 > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > Cinder Roxley > 19 novembre 2011 03:55 > Hi, > > The video linked in the jira doesn't work in my browser. I'm able to take > snapshots in all modes using the new snapshot workflow. > > Kind regards, > Cinder Roxley > > -----Original Message----- > From: opensource-dev-bounces at lists.secondlife.com > [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Laurent > Bechir > Sent: Friday, November 18, 2011 7:29 PM > To: opensource-dev at lists.secondlife.com > Subject: [opensource-dev] Camera UI in Second Life beta viewer is broken > > > Hello, > > I've opened a Jira about the camera in Second Life beta viewer since it > is impossible to take pictures with it. I don't know if this jira has > already been submitted, but there is something to do about that : > > https://jira.secondlife.com/browse/VWR-27652 > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > Laurent Bechir > 19 novembre 2011 03:29 > Hello, > > I've opened a Jira about the camera in Second Life beta viewer since it > is impossible to take pictures with it. I don't know if this jira has > already been submitted, but there is something to do about that : > > https://jira.secondlife.com/browse/VWR-27652 > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/aa916bfb/attachment-0001.htm -------------- next part -------------- A non-text attachment was scrubbed... Name: postbox-contact.jpg Type: image/jpeg Size: 1206 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/aa916bfb/attachment-0004.jpg -------------- next part -------------- A non-text attachment was scrubbed... Name: image.jpg Type: image/jpeg Size: 1209 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/aa916bfb/attachment-0005.jpg -------------- next part -------------- A non-text attachment was scrubbed... Name: image.jpg Type: image/jpeg Size: 1272 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/aa916bfb/attachment-0006.jpg -------------- next part -------------- A non-text attachment was scrubbed... Name: postbox-contact.jpg Type: image/jpeg Size: 1273 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/aa916bfb/attachment-0007.jpg From wolfpup67 at earthlink.net Sat Nov 19 19:36:46 2011 From: wolfpup67 at earthlink.net (WolfPup Lowenhar) Date: Sat, 19 Nov 2011 22:36:46 -0500 Subject: [opensource-dev] Camera UI in Second Life beta viewer is broken In-Reply-To: <4EC87374.8000502@madonie.org> References: <4EC71474.8010605@madonie.org> <000001cca666$b9750230$2c5f0690$@biz> <4EC86D07.8000806@madonie.org> <4EC86D2A.4030209@madonie.org> <000c01cca731$d24fc120$76ef4360$@biz> <4EC87374.8000502@madonie.org> Message-ID: <002701cca735$a1998580$e4cc9080$@net> Ok from what you have said it sound like click to move is active in the preferences. As a work around in the preferences floater under move set single click on land to no action and double click on land to what eve you want it to do. Now this would be a 'workarond. And not a true fix for the underlying issue of some elements of the UI not taking presidence. From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Laurent Bechir Sent: Saturday, November 19, 2011 10:27 PM To: opensource-dev at lists.secondlife.com Subject: Re: [opensource-dev] Camera UI in Second Life beta viewer is broken I did the refresh. The problem is not there. The problem is that when I click on a button (Save, Cancel, or another) the viewer react like if I was clicking behind it. For example, if the background of the picture window is the ground, clicking on a button is going to make move my avatar instead of the action the button is supposed to do. The is a turnaround for such buttons as Save to my inventory which consist on clicking on the part which is above the sidebar. But since Save and Cancel buttons are not above this part, they are unusable. I hope I'm more clear :) https://skitch.com/laurentr2d2/gkybs/second-life https://skitch.com/laurentr2d2/gkyb4/second-life Cinder Roxley 20 novembre 2011 04:09 Hi, There's a little Refresh button (the itty bitty arrow that makes a circle.) You need to click that to refresh the picture, which will then make the Save button clickable again. Probably not ideal, but it works. In previous viewers, you needed to refresh the snapshot the same way anytime a setting was changed. Kind regards, Cinder Roxley From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Laurent Bechir Sent: Saturday, November 19, 2011 8:00 PM To: opensource-dev at lists.secondlife.com Subject: Re: [opensource-dev] Camera UI in Second Life beta viewer is broken It seems my answer has not arrived. I send a new link to show what happens when I try to take pictures. The version of the viewer is 3.2.2 (244666) Nov 8 2011 17:17:35 : http://youtu.be/93JYlOwYjY0 the Jira is here : https://jira.secondlife.com/browse/VWR-27652 Cinder Roxley 19 novembre 2011 03:55 Hi, The video linked in the jira doesn't work in my browser. I'm able to take snapshots in all modes using the new snapshot workflow. Kind regards, Cinder Roxley Laurent Bechir 19 novembre 2011 03:29 Hello, I've opened a Jira about the camera in Second Life beta viewer since it is impossible to take pictures with it. I don't know if this jira has already been submitted, but there is something to do about that : https://jira.secondlife.com/browse/VWR-27652 _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges Laurent Bechir 20 novembre 2011 03:59 It seems my answer has not arrived. I send a new link to show what happens when I try to take pictures. The version of the viewer is 3.2.2 (244666) Nov 8 2011 17:17:35 : http://youtu.be/93JYlOwYjY0 the Jira is here : https://jira.secondlife.com/browse/VWR-27652 _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges Laurent Bechir 20 novembre 2011 03:59 It seems my answer has not arrived. I send a new link to show what happens when I try to take pictures. The version of the viewer is 3.2.2 (244666) Nov 8 2011 17:17:35 : http://youtu.be/93JYlOwYjY0 the Jira is here : https://jira.secondlife.com/browse/VWR-27652 _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges Cinder Roxley 19 novembre 2011 03:55 Hi, The video linked in the jira doesn't work in my browser. I'm able to take snapshots in all modes using the new snapshot workflow. Kind regards, Cinder Roxley -----Original Message----- From: opensource-dev-bounces at lists.secondlife.com [mailto:opensource-dev-bounces at lists.secondlife.com] On Behalf Of Laurent Bechir Sent: Friday, November 18, 2011 7:29 PM To: opensource-dev at lists.secondlife.com Subject: [opensource-dev] Camera UI in Second Life beta viewer is broken Hello, I've opened a Jira about the camera in Second Life beta viewer since it is impossible to take pictures with it. I don't know if this jira has already been submitted, but there is something to do about that : https://jira.secondlife.com/browse/VWR-27652 _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges Laurent Bechir 19 novembre 2011 03:29 Hello, I've opened a Jira about the camera in Second Life beta viewer since it is impossible to take pictures with it. I don't know if this jira has already been submitted, but there is something to do about that : https://jira.secondlife.com/browse/VWR-27652 _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges _____ No virus found in this message. Checked by AVG - www.avg.com Version: 2012.0.1872 / Virus Database: 2092/4626 - Release Date: 11/19/11 -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111119/0f5d33ba/attachment-0001.htm -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/jpeg Size: 1206 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111119/0f5d33ba/attachment-0004.jpeg -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/jpeg Size: 1209 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111119/0f5d33ba/attachment-0005.jpeg -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/jpeg Size: 1272 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111119/0f5d33ba/attachment-0006.jpeg -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/jpeg Size: 1273 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111119/0f5d33ba/attachment-0007.jpeg From laurent.bechir at madonie.org Sat Nov 19 19:50:21 2011 From: laurent.bechir at madonie.org (Laurent Bechir) Date: Sun, 20 Nov 2011 04:50:21 +0100 Subject: [opensource-dev] Camera UI in Second Life beta viewer is broken In-Reply-To: <002701cca735$a1998580$e4cc9080$@net> References: <4EC71474.8010605@madonie.org> <000001cca666$b9750230$2c5f0690$@biz> <4EC86D07.8000806@madonie.org> <4EC86D2A.4030209@madonie.org> <000c01cca731$d24fc120$76ef4360$@biz> <4EC87374.8000502@madonie.org> <002701cca735$a1998580$e4cc9080$@net> Message-ID: <4EC878FD.4040603@madonie.org> It doesn't change the problem. In fact, the ground was just taken as example. The result is the same if I take a picture with the sky as background. The only reactive part of the window is the black left side. > WolfPup Lowenhar > 20 novembre 2011 04:36 > > Ok from what you have said it sound like click to move is active in > the preferences. As a work around in the preferences floater under > move set single click on land to no action and double click on land to > what eve you want it to do. Now this would be a 'workarond. And not a > true fix for the underlying issue of some elements of the UI not > taking presidence. > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > Laurent Bechir > 20 novembre 2011 04:26 > > I did the refresh. The problem is not there. The problem is that when > I click on a button (Save, Cancel, or another) the viewer react like > if I was clicking behind it. For example, if the background of the > picture window is the ground, clicking on a button is going to make > move my avatar instead of the action the button is supposed to do. The > is a turnaround for such buttons as Save to my inventory which consist > on clicking on the part which is above the sidebar. But since Save and > Cancel buttons are not above this part, they are unusable. I hope I'm > more clear :) > > https://skitch.com/laurentr2d2/gkybs/second-life > > https://skitch.com/laurentr2d2/gkyb4/second-life > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > Cinder Roxley > 20 novembre 2011 04:09 > > Hi, > > There's a little Refresh button (the itty bitty arrow that makes a > circle.) You need to click that to refresh the picture, > > which will then make the Save button clickable again. Probably not > ideal, but it works. In previous viewers, you needed > > to refresh the snapshot the same way anytime a setting was changed. > > Kind regards, > > Cinder Roxley > > *From:*opensource-dev-bounces at lists.secondlife.com > [mailto:opensource-dev-bounces at lists.secondlife.com] *On Behalf Of > *Laurent Bechir > *Sent:* Saturday, November 19, 2011 8:00 PM > *To:* opensource-dev at lists.secondlife.com > *Subject:* Re: [opensource-dev] Camera UI in Second Life beta viewer > is broken > > > It seems my answer has not arrived. I send a new link to show what > happens when I try to take pictures. The version of the viewer is > 3.2.2 (244666) Nov 8 2011 17:17:35 : > > http://youtu.be/93JYlOwYjY0 > > the Jira is here : > > https://jira.secondlife.com/browse/VWR-27652 > > *Cinder Roxley* > > 19 novembre 2011 03:55 > > Hi, > > The video linked in the jira doesn't work in my browser. I'm able to take > snapshots in all modes using the new snapshot workflow. > > Kind regards, > Cinder Roxley > > *Laurent Bechir* > > 19 novembre 2011 03:29 > > Hello, > > I've opened a Jira about the camera in Second Life beta viewer since it > is impossible to take pictures with it. I don't know if this jira has > already been submitted, but there is something to do about that : > > https://jira.secondlife.com/browse/VWR-27652 > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > Laurent Bechir > 20 novembre 2011 03:59 > > It seems my answer has not arrived. I send a new link to show what > happens when I try to take pictures. The version of the viewer is > 3.2.2 (244666) Nov 8 2011 17:17:35 : > > http://youtu.be/93JYlOwYjY0 > > the Jira is here : > > https://jira.secondlife.com/browse/VWR-27652 > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > Laurent Bechir > 20 novembre 2011 03:59 > > It seems my answer has not arrived. I send a new link to show what > happens when I try to take pictures. The version of the viewer is > 3.2.2 (244666) Nov 8 2011 17:17:35 : > > http://youtu.be/93JYlOwYjY0 > > the Jira is here : > > https://jira.secondlife.com/browse/VWR-27652 > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/8e051e2d/attachment-0001.htm -------------- next part -------------- A non-text attachment was scrubbed... Name: compose-unknown-contact.jpg Type: image/jpeg Size: 770 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/8e051e2d/attachment-0005.jpg -------------- next part -------------- A non-text attachment was scrubbed... Name: postbox-contact.jpg Type: image/jpeg Size: 1273 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/8e051e2d/attachment-0006.jpg -------------- next part -------------- A non-text attachment was scrubbed... Name: postbox-contact.jpg Type: image/jpeg Size: 1206 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/8e051e2d/attachment-0007.jpg -------------- next part -------------- A non-text attachment was scrubbed... Name: image.jpg Type: image/jpeg Size: 1209 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/8e051e2d/attachment-0008.jpg -------------- next part -------------- A non-text attachment was scrubbed... Name: image.jpg Type: image/jpeg Size: 1272 bytes Desc: not available Url : http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/8e051e2d/attachment-0009.jpg From lists.secondlife.com at trap.wereanimal.net Sat Nov 19 20:48:05 2011 From: lists.secondlife.com at trap.wereanimal.net (lists.secondlife.com at trap.wereanimal.net) Date: Sat, 19 Nov 2011 23:48:05 -0500 Subject: [opensource-dev] LLSingleton class question. Message-ID: <20111119234805.396e2df0@laptop> Hi all. In the LLSingleton header, there is a comment: // Reference version of getInstance() // Preferred over getInstance() as it disallows checking for NULL My question is, is there a difference between MyClass::instance()->someFunction(); and MyClass::getInstance()->someFunction(); ? If not, is there a preference of using one over the other? Linden Lab viewer code has about 35% ::instance use vs. 65% ::getInstance use. -- Techwolf Lupindo From tateru.nino at gmail.com Sat Nov 19 21:43:32 2011 From: tateru.nino at gmail.com (Tateru Nino) Date: Sun, 20 Nov 2011 16:43:32 +1100 Subject: [opensource-dev] Camera UI in Second Life beta viewer is broken In-Reply-To: <4EC87374.8000502@madonie.org> References: <4EC71474.8010605@madonie.org> <000001cca666$b9750230$2c5f0690$@biz> <4EC86D07.8000806@madonie.org> <4EC86D2A.4030209@madonie.org> <000c01cca731$d24fc120$76ef4360$@biz> <4EC87374.8000502@madonie.org> Message-ID: <4EC89384.4080402@gmail.com> On 20/11/2011 2:26 PM, Laurent Bechir wrote: > > I did the refresh. The problem is not there. The problem is that when > I click on a button (Save, Cancel, or another) the viewer react like > if I was clicking behind it. For example, if the background of the > picture window is the ground, clicking on a button is going to make > move my avatar instead of the action the button is supposed to do. The > is a turnaround for such buttons as Save to my inventory which consist > on clicking on the part which is above the sidebar. But since Save and > Cancel buttons are not above this part, they are unusable. I hope I'm > more clear :) > Ahhh, I've seen this problem before! On a number of occasions, in fact. It first started manifesting in the UI code in ... I think it was viewer 1.9 (or perhaps the release before it). It's come and gone on several, but never really been _fixed_ because nobody seems to quite ever figure out what causes it. It also was associated with tooltips being triggered from floaters below the topmost floater. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/ebbd29cf/attachment.htm From hitomi.tiponi at yahoo.co.uk Sat Nov 19 22:41:31 2011 From: hitomi.tiponi at yahoo.co.uk (Hitomi Tiponi) Date: Sun, 20 Nov 2011 06:41:31 +0000 (GMT) Subject: [opensource-dev] Is the build machine stuck? In-Reply-To: References: Message-ID: <1321771291.60962.YahooMailNeo@web23908.mail.ird.yahoo.com> It does appear to be stuck still - it's not the first time this has happened.? Also the problem with not showing changes in the builds has still not been solved when it does complete. ------------------------------------------------------------------------------- Date: Sat, 19 Nov 2011 21:26:02 -0600 From: Cincia Singh Subject: [opensource-dev] Is the build machine stuck? To: opensource-dev at lists.secondlife.com Message-ID: ??? Content-Type: text/plain; charset="windows-1252" I have seen it saying "in progress" for 2 days now. Is it not finishing? Both Snowstorm and the shining fixes web page for the OpenGL builds. --------------------------------------------------- -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/aa5f7ac3/attachment.htm From dave at meadowlakearts.com Sat Nov 19 22:55:32 2011 From: dave at meadowlakearts.com (Dave Booth) Date: Sun, 20 Nov 2011 00:55:32 -0600 Subject: [opensource-dev] Is the build machine stuck? In-Reply-To: <1321771291.60962.YahooMailNeo@web23908.mail.ird.yahoo.com> References: <1321771291.60962.YahooMailNeo@web23908.mail.ird.yahoo.com> Message-ID: <4EC8A464.9050505@meadowlakearts.com> On 11/20/2011 12:41 AM, Hitomi Tiponi wrote: > It does appear to be stuck still - it's not the first time this has > happened. Also the problem with not showing changes in the builds has > still not been solved when it does complete. > Ricky found the issue with the latter of those.. posted it here > Turns out that the reason why it isn't displaying > changesets or JIRA entries is because the JSON format was changed > without correcting the Javascript. What's more, the JSON information > doesn't have the needed data anymore. He even mocked up a fix... From Lance.Corrimal at eregion.de Sun Nov 20 06:53:33 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Sun, 20 Nov 2011 14:53:33 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111118230647.26919.83154@domU-12-31-38-00-90-68.compute-1.internal> References: <20111118230647.26919.83154@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1082 ----------------------------------------------------------- found another glitch: I'm developing scripts in eclipse with lslforge. When I "compile" a script in eclipse and then load it using this patch, tabstops are converted into IDunnoWhat (it shows as little squares in the script editor). - Lance On Nov. 18, 2011, 3:06 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2011, 3:06 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changes to allow opened script window to save/load to/from files on the users computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > doc/contributions.txt a1319d553db9 > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/44c60420/attachment.htm From Ima.Mechanique at blueyonder.co.uk Sun Nov 20 10:25:49 2011 From: Ima.Mechanique at blueyonder.co.uk (Ima Mechanique) Date: Sun, 20 Nov 2011 18:25:49 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111119135404.26925.52029@domU-12-31-38-00-90-68.compute-1.internal> References: <20111119135404.26925.52029@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111120182549.24387.12608@domU-12-31-38-00-90-68.compute-1.internal> > On Nov. 19, 2011, 5:54 a.m., Lance Corrimal wrote: > > I've put the last revision (4) in, and it still doesn't add .lsl to filenames on saving... I'm building on linux here, maybe that's the reason? This is mostly a Window's feature, at this time. The .lsl filter is part of a Window's only code path, there exists a Darwin code-path too, but I haven't done any work in that yet (no Mac to develop with). As far as I can see, there is no Linux specific code-path for the dialogues, so I'm not sure what can be done there. - Ima ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1081 ----------------------------------------------------------- On Nov. 18, 2011, 3:06 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2011, 3:06 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changes to allow opened script window to save/load to/from files on the users computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > doc/contributions.txt a1319d553db9 > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/8ab55d10/attachment-0001.htm From Ima.Mechanique at blueyonder.co.uk Sun Nov 20 10:26:44 2011 From: Ima.Mechanique at blueyonder.co.uk (Ima Mechanique) Date: Sun, 20 Nov 2011 18:26:44 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111119135404.26925.52029@domU-12-31-38-00-90-68.compute-1.internal> References: <20111119135404.26925.52029@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111120182644.24391.21078@domU-12-31-38-00-90-68.compute-1.internal> > On Nov. 19, 2011, 5:54 a.m., Lance Corrimal wrote: > > I've put the last revision (4) in, and it still doesn't add .lsl to filenames on saving... I'm building on linux here, maybe that's the reason? > > Ima Mechanique wrote: > This is mostly a Window's feature, at this time. The .lsl filter is part of a Window's only code path, there exists a Darwin code-path too, but I haven't done any work in that yet (no Mac to develop with). As far as I can see, there is no Linux specific code-path for the dialogues, so I'm not sure what can be done there. Incidentally, I'd be interested to know how a Linux build handles exporting images. Does it add the suffix automatically? - Ima ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1081 ----------------------------------------------------------- On Nov. 18, 2011, 3:06 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2011, 3:06 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changes to allow opened script window to save/load to/from files on the users computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > doc/contributions.txt a1319d553db9 > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/b74062c7/attachment.htm From Ima.Mechanique at blueyonder.co.uk Sun Nov 20 10:29:09 2011 From: Ima.Mechanique at blueyonder.co.uk (Ima Mechanique) Date: Sun, 20 Nov 2011 18:29:09 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> References: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111120182909.25302.33425@domU-12-31-38-00-90-68.compute-1.internal> > On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script in eclipse and then load it using this patch, tabstops are converted into IDunnoWhat (it shows as little squares in the script editor). > > I'm not familiar with lslforge, but I'll look into it. Are you sure they're valid tabs? I ask because it handles tabs from LSL Editor without a problem. - Ima ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1082 ----------------------------------------------------------- On Nov. 18, 2011, 3:06 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2011, 3:06 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changes to allow opened script window to save/load to/from files on the users computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > doc/contributions.txt a1319d553db9 > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/d732ff7a/attachment.htm From Ima.Mechanique at blueyonder.co.uk Sun Nov 20 11:50:17 2011 From: Ima.Mechanique at blueyonder.co.uk (Ima Mechanique) Date: Sun, 20 Nov 2011 19:50:17 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> References: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111120195017.24391.16025@domU-12-31-38-00-90-68.compute-1.internal> > On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script in eclipse and then load it using this patch, tabstops are converted into IDunnoWhat (it shows as little squares in the script editor). > > > > Ima Mechanique wrote: > I'm not familiar with lslforge, but I'll look into it. Are you sure they're valid tabs? I ask because it handles tabs from LSL Editor without a problem. Looks like this is a bug I've introduced recently, as it is also affecting my LSL Editor created files now. :-( Trying to track it down, as soon as I can work out how to go back to a specific revision in Hg. - Ima ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1082 ----------------------------------------------------------- On Nov. 18, 2011, 3:06 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2011, 3:06 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changes to allow opened script window to save/load to/from files on the users computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > doc/contributions.txt a1319d553db9 > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/131e4b19/attachment.htm From nexiim at gmail.com Sun Nov 20 13:33:03 2011 From: nexiim at gmail.com (Nexii Malthus) Date: Sun, 20 Nov 2011 21:33:03 +0000 Subject: [opensource-dev] Camera UI in Second Life beta viewer is broken In-Reply-To: <4EC89384.4080402@gmail.com> References: <4EC71474.8010605@madonie.org> <000001cca666$b9750230$2c5f0690$@biz> <4EC86D07.8000806@madonie.org> <4EC86D2A.4030209@madonie.org> <000c01cca731$d24fc120$76ef4360$@biz> <4EC87374.8000502@madonie.org> <4EC89384.4080402@gmail.com> Message-ID: That happens because the clicks work by going down a hierarchy, it goes down the window backgrounds first, then works through the children UI elements of that window, passing around the click message until it hits the lowest level. When you click outside the windows it passes through to the 3D world. Even if visually there is a button. The problem being that the window *must* cover all the child elements properly. - Nexii On Sun, Nov 20, 2011 at 5:43 AM, Tateru Nino wrote: > > > On 20/11/2011 2:26 PM, Laurent Bechir wrote: > > > I did the refresh. The problem is not there. The problem is that when I > click on a button (Save, Cancel, or another) the viewer react like if I was > clicking behind it. For example, if the background of the picture window is > the ground, clicking on a button is going to make move my avatar instead of > the action the button is supposed to do. The is a turnaround for such > buttons as Save to my inventory which consist on clicking on the part which > is above the sidebar. But since Save and Cancel buttons are not above this > part, they are unusable. I hope I'm more clear :) > > Ahhh, I've seen this problem before! On a number of occasions, in fact. > > It first started manifesting in the UI code in ... I think it was viewer > 1.9 (or perhaps the release before it). It's come and gone on several, but > never really been _fixed_ because nobody seems to quite ever figure out > what causes it. It also was associated with tooltips being triggered from > floaters below the topmost floater. > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/dc2b9c7e/attachment.htm From Ima.Mechanique at blueyonder.co.uk Sun Nov 20 13:48:43 2011 From: Ima.Mechanique at blueyonder.co.uk (Ima Mechanique) Date: Sun, 20 Nov 2011 21:48:43 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> References: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111120214843.24392.908@domU-12-31-38-00-90-68.compute-1.internal> > On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script in eclipse and then load it using this patch, tabstops are converted into IDunnoWhat (it shows as little squares in the script editor). > > > > Ima Mechanique wrote: > I'm not familiar with lslforge, but I'll look into it. Are you sure they're valid tabs? I ask because it handles tabs from LSL Editor without a problem. > > Ima Mechanique wrote: > Looks like this is a bug I've introduced recently, as it is also affecting my LSL Editor created files now. :-( > Trying to track it down, as soon as I can work out how to go back to a specific revision in Hg. Damn. SL's text editing windows do not like tabs. When copy/pasting the tabs are converted to spaces, but not when inserting text. I'll look at finding a way around this. - Ima ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1082 ----------------------------------------------------------- On Nov. 18, 2011, 3:06 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2011, 3:06 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changes to allow opened script window to save/load to/from files on the users computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > doc/contributions.txt a1319d553db9 > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111120/26b062c8/attachment.htm From tateru.nino at gmail.com Sun Nov 20 15:28:35 2011 From: tateru.nino at gmail.com (Tateru Nino) Date: Mon, 21 Nov 2011 10:28:35 +1100 Subject: [opensource-dev] Camera UI in Second Life beta viewer is broken In-Reply-To: References: <4EC71474.8010605@madonie.org> <000001cca666$b9750230$2c5f0690$@biz> <4EC86D07.8000806@madonie.org> <4EC86D2A.4030209@madonie.org> <000c01cca731$d24fc120$76ef4360$@biz> <4EC87374.8000502@madonie.org> <4EC89384.4080402@gmail.com> Message-ID: <4EC98D23.6070407@gmail.com> The essential bug is that the elements *are* completely covered when this occurs, but when the mouse-position is matched to an on-screen element, it ends up matching the wrong thing in the stack. Sometimes. Under conditions which seem obscure and difficult to reproduce. And it may match pointing (for tooltips) differently to clicking (for UI widgets). On 21/11/2011 8:33 AM, Nexii Malthus wrote: > That happens because the clicks work by going down a hierarchy, it > goes down the window backgrounds first, then works through the > children UI elements of that window, passing around the click message > until it hits the lowest level. > > When you click outside the windows it passes through to the 3D world. > Even if visually there is a button. > > The problem being that the window *must* cover all the child elements > properly. > > - Nexii > > On Sun, Nov 20, 2011 at 5:43 AM, Tateru Nino > wrote: > > > > On 20/11/2011 2:26 PM, Laurent Bechir wrote: >> >> I did the refresh. The problem is not there. The problem is that >> when I click on a button (Save, Cancel, or another) the viewer >> react like if I was clicking behind it. For example, if the >> background of the picture window is the ground, clicking on a >> button is going to make move my avatar instead of the action the >> button is supposed to do. The is a turnaround for such buttons as >> Save to my inventory which consist on clicking on the part which >> is above the sidebar. But since Save and Cancel buttons are not >> above this part, they are unusable. I hope I'm more clear :) >> > Ahhh, I've seen this problem before! On a number of occasions, in > fact. > > It first started manifesting in the UI code in ... I think it was > viewer 1.9 (or perhaps the release before it). It's come and gone > on several, but never really been _fixed_ because nobody seems to > quite ever figure out what causes it. It also was associated with > tooltips being triggered from floaters below the topmost floater. > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated > posting privileges > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111121/108e74ba/attachment.htm From kf6kjg at gmail.com Sun Nov 20 21:10:55 2011 From: kf6kjg at gmail.com (Ricky) Date: Sun, 20 Nov 2011 21:10:55 -0800 Subject: [opensource-dev] Is the build machine stuck? In-Reply-To: <4EC8A464.9050505@meadowlakearts.com> References: <1321771291.60962.YahooMailNeo@web23908.mail.ird.yahoo.com> <4EC8A464.9050505@meadowlakearts.com> Message-ID: Yep. Haven't heard any response about it though. Ricky Cron Stardust On Sat, Nov 19, 2011 at 10:55 PM, Dave Booth wrote: > On 11/20/2011 12:41 AM, Hitomi Tiponi wrote: >> It does appear to be stuck still - it's not the first time this has >> happened. Also the problem with not showing changes in the builds has >> still not been solved when it does complete. >> > > Ricky found the issue with the latter of those.. posted it here > >> ?Turns out that the reason why it isn't displaying >> changesets or JIRA entries is because the JSON format was changed >> without correcting the Javascript. ?What's more, the JSON information >> doesn't have the needed data anymore. > > He even mocked up a fix... > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges > From jhwelch at gmail.com Mon Nov 21 06:21:46 2011 From: jhwelch at gmail.com (Jonathan Welch) Date: Mon, 21 Nov 2011 09:21:46 -0500 Subject: [opensource-dev] Spammy isFeatureAvailable message in secondlife.log file Message-ID: I've been getting this spammy message in my secondlife.log file for viewers I have been compiling from tip recently (not sure how long ago it started): WARNING: LLFeatureList::isFeatureAvailable: ONCE (164400th time seen): Feature VertexShaderEnable not on feature list! Does anyone have a clue how I can fix/stop this? Thank you, -Jonathan From oz at lindenlab.com Mon Nov 21 08:26:21 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Mon, 21 Nov 2011 11:26:21 -0500 Subject: [opensource-dev] User input solicited picking a number... In-Reply-To: <4EC66B4D.4040106@lindenlab.com> References: <4EC66B4D.4040106@lindenlab.com> Message-ID: <4ECA7BAD.9090605@lindenlab.com> On 2011-11-18 9:27, Oz Linden (Scott Lawrence) wrote: > > The current test implementation has a pair of debug variables for > controlling the fade time: AudioMusicFadeIn and AudioMusicFadeOut are > the number of seconds that each fade takes. In the test version > above, these default to 5 seconds. I've been experimenting a bit with this, and I rather like 3 in and 2 out... -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111121/7e7f06b1/attachment.htm From cg at miaow.com Mon Nov 21 16:53:16 2011 From: cg at miaow.com (Christian Goetze) Date: Mon, 21 Nov 2011 16:53:16 -0800 Subject: [opensource-dev] Is the build machine stuck? In-Reply-To: References: <1321771291.60962.YahooMailNeo@web23908.mail.ird.yahoo.com> <4EC8A464.9050505@meadowlakearts.com> Message-ID: The most likely reason why the build shows as "in progress" is because there is a disparity between the state of the build scripts or other local dependencies on the mac vs windows vs linux build machines. If the dependencies differ, then a different build number will be generated, and since that is what the build system is tracking, it will wait forever for all three platforms to complete a build with the same build number. Someone needs to ensure that all build machines have the same version of all the build support repos sync'ed. This needs to be fixed if only to ensure that all viewer builds have the same version number. As for the "changes since last build", the data indeed went missing - I believe you might be able to get the changeset ids to display at least, but it won't be very helpful because it will be missing the info about which hg repo actually holds those ids. -- cg On Sun, Nov 20, 2011 at 9:10 PM, Ricky wrote: > Yep. ?Haven't heard any response about it though. > > Ricky > Cron Stardust > > On Sat, Nov 19, 2011 at 10:55 PM, Dave Booth wrote: >> On 11/20/2011 12:41 AM, Hitomi Tiponi wrote: >>> It does appear to be stuck still - it's not the first time this has >>> happened. Also the problem with not showing changes in the builds has >>> still not been solved when it does complete. >>> >> >> Ricky found the issue with the latter of those.. posted it here >> >>> ?Turns out that the reason why it isn't displaying >>> changesets or JIRA entries is because the JSON format was changed >>> without correcting the Javascript. ?What's more, the JSON information >>> doesn't have the needed data anymore. >> >> He even mocked up a fix... >> _______________________________________________ >> Policies and (un)subscribe information available here: >> http://wiki.secondlife.com/wiki/OpenSource-Dev >> Please read the policies before posting to keep unmoderated posting privileges >> > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges > From cg at miaow.com Mon Nov 21 16:55:25 2011 From: cg at miaow.com (Christian Goetze) Date: Mon, 21 Nov 2011 16:55:25 -0800 Subject: [opensource-dev] VD Build Page Hacking In-Reply-To: References: Message-ID: Nice, but it will fail for changesets referring to 3p repos and build script changes, but I suppose that's still better than nothing. It would be nice if the query to retrieve the expected info could be restored server side, but... -- cg On Sun, Nov 13, 2011 at 12:46 AM, Ricky wrote: > I finally got so annoyed with the build page that I decided to do some > hacking on it. ?Turns out that the reason why it isn't displaying > changesets or JIRA entries is because the JSON format was changed > without correcting the Javascript. ?What's more, the JSON information > doesn't have the needed data anymore. > > So. ?I dug and I hacked, and I hacked and I dug, and voila, I'd mashed > up a facsimile of what I think it did in the past. ?And yes, I used > the phrase "mashed up" on purpose: the page I built taps into > BitBucket's REST API to get the missing data. ?It's not all that > pretty to go that route, but it works. > > Here's a demonstration: http://rwcproductions.com/~ricky/snowstorm/ > And here's the patch: > http://rwcproductions.com/~ricky/snowstorm/index.js.patch.txt > > Yes, there are some whitespace changes, and render_description() could > be cleaned up further, but I tried to not affect more than the areas > needed to make it "workable." > > Suggestions, thoughts, etc. welcome. > > Ricky > Cron Stardust > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges > From kf6kjg at gmail.com Mon Nov 21 17:27:18 2011 From: kf6kjg at gmail.com (Ricky) Date: Mon, 21 Nov 2011 17:27:18 -0800 Subject: [opensource-dev] Changes Since Last Build problem Message-ID: Yes, I noticed that some changeset id's weren't found in the V-D repository, so I had the script just display what it could for those. For reference here's the demo link: http://rwcproductions.com/~ricky/snowstorm/ It'd be better to find out why the data changed, and if was possible to get it all back, but if not then adding the repository url... Hmmm... Looks like a lot of those have the changeset URL. I could parse that for what is needed to go get the rest of the data... But that's more hacks on top of hacks just to overcome a lack of data from the original source. So some questions that'd be nice to have answered: Where else is that JSON being used? Why was it changed? Could the wanted data be added to it and not freak out whatever else is using it? If the JSON has the data needed I could scrape up some time to build a non-hacky fix. Ricky Cron Stardust On Mon, Nov 21, 2011 at 4:53 PM, Christian Goetze wrote: > The most likely reason why ?the build shows as "in progress" is > because there is a disparity between the state of the build scripts > or other local dependencies on the mac vs windows vs linux build > machines. If the dependencies differ, then a different build number > will be generated, and since that is what the build system is > tracking, it will wait forever for all three platforms to complete a > build with the same build number. > > Someone needs to ensure that all build machines have the same version > of all the build support repos sync'ed. This needs to be fixed if only > to ensure that all viewer builds have the same version number. > > As for the "changes since last build", the data indeed went missing - > I believe you might be able to get the changeset ids to display at > least, but it won't be very helpful because it will be missing the > info about which hg repo actually holds those ids. > -- > cg > > On Sun, Nov 20, 2011 at 9:10 PM, Ricky wrote: >> Yep. ?Haven't heard any response about it though. >> >> Ricky >> Cron Stardust >> >> On Sat, Nov 19, 2011 at 10:55 PM, Dave Booth wrote: >>> On 11/20/2011 12:41 AM, Hitomi Tiponi wrote: >>>> It does appear to be stuck still - it's not the first time this has >>>> happened. Also the problem with not showing changes in the builds has >>>> still not been solved when it does complete. >>>> >>> >>> Ricky found the issue with the latter of those.. posted it here >>> >>>> ?Turns out that the reason why it isn't displaying >>>> changesets or JIRA entries is because the JSON format was changed >>>> without correcting the Javascript. ?What's more, the JSON information >>>> doesn't have the needed data anymore. >>> >>> He even mocked up a fix... >>> _______________________________________________ >>> Policies and (un)subscribe information available here: >>> http://wiki.secondlife.com/wiki/OpenSource-Dev >>> Please read the policies before posting to keep unmoderated posting privileges >>> >> _______________________________________________ >> Policies and (un)subscribe information available here: >> http://wiki.secondlife.com/wiki/OpenSource-Dev >> Please read the policies before posting to keep unmoderated posting privileges >> > From kf6kjg at gmail.com Mon Nov 21 17:51:25 2011 From: kf6kjg at gmail.com (Ricky) Date: Mon, 21 Nov 2011 17:51:25 -0800 Subject: [opensource-dev] VD Build Page Hacking In-Reply-To: References: Message-ID: LOL, didn't see this response before I posted the other. Like I said there, if the needed/wanted data could be added to the new data structure I'd be willing to scrape up some time to fix the page to use it. Having the data listed in http://confluence.atlassian.com/display/BITBUCKET/Changesets for each changeset would be a good list to go for. These could be appended to the objects in the changesets array in the JSON, and would provide everything needed - that I know of. Ricky Cron Stardust On Mon, Nov 21, 2011 at 4:55 PM, Christian Goetze wrote: > Nice, but it will fail for changesets referring to 3p repos and build > script changes, but I suppose that's still better than nothing. It > would be nice if the query to retrieve the expected info could be > restored server side, but... > -- > cg > > On Sun, Nov 13, 2011 at 12:46 AM, Ricky wrote: >> I finally got so annoyed with the build page that I decided to do some >> hacking on it. ?Turns out that the reason why it isn't displaying >> changesets or JIRA entries is because the JSON format was changed >> without correcting the Javascript. ?What's more, the JSON information >> doesn't have the needed data anymore. >> >> So. ?I dug and I hacked, and I hacked and I dug, and voila, I'd mashed >> up a facsimile of what I think it did in the past. ?And yes, I used >> the phrase "mashed up" on purpose: the page I built taps into >> BitBucket's REST API to get the missing data. ?It's not all that >> pretty to go that route, but it works. >> >> Here's a demonstration: http://rwcproductions.com/~ricky/snowstorm/ >> And here's the patch: >> http://rwcproductions.com/~ricky/snowstorm/index.js.patch.txt >> >> Yes, there are some whitespace changes, and render_description() could >> be cleaned up further, but I tried to not affect more than the areas >> needed to make it "workable." >> >> Suggestions, thoughts, etc. welcome. >> >> Ricky >> Cron Stardust >> _______________________________________________ >> Policies and (un)subscribe information available here: >> http://wiki.secondlife.com/wiki/OpenSource-Dev >> Please read the policies before posting to keep unmoderated posting privileges >> > From dave at meadowlakearts.com Mon Nov 21 19:09:32 2011 From: dave at meadowlakearts.com (Dave Booth) Date: Mon, 21 Nov 2011 21:09:32 -0600 Subject: [opensource-dev] [viewer-development-builds] Successful Build Nr. 245237 for snowstorm_viewer-development (cfa78777453c) on CYGWIN In-Reply-To: <4EC6F111.4050205@meadowlakearts.com> References: <20111116005744.9D062E2CADD@viognier.lindenlab.com> <4EC693E2.4090600@xp2.de> <4EC6F111.4050205@meadowlakearts.com> Message-ID: <4ECB126C.9040007@meadowlakearts.com> On 11/18/2011 5:58 PM, Dave Booth wrote: > On 11/18/2011 11:20 AM, Tillie Ariantho wrote: >> >> That build crashes the nVidia driver pretty often. Right now I can't >> even log in with the dev client, crashes the driver right after >> clicking Login. > > Confirmed here too, same driver. Previous workaround does not work, > viewer crashes as soon as basic shaders are enabled no matter what point > it's done - on my system this is a regression from previous behavior > when the GL bug could be avoided by setting gfx prefs to mid or lower > for login and setting them back up to desired settings after everything > rezzed. Only workaraound for current behavior is a registry tweak: 245610 is even worse.. even the registry hack doesnt work. As soon as you enable basic shaders you're looking at a hard crash. Guys, this isnt progress, this is progressively worse regressions. We need to get the shining fixes into the trunk ASAP - it's progressing from an inconvenience to a showstopper real fast. I hope the GL fixes in shining solve this. From Ima.Mechanique at blueyonder.co.uk Tue Nov 22 17:17:10 2011 From: Ima.Mechanique at blueyonder.co.uk (Ima Mechanique) Date: Wed, 23 Nov 2011 01:17:10 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111118230647.26919.83154@domU-12-31-38-00-90-68.compute-1.internal> References: <20111118230647.26919.83154@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111123011710.24390.87222@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ ----------------------------------------------------------- (Updated Nov. 22, 2011, 5:17 p.m.) Review request for Viewer. Changes ------- This should complete the Windows functionality. Tabs are now dealt with (replaced with spaces) as per standard behaviour for the script editor. I'm starting work on adding the UI changes for Linux/Mac next. Summary ------- Changes to allow opened script window to save/load to/from files on the users computer. This addresses bug https://jira.secondlife.com/browse/storm-1708. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 Diffs (updated) ----- doc/contributions.txt a1319d553db9 indra/llui/lltexteditor.h a1319d553db9 indra/llui/lltexteditor.cpp a1319d553db9 indra/newview/llfilepicker.h a1319d553db9 indra/newview/llfilepicker.cpp a1319d553db9 indra/newview/llfloaternamedesc.h a1319d553db9 indra/newview/llfloaternamedesc.cpp a1319d553db9 indra/newview/llpreviewscript.h a1319d553db9 indra/newview/llpreviewscript.cpp a1319d553db9 indra/newview/llviewerfloaterreg.cpp a1319d553db9 indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 Diff: http://codereview.secondlife.com/r/516/diff Testing ------- Successfully opened and saved scripts from/to local files. Thanks, Ima -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/985f2017/attachment.htm From oz at lindenlab.com Wed Nov 23 05:55:54 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Wed, 23 Nov 2011 08:55:54 -0500 Subject: [opensource-dev] Changes Since Last Build problem In-Reply-To: References: Message-ID: <4ECCFB6A.4050805@lindenlab.com> On 2011-11-21 20:27, Ricky wrote: > So some questions that'd be nice to have answered: Where else is that > JSON being used? Why was it changed? Could the wanted data be added > to it and not freak out whatever else is using it? If the JSON has > the data needed I could scrape up some time to build a non-hacky fix. The underlying problem was a performance issue - some codeticket queries were timing out and causing builds to fail. The current situation is a workaround that looses some (important) features but keeps the build machinery turning. A proper fix is being considered, but I don't know how soon we'll have it. From jhwelch at gmail.com Wed Nov 23 05:59:29 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Wed, 23 Nov 2011 13:59:29 -0000 Subject: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased Message-ID: <20111123135929.26657.21835@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/520/ ----------------------------------------------------------- Review request for Viewer. Summary ------- Audio fading in has been added for when a music stream starts. Audio fading out has been added for when there is a change in the music stream that is playing. Two dead files have been eliminated. An existing bug in how music was not being paused correctly has been fixed. When you are teleporting you will hear the music stream from the place you are leaving. This is a change in behavior; previously the music stream was stopped when the teleport progress bar was being displayed. This code change affects several areas where music is started or stopped. The new code has evolved significantly, so please look for things that might not "make sense." This addresses bug STORM-591. http://jira.secondlife.com/browse/STORM-591 Diffs ----- doc/contributions.txt 8b455c1b7a5e indra/newview/lloverlaybar.h 8b455c1b7a5e indra/newview/lloverlaybar.cpp 8b455c1b7a5e indra/newview/llpanelnearbymedia.h 8b455c1b7a5e indra/newview/llpanelnearbymedia.cpp 8b455c1b7a5e indra/newview/llvieweraudio.h 8b455c1b7a5e indra/newview/llvieweraudio.cpp 8b455c1b7a5e indra/newview/llviewermedia.cpp 8b455c1b7a5e indra/newview/llviewerparcelmgr.cpp 8b455c1b7a5e Diff: http://codereview.secondlife.com/r/520/diff Testing ------- See the massive test plan in the jira. Thanks, Jonathan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/3a1a9486/attachment.htm From jhwelch at gmail.com Wed Nov 23 06:57:33 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Wed, 23 Nov 2011 14:57:33 -0000 Subject: [opensource-dev] Review Request: STORM-1653 Group notices sent by muted residents are still displayed In-Reply-To: <20111026180958.28710.13743@domU-12-31-38-00-90-68.compute-1.internal> References: <20111026180958.28710.13743@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111123145733.26657.48668@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/508/ ----------------------------------------------------------- (Updated Nov. 23, 2011, 6:57 a.m.) Review request for Viewer. Changes ------- Added a bit of code to handle the case of last name being "Resident". Summary ------- When I mute a resident, group notices from that resident are still being displayed to me. This addresses bug STORM-1653. http://jira.secondlife.com/browse/STORM-1653 Diffs (updated) ----- doc/contributions.txt c42575f2cde8 indra/newview/llviewermessage.cpp c42575f2cde8 Diff: http://codereview.secondlife.com/r/508/diff Testing ------- See test plan in jira. Even with an empty name cache I still get an AgentID back. It is not clear to me if I might not when there is a cache miss and the backend systems servicing the name to ID request are heavily loaded. Thanks, Jonathan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/d9b95239/attachment.htm From oz at lindenlab.com Wed Nov 23 07:23:17 2011 From: oz at lindenlab.com (Oz Linden) Date: Wed, 23 Nov 2011 15:23:17 -0000 Subject: [opensource-dev] Review Request: STORM-1653 Group notices sent by muted residents are still displayed In-Reply-To: <20111123145733.26657.48668@domU-12-31-38-00-90-68.compute-1.internal> References: <20111123145733.26657.48668@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111123152317.26660.44718@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/508/#review1089 ----------------------------------------------------------- indra/newview/llviewermessage.cpp I suggest adding the name you were trying to look up to this log message: "buildLegacyName(" << legacy_name << ") did not find an agent_id" - Oz On Nov. 23, 2011, 6:57 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/508/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2011, 6:57 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > When I mute a resident, group notices from that resident are still being displayed to me. > > > This addresses bug STORM-1653. > http://jira.secondlife.com/browse/STORM-1653 > > > Diffs > ----- > > doc/contributions.txt c42575f2cde8 > indra/newview/llviewermessage.cpp c42575f2cde8 > > Diff: http://codereview.secondlife.com/r/508/diff > > > Testing > ------- > > See test plan in jira. > > Even with an empty name cache I still get an AgentID back. It is not clear to me if I might not when there is a cache miss and the backend systems servicing the name to ID request are heavily loaded. > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/f97df4a1/attachment-0001.htm From oz at lindenlab.com Wed Nov 23 07:32:11 2011 From: oz at lindenlab.com (Oz Linden) Date: Wed, 23 Nov 2011 15:32:11 -0000 Subject: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased In-Reply-To: <20111123135929.26657.21835@domU-12-31-38-00-90-68.compute-1.internal> References: <20111123135929.26657.21835@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111123153211.26661.89016@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/520/#review1088 ----------------------------------------------------------- A couple of minor suggestions, but generally very clear and clean code. Kudos for good use of the singleton pattern. indra/newview/llpanelnearbymedia.cpp Please fix (and in the else below) to match the coding standard; add the braces. https://wiki.secondlife.com/wiki/Coding_Standard#Braces indra/newview/llvieweraudio.cpp I think this would be clearer if it were written as a switch statement without the early returns. indra/newview/llvieweraudio.cpp If you add an 'else' here, you can replace all the early returns in this method with assignments to a 'bool fadeIsFinished = false;' variable and return that at the bottom. - Oz On Nov. 23, 2011, 5:59 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/520/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2011, 5:59 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Audio fading in has been added for when a music stream starts. Audio fading out has been added for when there is a change in the music stream that is playing. > > Two dead files have been eliminated. > > An existing bug in how music was not being paused correctly has been fixed. > > When you are teleporting you will hear the music stream from the place you are leaving. This is a change in behavior; previously the music stream was stopped when the teleport progress bar was being displayed. > > This code change affects several areas where music is started or stopped. The new code has evolved significantly, so please look for things that might not "make sense." > > > This addresses bug STORM-591. > http://jira.secondlife.com/browse/STORM-591 > > > Diffs > ----- > > doc/contributions.txt 8b455c1b7a5e > indra/newview/lloverlaybar.h 8b455c1b7a5e > indra/newview/lloverlaybar.cpp 8b455c1b7a5e > indra/newview/llpanelnearbymedia.h 8b455c1b7a5e > indra/newview/llpanelnearbymedia.cpp 8b455c1b7a5e > indra/newview/llvieweraudio.h 8b455c1b7a5e > indra/newview/llvieweraudio.cpp 8b455c1b7a5e > indra/newview/llviewermedia.cpp 8b455c1b7a5e > indra/newview/llviewerparcelmgr.cpp 8b455c1b7a5e > > Diff: http://codereview.secondlife.com/r/520/diff > > > Testing > ------- > > See the massive test plan in the jira. > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/24310fde/attachment-0001.htm From jhwelch at gmail.com Wed Nov 23 08:05:38 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Wed, 23 Nov 2011 16:05:38 -0000 Subject: [opensource-dev] Review Request: STORM-1653 Group notices sent by muted residents are still displayed In-Reply-To: <20111123145733.26657.48668@domU-12-31-38-00-90-68.compute-1.internal> References: <20111123145733.26657.48668@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111123160538.26660.75261@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/508/ ----------------------------------------------------------- (Updated Nov. 23, 2011, 8:05 a.m.) Review request for Viewer. Changes ------- Added more information to a LL_WARNS line per RB request. Summary ------- When I mute a resident, group notices from that resident are still being displayed to me. This addresses bug STORM-1653. http://jira.secondlife.com/browse/STORM-1653 Diffs (updated) ----- doc/contributions.txt c42575f2cde8 indra/newview/llviewermessage.cpp c42575f2cde8 Diff: http://codereview.secondlife.com/r/508/diff Testing ------- See test plan in jira. Even with an empty name cache I still get an AgentID back. It is not clear to me if I might not when there is a cache miss and the backend systems servicing the name to ID request are heavily loaded. Thanks, Jonathan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/01bed47b/attachment.htm From richard at lindenlab.com Wed Nov 23 08:18:52 2011 From: richard at lindenlab.com (Richard Nelson) Date: Wed, 23 Nov 2011 16:18:52 -0000 Subject: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased In-Reply-To: <20111123135929.26657.21835@domU-12-31-38-00-90-68.compute-1.internal> References: <20111123135929.26657.21835@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111123161852.26663.93125@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/520/#review1090 ----------------------------------------------------------- Quick comment regarding behavior...we really should not play any audio during the teleport blackout as it is disconcerting to feel like you are still in an area (hearing the audio) but not be able to see or interact with anything. Everything else sounds great. - Richard On Nov. 23, 2011, 5:59 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/520/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2011, 5:59 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Audio fading in has been added for when a music stream starts. Audio fading out has been added for when there is a change in the music stream that is playing. > > Two dead files have been eliminated. > > An existing bug in how music was not being paused correctly has been fixed. > > When you are teleporting you will hear the music stream from the place you are leaving. This is a change in behavior; previously the music stream was stopped when the teleport progress bar was being displayed. > > This code change affects several areas where music is started or stopped. The new code has evolved significantly, so please look for things that might not "make sense." > > > This addresses bug STORM-591. > http://jira.secondlife.com/browse/STORM-591 > > > Diffs > ----- > > doc/contributions.txt 8b455c1b7a5e > indra/newview/lloverlaybar.h 8b455c1b7a5e > indra/newview/lloverlaybar.cpp 8b455c1b7a5e > indra/newview/llpanelnearbymedia.h 8b455c1b7a5e > indra/newview/llpanelnearbymedia.cpp 8b455c1b7a5e > indra/newview/llvieweraudio.h 8b455c1b7a5e > indra/newview/llvieweraudio.cpp 8b455c1b7a5e > indra/newview/llviewermedia.cpp 8b455c1b7a5e > indra/newview/llviewerparcelmgr.cpp 8b455c1b7a5e > > Diff: http://codereview.secondlife.com/r/520/diff > > > Testing > ------- > > See the massive test plan in the jira. > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/c67fa7a8/attachment.htm From jhwelch at gmail.com Wed Nov 23 08:41:39 2011 From: jhwelch at gmail.com (Jonathan Yap) Date: Wed, 23 Nov 2011 16:41:39 -0000 Subject: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased In-Reply-To: <20111123161852.26663.93125@domU-12-31-38-00-90-68.compute-1.internal> References: <20111123161852.26663.93125@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111123164139.25558.59750@domU-12-31-38-00-90-68.compute-1.internal> > On Nov. 23, 2011, 8:18 a.m., Richard Nelson wrote: > > Quick comment regarding behavior...we really should not play any audio during the teleport blackout as it is disconcerting to feel like you are still in an area (hearing the audio) but not be able to see or interact with anything. Everything else sounds great. The reason I changed the behavior when the teleport progress bar was showing was to keep the state engine logic simple -- it activates when there is change in your current parcel music URL. Otherwise you have to deal with various cases as exceptions to how the state engine processes stream transitions. If you force-fade the current stream when the teleport progress bar appears and the teleport fails you'll have to fade the stream back in. I am not sure if there are other edge cases that might appear. I suggest trying Oz's PO test viewer (there is a download link in a jira comment). Personally I felt having the music keep playing and then fade out and in when you arrive was more enjoyable (you can consider it in-flight entertainment). This also might tie in well with any improvements to the progress bar screen no longer being a blank page as was discussed in one of Oz's user group meetings. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/520/#review1090 ----------------------------------------------------------- On Nov. 23, 2011, 5:59 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/520/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2011, 5:59 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Audio fading in has been added for when a music stream starts. Audio fading out has been added for when there is a change in the music stream that is playing. > > Two dead files have been eliminated. > > An existing bug in how music was not being paused correctly has been fixed. > > When you are teleporting you will hear the music stream from the place you are leaving. This is a change in behavior; previously the music stream was stopped when the teleport progress bar was being displayed. > > This code change affects several areas where music is started or stopped. The new code has evolved significantly, so please look for things that might not "make sense." > > > This addresses bug STORM-591. > http://jira.secondlife.com/browse/STORM-591 > > > Diffs > ----- > > doc/contributions.txt 8b455c1b7a5e > indra/newview/lloverlaybar.h 8b455c1b7a5e > indra/newview/lloverlaybar.cpp 8b455c1b7a5e > indra/newview/llpanelnearbymedia.h 8b455c1b7a5e > indra/newview/llpanelnearbymedia.cpp 8b455c1b7a5e > indra/newview/llvieweraudio.h 8b455c1b7a5e > indra/newview/llvieweraudio.cpp 8b455c1b7a5e > indra/newview/llviewermedia.cpp 8b455c1b7a5e > indra/newview/llviewerparcelmgr.cpp 8b455c1b7a5e > > Diff: http://codereview.secondlife.com/r/520/diff > > > Testing > ------- > > See the massive test plan in the jira. > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/33140d7e/attachment.htm From oz at lindenlab.com Wed Nov 23 09:32:53 2011 From: oz at lindenlab.com (Oz Linden) Date: Wed, 23 Nov 2011 17:32:53 -0000 Subject: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased In-Reply-To: <20111123161852.26663.93125@domU-12-31-38-00-90-68.compute-1.internal> References: <20111123161852.26663.93125@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111123173253.24388.7055@domU-12-31-38-00-90-68.compute-1.internal> > On Nov. 23, 2011, 8:18 a.m., Richard Nelson wrote: > > Quick comment regarding behavior...we really should not play any audio during the teleport blackout as it is disconcerting to feel like you are still in an area (hearing the audio) but not be able to see or interact with anything. Everything else sounds great. > > Jonathan Yap wrote: > The reason I changed the behavior when the teleport progress bar was showing was to keep the state engine logic simple -- it activates when there is change in your current parcel music URL. > > Otherwise you have to deal with various cases as exceptions to how the state engine processes stream transitions. > > If you force-fade the current stream when the teleport progress bar appears and the teleport fails you'll have to fade the stream back in. I am not sure if there are other edge cases that might appear. > > I suggest trying Oz's PO test viewer (there is a download link in a jira comment). Personally I felt having the music keep playing and then fade out and in when you arrive was more enjoyable (you can consider it in-flight entertainment). This also might tie in well with any improvements to the progress bar screen no longer being a blank page as was discussed in one of Oz's user group meetings. > On the other hand, testing in the current Development viewer [Second Life 3.2.4 (245662)], when I started from a parcel with a stream and TP'ed to a new region&parcel without one, I got a sudden cutoff when the TP screen came up but the stream restarted when the screen dropped and then cut off quickly (presumably because new parcel properties had arrived). That's arguably not as good as a fade after teleport. - Oz ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/520/#review1090 ----------------------------------------------------------- On Nov. 23, 2011, 5:59 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/520/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2011, 5:59 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Audio fading in has been added for when a music stream starts. Audio fading out has been added for when there is a change in the music stream that is playing. > > Two dead files have been eliminated. > > An existing bug in how music was not being paused correctly has been fixed. > > When you are teleporting you will hear the music stream from the place you are leaving. This is a change in behavior; previously the music stream was stopped when the teleport progress bar was being displayed. > > This code change affects several areas where music is started or stopped. The new code has evolved significantly, so please look for things that might not "make sense." > > > This addresses bug STORM-591. > http://jira.secondlife.com/browse/STORM-591 > > > Diffs > ----- > > doc/contributions.txt 8b455c1b7a5e > indra/newview/lloverlaybar.h 8b455c1b7a5e > indra/newview/lloverlaybar.cpp 8b455c1b7a5e > indra/newview/llpanelnearbymedia.h 8b455c1b7a5e > indra/newview/llpanelnearbymedia.cpp 8b455c1b7a5e > indra/newview/llvieweraudio.h 8b455c1b7a5e > indra/newview/llvieweraudio.cpp 8b455c1b7a5e > indra/newview/llviewermedia.cpp 8b455c1b7a5e > indra/newview/llviewerparcelmgr.cpp 8b455c1b7a5e > > Diff: http://codereview.secondlife.com/r/520/diff > > > Testing > ------- > > See the massive test plan in the jira. > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/de789817/attachment-0001.htm From kadah.coba at gmail.com Wed Nov 23 10:36:38 2011 From: kadah.coba at gmail.com (Kadah Coba) Date: Wed, 23 Nov 2011 18:36:38 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> References: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111123183638.25300.27555@domU-12-31-38-00-90-68.compute-1.internal> > On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script in eclipse and then load it using this patch, tabstops are converted into IDunnoWhat (it shows as little squares in the script editor). > > > > Ima Mechanique wrote: > I'm not familiar with lslforge, but I'll look into it. Are you sure they're valid tabs? I ask because it handles tabs from LSL Editor without a problem. > > Ima Mechanique wrote: > Looks like this is a bug I've introduced recently, as it is also affecting my LSL Editor created files now. :-( > Trying to track it down, as soon as I can work out how to go back to a specific revision in Hg. > > Ima Mechanique wrote: > Damn. SL's text editing windows do not like tabs. When copy/pasting the tabs are converted to spaces, but not when inserting text. I'll look at finding a way around this. I don't remember any in-viewer text input ever liking \t particulary. It might be best, or at least easier or safer, to just convert them to spaces on import. - Kadah ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1082 ----------------------------------------------------------- On Nov. 22, 2011, 5:17 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2011, 5:17 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changes to allow opened script window to save/load to/from files on the users computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > doc/contributions.txt a1319d553db9 > indra/llui/lltexteditor.h a1319d553db9 > indra/llui/lltexteditor.cpp a1319d553db9 > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/639536f3/attachment.htm From moriz.gupte at gmail.com Wed Nov 23 10:58:42 2011 From: moriz.gupte at gmail.com (Moriz Gupte) Date: Wed, 23 Nov 2011 11:58:42 -0700 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111123183638.25300.27555@domU-12-31-38-00-90-68.compute-1.internal> References: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> <20111123183638.25300.27555@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: found another glitch: I'm developing scripts in eclipse with lslforge. When I "compile" a script in eclipse and then load it using this patch, tabstops are converted into IDunnoWhat (it shows as little squares in the script editor). This behavior is familiar to me as well. I use LSL Editor, the script displays fine when read in the LSL Editor but within SL, I find that the script file shows little squares. I imagine it must be an issue related to incompatible fonts used, may be? On Wed, Nov 23, 2011 at 11:36 AM, Kadah Coba wrote: > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > > On November 20th, 2011, 6:53 a.m., *Lance Corrimal* wrote: > > found another glitch: > I'm developing scripts in eclipse with lslforge. When I "compile" a script in eclipse and then load it using this patch, tabstops are converted into IDunnoWhat (it shows as little squares in the script editor). > > On November 20th, 2011, 10:29 a.m., *Ima Mechanique* wrote: > > I'm not familiar with lslforge, but I'll look into it. Are you sure they're valid tabs? I ask because it handles tabs from LSL Editor without a problem. > > On November 20th, 2011, 11:50 a.m., *Ima Mechanique* wrote: > > Looks like this is a bug I've introduced recently, as it is also affecting my LSL Editor created files now. :-( > Trying to track it down, as soon as I can work out how to go back to a specific revision in Hg. > > On November 20th, 2011, 1:48 p.m., *Ima Mechanique* wrote: > > Damn. SL's text editing windows do not like tabs. When copy/pasting the tabs are converted to spaces, but not when inserting text. I'll look at finding a way around this. > > I don't remember any in-viewer text input ever liking \t particulary. It might be best, or at least easier or safer, to just convert them to spaces on import. > > > - Kadah > > On November 22nd, 2011, 5:17 p.m., Ima Mechanique wrote: > Review request for Viewer. > By Ima Mechanique. > > *Updated Nov. 22, 2011, 5:17 p.m.* > Description > > Changes to allow opened script window to save/load to/from files on the users computer. > > Testing > > Successfully opened and saved scripts from/to local files. > > *Bugs: * https://jira.secondlife.com/browse/storm-1708 > Diffs > > - doc/contributions.txt (a1319d553db9) > - indra/llui/lltexteditor.h (a1319d553db9) > - indra/llui/lltexteditor.cpp (a1319d553db9) > - indra/newview/llfilepicker.h (a1319d553db9) > - indra/newview/llfilepicker.cpp (a1319d553db9) > - indra/newview/llfloaternamedesc.h (a1319d553db9) > - indra/newview/llfloaternamedesc.cpp (a1319d553db9) > - indra/newview/llpreviewscript.h (a1319d553db9) > - indra/newview/llpreviewscript.cpp (a1319d553db9) > - indra/newview/llviewerfloaterreg.cpp (a1319d553db9) > - indra/newview/skins/default/xui/en/panel_script_ed.xml (a1319d553db9) > > View Diff > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -- 'Consider how the lilies grow. They do not labor or spin.' *Rameshsharma Ramloll* PhD, *Research Associate Professor*, Idaho State University, Pocatello, ID 83209 Tel: 208-282-5333 Blog , LinkedIn , Play2Train -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/f701c7aa/attachment.htm From Lance.Corrimal at eregion.de Wed Nov 23 11:33:46 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Wed, 23 Nov 2011 19:33:46 -0000 Subject: [opensource-dev] Review Request: STORM-1713: Mouse pointer flickers when hovering over any active/clickable UI item In-Reply-To: <20111123182210.25300.20097@domU-12-31-38-00-90-68.compute-1.internal> References: <20111123182210.25300.20097@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111123193346.24390.64981@domU-12-31-38-00-90-68.compute-1.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/521/#review1095 ----------------------------------------------------------- tested the patch in dolphin viewer 3.2.0.22107. works as expected, no negative sideeffects that I can see. - Lance On Nov. 23, 2011, 10:22 a.m., Ansariel Hiller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/521/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2011, 10:22 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > The fix for the flickering mouse cursor consists of 2 parts: > > The first part changes LLView::childrenHandleHover() so that the cursor is only set if the control itself is blocking the mouse event and not at every hierarchy level in the control hierarchy. If the cursor would be set at each level, it would cause a flicker in case the different controls set a different cursor. This change actually resembles the algorithm used prior the start of the flickering. > > The second part changes LLToolTip::handleHover() and specifically handles flickering of the cursor while hovering over the "i"-button of a hovertip. The general call to LLPanel::handleHover() was changed to be only called if the tooltip itself does not set the cursor itself. Logging the calls to LLWindowWin32::setCursor() revealed that if the "i"-button on a hovertop is hovered with the cursor said method is called twice with different cursors alternatively. Checking the call stack further revealed that one call is coming from LLToolTip::handleHover() and the other one from LLButton::handleHover(). Latter gets invoked if LLPanel::handleHover() is called. Since nothing is really done here except setting the cursor to UI_CURSOR_ARROW only ti get then set to UI_CURSOR_HAND if LLPanel::handleHover() returns, it doesn't make sense to do invoke that method unless the cursor is not changed in the tooltip itself. So LLPanel::handleHover() is only invoked if the tooltip does not set the cursor itself, so that child controls should take care. > > > This addresses bug STORM-1713. > http://jira.secondlife.com/browse/STORM-1713 > > > Diffs > ----- > > doc/contributions.txt a4a5d827c7f5 > indra/llui/lltooltip.cpp a4a5d827c7f5 > indra/llui/llview.cpp a4a5d827c7f5 > > Diff: http://codereview.secondlife.com/r/521/diff > > > Testing > ------- > > Testing was done by myself on Firestorm rev. 24073 (http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/bcc95de39ca9) on Windows 7 and Lance Corrimal on Dolphin Viewer. Apparently the fix works without any side-effects > > > Thanks, > > Ansariel > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/fee0a7b6/attachment-0001.htm From Lance.Corrimal at eregion.de Wed Nov 23 11:34:19 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Wed, 23 Nov 2011 19:34:19 -0000 Subject: [opensource-dev] Review Request: STORM-1713: Mouse pointer flickers when hovering over any active/clickable UI item In-Reply-To: <20111123193346.24390.64981@domU-12-31-38-00-90-68.compute-1.internal> References: <20111123193346.24390.64981@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111123193419.24393.62593@domU-12-31-38-00-90-68.compute-1.internal> > On Nov. 23, 2011, 11:33 a.m., Lance Corrimal wrote: > > tested the patch in dolphin viewer 3.2.0.22107. works as expected, no negative sideeffects that I can see. sidenote, testing happened exclusively on linux. - Lance ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/521/#review1095 ----------------------------------------------------------- On Nov. 23, 2011, 10:22 a.m., Ansariel Hiller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/521/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2011, 10:22 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > The fix for the flickering mouse cursor consists of 2 parts: > > The first part changes LLView::childrenHandleHover() so that the cursor is only set if the control itself is blocking the mouse event and not at every hierarchy level in the control hierarchy. If the cursor would be set at each level, it would cause a flicker in case the different controls set a different cursor. This change actually resembles the algorithm used prior the start of the flickering. > > The second part changes LLToolTip::handleHover() and specifically handles flickering of the cursor while hovering over the "i"-button of a hovertip. The general call to LLPanel::handleHover() was changed to be only called if the tooltip itself does not set the cursor itself. Logging the calls to LLWindowWin32::setCursor() revealed that if the "i"-button on a hovertop is hovered with the cursor said method is called twice with different cursors alternatively. Checking the call stack further revealed that one call is coming from LLToolTip::handleHover() and the other one from LLButton::handleHover(). Latter gets invoked if LLPanel::handleHover() is called. Since nothing is really done here except setting the cursor to UI_CURSOR_ARROW only ti get then set to UI_CURSOR_HAND if LLPanel::handleHover() returns, it doesn't make sense to do invoke that method unless the cursor is not changed in the tooltip itself. So LLPanel::handleHover() is only invoked if the tooltip does not set the cursor itself, so that child controls should take care. > > > This addresses bug STORM-1713. > http://jira.secondlife.com/browse/STORM-1713 > > > Diffs > ----- > > doc/contributions.txt a4a5d827c7f5 > indra/llui/lltooltip.cpp a4a5d827c7f5 > indra/llui/llview.cpp a4a5d827c7f5 > > Diff: http://codereview.secondlife.com/r/521/diff > > > Testing > ------- > > Testing was done by myself on Firestorm rev. 24073 (http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/bcc95de39ca9) on Windows 7 and Lance Corrimal on Dolphin Viewer. Apparently the fix works without any side-effects > > > Thanks, > > Ansariel > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/32b79bb2/attachment.htm From kf6kjg at gmail.com Wed Nov 23 11:50:43 2011 From: kf6kjg at gmail.com (Ricky) Date: Wed, 23 Nov 2011 11:50:43 -0800 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: References: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> <20111123183638.25300.27555@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: Interesting. On my Mac the tabs display in the Viewer's editor as single spaces. My Win7 box shows the squares. Didn't test Linux. Definitely looks like a font issue, though I think that the best solution is to just make the Viewer's editor accept tabs - maybe even have the option to specify how much indentation a "tab" gives or to even switch between using tabs or using spaces. This wouldn't be far from existing programmer-level editors. Ricky Cron Stardust On Wed, Nov 23, 2011 at 10:58 AM, Moriz Gupte wrote: > found another glitch: > I'm developing scripts in eclipse with lslforge. When I "compile" a script in eclipse and then load it using this patch, tabstops are converted into IDunnoWhat (it shows as little squares in the script editor). > > > This behavior is familiar to me as well. I use LSL Editor, the script displays fine when read in the LSL Editor but within SL, I find that the script file shows little squares. I imagine it must be an issue related to incompatible fonts used, may be? > > > On Wed, Nov 23, 2011 at 11:36 AM, Kadah Coba wrote: > >> This is an automatically generated e-mail. To reply, visit: >> http://codereview.secondlife.com/r/516/ >> >> On November 20th, 2011, 6:53 a.m., *Lance Corrimal* wrote: >> >> found another glitch: >> I'm developing scripts in eclipse with lslforge. When I "compile" a script in eclipse and then load it using this patch, tabstops are converted into IDunnoWhat (it shows as little squares in the script editor). >> >> On November 20th, 2011, 10:29 a.m., *Ima Mechanique* wrote: >> >> I'm not familiar with lslforge, but I'll look into it. Are you sure they're valid tabs? I ask because it handles tabs from LSL Editor without a problem. >> >> On November 20th, 2011, 11:50 a.m., *Ima Mechanique* wrote: >> >> Looks like this is a bug I've introduced recently, as it is also affecting my LSL Editor created files now. :-( >> Trying to track it down, as soon as I can work out how to go back to a specific revision in Hg. >> >> On November 20th, 2011, 1:48 p.m., *Ima Mechanique* wrote: >> >> Damn. SL's text editing windows do not like tabs. When copy/pasting the tabs are converted to spaces, but not when inserting text. I'll look at finding a way around this. >> >> I don't remember any in-viewer text input ever liking \t particulary. It might be best, or at least easier or safer, to just convert them to spaces on import. >> >> >> - Kadah >> >> On November 22nd, 2011, 5:17 p.m., Ima Mechanique wrote: >> Review request for Viewer. >> By Ima Mechanique. >> >> *Updated Nov. 22, 2011, 5:17 p.m.* >> Description >> >> Changes to allow opened script window to save/load to/from files on the users computer. >> >> Testing >> >> Successfully opened and saved scripts from/to local files. >> >> *Bugs: * https://jira.secondlife.com/browse/storm-1708 >> Diffs >> >> - doc/contributions.txt (a1319d553db9) >> - indra/llui/lltexteditor.h (a1319d553db9) >> - indra/llui/lltexteditor.cpp (a1319d553db9) >> - indra/newview/llfilepicker.h (a1319d553db9) >> - indra/newview/llfilepicker.cpp (a1319d553db9) >> - indra/newview/llfloaternamedesc.h (a1319d553db9) >> - indra/newview/llfloaternamedesc.cpp (a1319d553db9) >> - indra/newview/llpreviewscript.h (a1319d553db9) >> - indra/newview/llpreviewscript.cpp (a1319d553db9) >> - indra/newview/llviewerfloaterreg.cpp (a1319d553db9) >> - indra/newview/skins/default/xui/en/panel_script_ed.xml >> (a1319d553db9) >> >> View Diff >> >> _______________________________________________ >> Policies and (un)subscribe information available here: >> http://wiki.secondlife.com/wiki/OpenSource-Dev >> Please read the policies before posting to keep unmoderated posting >> privileges >> > > > > -- > 'Consider how the lilies grow. They do not labor or spin.' > *Rameshsharma Ramloll* PhD, *Research Associate Professor*, Idaho State > University, Pocatello, ID 83209 Tel: 208-282-5333 > Blog , LinkedIn > , Play2Train > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/c43e0239/attachment.htm From Lance.Corrimal at eregion.de Wed Nov 23 11:58:22 2011 From: Lance.Corrimal at eregion.de (Lance Corrimal) Date: Wed, 23 Nov 2011 20:58:22 +0100 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: References: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <201111232058.23368.Lance.Corrimal@eregion.de> My suggestion: convert tabs to 4 spaces. I believe 4 spaces per tab is what the script editor does already anyways, for keyboard input. bye, LC Am Mittwoch, 23. November 2011 schrieb Ricky: > Interesting. On my Mac the tabs display in the Viewer's editor as > single spaces. My Win7 box shows the squares. Didn't test Linux. > Definitely looks like a font issue, though I think that the best > solution is to just make the Viewer's editor accept tabs - maybe > even have the option to specify how much indentation a "tab" gives > or to even switch between using tabs or using spaces. This > wouldn't be far from existing programmer-level editors. > > Ricky > Cron Stardust > > On Wed, Nov 23, 2011 at 10:58 AM, Moriz Gupte wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" > > a script in eclipse and then load it using this patch, tabstops > > are converted into IDunnoWhat (it shows as little squares in the > > script editor). > > > > > > This behavior is familiar to me as well. I use LSL Editor, the > > script displays fine when read in the LSL Editor but within SL, > > I find that the script file shows little squares. I imagine it > > must be an issue related to incompatible fonts used, may be? > > > > On Wed, Nov 23, 2011 at 11:36 AM, Kadah Coba wrote: > >> This is an automatically generated e-mail. To reply, visit: > >> http://codereview.secondlife.com/r/516/ > >> > >> On November 20th, 2011, 6:53 a.m., *Lance Corrimal* wrote: > >> > >> found another glitch: > >> I'm developing scripts in eclipse with lslforge. When I > >> "compile" a script in eclipse and then load it using this > >> patch, tabstops are converted into IDunnoWhat (it shows as > >> little squares in the script editor). > >> > >> On November 20th, 2011, 10:29 a.m., *Ima Mechanique* wrote: > >> I'm not familiar with lslforge, but I'll look into it. Are you > >> sure they're valid tabs? I ask because it handles tabs from LSL > >> Editor without a problem. > >> > >> On November 20th, 2011, 11:50 a.m., *Ima Mechanique* wrote: > >> Looks like this is a bug I've introduced recently, as it is also > >> affecting my LSL Editor created files now. :-( Trying to track > >> it down, as soon as I can work out how to go back to a specific > >> revision in Hg. > >> > >> On November 20th, 2011, 1:48 p.m., *Ima Mechanique* wrote: > >> Damn. SL's text editing windows do not like tabs. When > >> copy/pasting the tabs are converted to spaces, but not when > >> inserting text. I'll look at finding a way around this. > >> > >> I don't remember any in-viewer text input ever liking \t > >> particulary. It might be best, or at least easier or safer, to > >> just convert them to spaces on import. > >> > >> - Kadah > >> > >> On November 22nd, 2011, 5:17 p.m., Ima Mechanique wrote: > >> Review request for Viewer. > >> > >> By Ima Mechanique. > >> > >> *Updated Nov. 22, 2011, 5:17 p.m.* > >> Description > >> > >> Changes to allow opened script window to save/load to/from files > >> on the users computer. > >> > >> Testing > >> > >> Successfully opened and saved scripts from/to local files. > >> > >> *Bugs: * > >> https://jira.secondlife.com/browse/storm-1708 >> ondlife.com/browse/https://jira.secondlife.com/browse/storm-17 > >> 08> > >> > >> Diffs > >> > >> - doc/contributions.txt (a1319d553db9) > >> - indra/llui/lltexteditor.h (a1319d553db9) > >> - indra/llui/lltexteditor.cpp (a1319d553db9) > >> - indra/newview/llfilepicker.h (a1319d553db9) > >> - indra/newview/llfilepicker.cpp (a1319d553db9) > >> - indra/newview/llfloaternamedesc.h (a1319d553db9) > >> - indra/newview/llfloaternamedesc.cpp (a1319d553db9) > >> - indra/newview/llpreviewscript.h (a1319d553db9) > >> - indra/newview/llpreviewscript.cpp (a1319d553db9) > >> - indra/newview/llviewerfloaterreg.cpp (a1319d553db9) > >> - indra/newview/skins/default/xui/en/panel_script_ed.xml > >> (a1319d553db9) > >> > >> View Diff > >> > >> _______________________________________________ > >> Policies and (un)subscribe information available here: > >> http://wiki.secondlife.com/wiki/OpenSource-Dev > >> Please read the policies before posting to keep unmoderated > >> posting privileges > > > > -- > > 'Consider how the lilies grow. They do not labor or spin.' > > *Rameshsharma Ramloll* PhD, *Research Associate Professor*, Idaho > > State University, Pocatello, ID 83209 Tel: 208-282-5333 > > Blog , > > LinkedIn , Play2Train > > > > > > > > _______________________________________________ > > Policies and (un)subscribe information available here: > > http://wiki.secondlife.com/wiki/OpenSource-Dev > > Please read the policies before posting to keep unmoderated > > posting privileges From kf6kjg at gmail.com Wed Nov 23 12:04:09 2011 From: kf6kjg at gmail.com (Cron Stardust) Date: Wed, 23 Nov 2011 20:04:09 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> References: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111123200409.25557.92804@domU-12-31-38-00-90-68.compute-1.internal> > On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script in eclipse and then load it using this patch, tabstops are converted into IDunnoWhat (it shows as little squares in the script editor). > > > > Ima Mechanique wrote: > I'm not familiar with lslforge, but I'll look into it. Are you sure they're valid tabs? I ask because it handles tabs from LSL Editor without a problem. > > Ima Mechanique wrote: > Looks like this is a bug I've introduced recently, as it is also affecting my LSL Editor created files now. :-( > Trying to track it down, as soon as I can work out how to go back to a specific revision in Hg. > > Ima Mechanique wrote: > Damn. SL's text editing windows do not like tabs. When copy/pasting the tabs are converted to spaces, but not when inserting text. I'll look at finding a way around this. > > Kadah Coba wrote: > I don't remember any in-viewer text input ever liking \t particulary. It might be best, or at least easier or safer, to just convert them to spaces on import. I use an external editor now for all my scripting (TextWrangler) and I have set it to use only tabs for all indentation. The viewer accepts it just fine, and will even regurgitate the tabs when I open the same script in the external editor sometime later. However, if I try to edit the text using the in-world editor it will mangle the tabs every time. So my suggestion is this: don't worry about tabs when saving or loading scripts - leave the text as-is. If it's too annoying (which I think it is) than a JIRA entry should be made, unless there is one already, to request that the SL text editor support real tabs (\t) in the text. That's where the real problem domain is, not here, IMHO. - Cron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1082 ----------------------------------------------------------- On Nov. 22, 2011, 5:17 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2011, 5:17 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changes to allow opened script window to save/load to/from files on the users computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > doc/contributions.txt a1319d553db9 > indra/llui/lltexteditor.h a1319d553db9 > indra/llui/lltexteditor.cpp a1319d553db9 > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/91c07917/attachment.htm From Ima.Mechanique at blueyonder.co.uk Wed Nov 23 14:11:34 2011 From: Ima.Mechanique at blueyonder.co.uk (Ima Mechanique) Date: Wed, 23 Nov 2011 22:11:34 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> References: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111123221134.26657.46919@domU-12-31-38-00-90-68.compute-1.internal> > On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script in eclipse and then load it using this patch, tabstops are converted into IDunnoWhat (it shows as little squares in the script editor). > > > > Ima Mechanique wrote: > I'm not familiar with lslforge, but I'll look into it. Are you sure they're valid tabs? I ask because it handles tabs from LSL Editor without a problem. > > Ima Mechanique wrote: > Looks like this is a bug I've introduced recently, as it is also affecting my LSL Editor created files now. :-( > Trying to track it down, as soon as I can work out how to go back to a specific revision in Hg. > > Ima Mechanique wrote: > Damn. SL's text editing windows do not like tabs. When copy/pasting the tabs are converted to spaces, but not when inserting text. I'll look at finding a way around this. > > Kadah Coba wrote: > I don't remember any in-viewer text input ever liking \t particulary. It might be best, or at least easier or safer, to just convert them to spaces on import. > > Cron Stardust wrote: > I use an external editor now for all my scripting (TextWrangler) and I have set it to use only tabs for all indentation. The viewer accepts it just fine, and will even regurgitate the tabs when I open the same script in the external editor sometime later. However, if I try to edit the text using the in-world editor it will mangle the tabs every time. So my suggestion is this: don't worry about tabs when saving or loading scripts - leave the text as-is. If it's too annoying (which I think it is) than a JIRA entry should be made, unless there is one already, to request that the SL text editor support real tabs (\t) in the text. That's where the real problem domain is, not here, IMHO. @Kadah, @Cron. Guys, tabs are now handled as noted it the last diff (below). Are you suggesting I should remove the conversion? Personally I like using tabs in my external editors, but hate the boxes in SL's editor. @Cron. What editor is that? I've only tried live editing externally with LSL Editor, set to use UTF-8 and only indent with tabs, but the tabs only show as boxes in SL which I find defeats the purpose of clear indentation (and ugly too). - Ima ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1082 ----------------------------------------------------------- On Nov. 22, 2011, 5:17 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2011, 5:17 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changes to allow opened script window to save/load to/from files on the users computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > doc/contributions.txt a1319d553db9 > indra/llui/lltexteditor.h a1319d553db9 > indra/llui/lltexteditor.cpp a1319d553db9 > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/7ffa0782/attachment.htm From kadah.coba at gmail.com Wed Nov 23 14:33:41 2011 From: kadah.coba at gmail.com (Kadah Coba) Date: Wed, 23 Nov 2011 22:33:41 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> References: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111123223341.24393.4791@domU-12-31-38-00-90-68.compute-1.internal> > On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script in eclipse and then load it using this patch, tabstops are converted into IDunnoWhat (it shows as little squares in the script editor). > > > > Ima Mechanique wrote: > I'm not familiar with lslforge, but I'll look into it. Are you sure they're valid tabs? I ask because it handles tabs from LSL Editor without a problem. > > Ima Mechanique wrote: > Looks like this is a bug I've introduced recently, as it is also affecting my LSL Editor created files now. :-( > Trying to track it down, as soon as I can work out how to go back to a specific revision in Hg. > > Ima Mechanique wrote: > Damn. SL's text editing windows do not like tabs. When copy/pasting the tabs are converted to spaces, but not when inserting text. I'll look at finding a way around this. > > Kadah Coba wrote: > I don't remember any in-viewer text input ever liking \t particulary. It might be best, or at least easier or safer, to just convert them to spaces on import. > > Cron Stardust wrote: > I use an external editor now for all my scripting (TextWrangler) and I have set it to use only tabs for all indentation. The viewer accepts it just fine, and will even regurgitate the tabs when I open the same script in the external editor sometime later. However, if I try to edit the text using the in-world editor it will mangle the tabs every time. So my suggestion is this: don't worry about tabs when saving or loading scripts - leave the text as-is. If it's too annoying (which I think it is) than a JIRA entry should be made, unless there is one already, to request that the SL text editor support real tabs (\t) in the text. That's where the real problem domain is, not here, IMHO. > > Ima Mechanique wrote: > @Kadah, @Cron. Guys, tabs are now handled as noted it the last diff (below). Are you suggesting I should remove the conversion? > Personally I like using tabs in my external editors, but hate the boxes in SL's editor. > > @Cron. What editor is that? I've only tried live editing externally with LSL Editor, set to use UTF-8 and only indent with tabs, but the tabs only show as boxes in SL which I find defeats the purpose of clear indentation (and ugly too). I had the mistaken impression from my experience that part of that issue was at least the fault of more than just the UI text editor controls. I was only making the point cause the tab issue and the fact that most external editors use \t for tabs, is likely going to lead to "I uploaded a script and now I can't edit it properly in-viewer, thus the uploader is broken". I'd like \t to be preserved on the uploads and simple have a jira regarding the text editor's poor handling of \t linked to STORM-1708, then get that fixed separately. - Kadah ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1082 ----------------------------------------------------------- On Nov. 22, 2011, 5:17 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2011, 5:17 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changes to allow opened script window to save/load to/from files on the users computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > doc/contributions.txt a1319d553db9 > indra/llui/lltexteditor.h a1319d553db9 > indra/llui/lltexteditor.cpp a1319d553db9 > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/717c5f76/attachment-0001.htm From kf6kjg at gmail.com Wed Nov 23 14:38:39 2011 From: kf6kjg at gmail.com (Cron Stardust) Date: Wed, 23 Nov 2011 22:38:39 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> References: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111123223839.25301.97288@domU-12-31-38-00-90-68.compute-1.internal> > On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script in eclipse and then load it using this patch, tabstops are converted into IDunnoWhat (it shows as little squares in the script editor). > > > > Ima Mechanique wrote: > I'm not familiar with lslforge, but I'll look into it. Are you sure they're valid tabs? I ask because it handles tabs from LSL Editor without a problem. > > Ima Mechanique wrote: > Looks like this is a bug I've introduced recently, as it is also affecting my LSL Editor created files now. :-( > Trying to track it down, as soon as I can work out how to go back to a specific revision in Hg. > > Ima Mechanique wrote: > Damn. SL's text editing windows do not like tabs. When copy/pasting the tabs are converted to spaces, but not when inserting text. I'll look at finding a way around this. > > Kadah Coba wrote: > I don't remember any in-viewer text input ever liking \t particulary. It might be best, or at least easier or safer, to just convert them to spaces on import. > > Cron Stardust wrote: > I use an external editor now for all my scripting (TextWrangler) and I have set it to use only tabs for all indentation. The viewer accepts it just fine, and will even regurgitate the tabs when I open the same script in the external editor sometime later. However, if I try to edit the text using the in-world editor it will mangle the tabs every time. So my suggestion is this: don't worry about tabs when saving or loading scripts - leave the text as-is. If it's too annoying (which I think it is) than a JIRA entry should be made, unless there is one already, to request that the SL text editor support real tabs (\t) in the text. That's where the real problem domain is, not here, IMHO. > > Ima Mechanique wrote: > @Kadah, @Cron. Guys, tabs are now handled as noted it the last diff (below). Are you suggesting I should remove the conversion? > Personally I like using tabs in my external editors, but hate the boxes in SL's editor. > > @Cron. What editor is that? I've only tried live editing externally with LSL Editor, set to use UTF-8 and only indent with tabs, but the tabs only show as boxes in SL which I find defeats the purpose of clear indentation (and ugly too). > > Kadah Coba wrote: > I had the mistaken impression from my experience that part of that issue was at least the fault of more than just the UI text editor controls. I was only making the point cause the tab issue and the fact that most external editors use \t for tabs, is likely going to lead to "I uploaded a script and now I can't edit it properly in-viewer, thus the uploader is broken". > I'd like \t to be preserved on the uploads and simple have a jira regarding the text editor's poor handling of \t linked to STORM-1708, then get that fixed separately. @Ima: WRT to the conversion, I suspect controversy here. Personally I'd go for leaving the file the way I intended it - with tabs, or any number of spaces, depending on how my external editor is configured. To me, since I use ExternalEditor, this Save/Load functionality is more a way of doing backup and restore, but having it mangle my files doesn't sound good to me. Maybe a debug setting for the conversion, but most likely not: the real fix is to fix the in-world editor to display the tabs correctly. Like I said in the OSDev list, I don't see the squares: the tabs render as something akin to spaces. As to the editor, it's just a nice advanced editor for Mac OS that's free. Its big brother is BBEdit. I had to go find a syntax highlighter module for LSL. In Windows I use Programmer's Notepad, again with a highlighter plugin. On Linux, since I use KDE, I set up Kate as my editor. All three are very similar. @Kadah: Agreed. - Cron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1082 ----------------------------------------------------------- On Nov. 22, 2011, 5:17 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2011, 5:17 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changes to allow opened script window to save/load to/from files on the users computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > doc/contributions.txt a1319d553db9 > indra/llui/lltexteditor.h a1319d553db9 > indra/llui/lltexteditor.cpp a1319d553db9 > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/1a454c68/attachment.htm From moriz.gupte at gmail.com Wed Nov 23 14:39:47 2011 From: moriz.gupte at gmail.com (Moriz Gupte) Date: Wed, 23 Nov 2011 15:39:47 -0700 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111123223341.24393.4791@domU-12-31-38-00-90-68.compute-1.internal> References: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> <20111123223341.24393.4791@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: @Kadah, you are right. This is what is going to happen. I would not knowingly let an 'annoyance' go out with a release. Not worth the community backlash ... I was only making the point cause the tab issue and the fact that most external editors use \t for tabs, is likely going to lead to "I uploaded a script and now I can't edit it properly in-viewer, thus the uploader is broken". On Wed, Nov 23, 2011 at 3:33 PM, Kadah Coba wrote: > I was only making the point cause the tab issue and the fact that most > external editors use \t for tabs, is likely going to lead to "I uploaded a > script and now I can't edit it properly in-viewer, thus the uploader is > broken". -- 'Consider how the lilies grow. They do not labor or spin.' *Rameshsharma Ramloll* PhD, *Research Associate Professor*, Idaho State University, Pocatello, ID 83209 Tel: 208-282-5333 Blog , LinkedIn , Play2Train -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/991aceb3/attachment.htm From Ima.Mechanique at blueyonder.co.uk Thu Nov 24 15:42:41 2011 From: Ima.Mechanique at blueyonder.co.uk (Ima Mechanique) Date: Thu, 24 Nov 2011 23:42:41 -0000 Subject: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files. In-Reply-To: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> References: <20111120145333.24392.2649@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111124234241.25301.808@domU-12-31-38-00-90-68.compute-1.internal> > On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script in eclipse and then load it using this patch, tabstops are converted into IDunnoWhat (it shows as little squares in the script editor). > > > > Ima Mechanique wrote: > I'm not familiar with lslforge, but I'll look into it. Are you sure they're valid tabs? I ask because it handles tabs from LSL Editor without a problem. > > Ima Mechanique wrote: > Looks like this is a bug I've introduced recently, as it is also affecting my LSL Editor created files now. :-( > Trying to track it down, as soon as I can work out how to go back to a specific revision in Hg. > > Ima Mechanique wrote: > Damn. SL's text editing windows do not like tabs. When copy/pasting the tabs are converted to spaces, but not when inserting text. I'll look at finding a way around this. > > Kadah Coba wrote: > I don't remember any in-viewer text input ever liking \t particulary. It might be best, or at least easier or safer, to just convert them to spaces on import. > > Cron Stardust wrote: > I use an external editor now for all my scripting (TextWrangler) and I have set it to use only tabs for all indentation. The viewer accepts it just fine, and will even regurgitate the tabs when I open the same script in the external editor sometime later. However, if I try to edit the text using the in-world editor it will mangle the tabs every time. So my suggestion is this: don't worry about tabs when saving or loading scripts - leave the text as-is. If it's too annoying (which I think it is) than a JIRA entry should be made, unless there is one already, to request that the SL text editor support real tabs (\t) in the text. That's where the real problem domain is, not here, IMHO. > > Ima Mechanique wrote: > @Kadah, @Cron. Guys, tabs are now handled as noted it the last diff (below). Are you suggesting I should remove the conversion? > Personally I like using tabs in my external editors, but hate the boxes in SL's editor. > > @Cron. What editor is that? I've only tried live editing externally with LSL Editor, set to use UTF-8 and only indent with tabs, but the tabs only show as boxes in SL which I find defeats the purpose of clear indentation (and ugly too). > > Kadah Coba wrote: > I had the mistaken impression from my experience that part of that issue was at least the fault of more than just the UI text editor controls. I was only making the point cause the tab issue and the fact that most external editors use \t for tabs, is likely going to lead to "I uploaded a script and now I can't edit it properly in-viewer, thus the uploader is broken". > I'd like \t to be preserved on the uploads and simple have a jira regarding the text editor's poor handling of \t linked to STORM-1708, then get that fixed separately. > > Cron Stardust wrote: > @Ima: WRT to the conversion, I suspect controversy here. Personally I'd go for leaving the file the way I intended it - with tabs, or any number of spaces, depending on how my external editor is configured. To me, since I use ExternalEditor, this Save/Load functionality is more a way of doing backup and restore, but having it mangle my files doesn't sound good to me. Maybe a debug setting for the conversion, but most likely not: the real fix is to fix the in-world editor to display the tabs correctly. Like I said in the OSDev list, I don't see the squares: the tabs render as something akin to spaces. > > As to the editor, it's just a nice advanced editor for Mac OS that's free. Its big brother is BBEdit. I had to go find a syntax highlighter module for LSL. In Windows I use Programmer's Notepad, again with a highlighter plugin. On Linux, since I use KDE, I set up Kate as my editor. All three are very similar. > > @Kadah: Agreed. @Cron: I think whichever way tabs are handled will cause controversy. Some will regard, and already have, the non-printing characters being displayed to be an error of the import process and not that of the editor display. This is understandable as they will never have encountered it before in SL. Others, and I count myself here, would simply like the editor to leave the file alone and display tabs as tab-stops. Either way, someone will not be happy. I think, that this is a decision for the product owner to make. ;-) Incidentally, I filed a JIRA for external editing not dealing with tabs. We can see what is desired from how that is handled. - Ima ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1082 ----------------------------------------------------------- On Nov. 22, 2011, 5:17 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2011, 5:17 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changes to allow opened script window to save/load to/from files on the users computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > doc/contributions.txt a1319d553db9 > indra/llui/lltexteditor.h a1319d553db9 > indra/llui/lltexteditor.cpp a1319d553db9 > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111124/380ac55f/attachment.htm From dave at meadowlakearts.com Fri Nov 25 18:46:19 2011 From: dave at meadowlakearts.com (Dave Booth) Date: Fri, 25 Nov 2011 20:46:19 -0600 Subject: [opensource-dev] [viewer-development-builds] Successful Build Nr. 245237 for snowstorm_viewer-development (cfa78777453c) on CYGWIN In-Reply-To: <4ECB126C.9040007@meadowlakearts.com> References: <20111116005744.9D062E2CADD@viognier.lindenlab.com> <4EC693E2.4090600@xp2.de> <4EC6F111.4050205@meadowlakearts.com> <4ECB126C.9040007@meadowlakearts.com> Message-ID: <4ED052FB.8050106@meadowlakearts.com> On 11/21/2011 9:09 PM, Dave Booth wrote: > On 11/18/2011 5:58 PM, Dave Booth wrote: >> On 11/18/2011 11:20 AM, Tillie Ariantho wrote: >>> >>> That build crashes the nVidia driver pretty often. Right now I can't >>> even log in with the dev client, crashes the driver right after >>> clicking Login. >> >> Confirmed here too, ... > 245610 is even worse.. even the registry hack doesnt work. Do we have an eta for the shining branch GL fixes hitting the trunk yet? Even a back-of-the-envelope guesstimate? I'm tired of crashing every time I set my graphics higher than I'd use on a machine half a dozen years older than the one I am actually on, or even up to the settings I used to use on my previous box.. From richard at lindenlab.com Mon Nov 28 13:26:00 2011 From: richard at lindenlab.com (Richard Nelson) Date: Mon, 28 Nov 2011 21:26:00 -0000 Subject: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased In-Reply-To: <20111123161852.26663.93125@domU-12-31-38-00-90-68.compute-1.internal> References: <20111123161852.26663.93125@domU-12-31-38-00-90-68.compute-1.internal> Message-ID: <20111128212600.1662.13163@domU-12-31-38-00-90-68.compute-1.internal> > On Nov. 23, 2011, 8:18 a.m., Richard Nelson wrote: > > Quick comment regarding behavior...we really should not play any audio during the teleport blackout as it is disconcerting to feel like you are still in an area (hearing the audio) but not be able to see or interact with anything. Everything else sounds great. > > Jonathan Yap wrote: > The reason I changed the behavior when the teleport progress bar was showing was to keep the state engine logic simple -- it activates when there is change in your current parcel music URL. > > Otherwise you have to deal with various cases as exceptions to how the state engine processes stream transitions. > > If you force-fade the current stream when the teleport progress bar appears and the teleport fails you'll have to fade the stream back in. I am not sure if there are other edge cases that might appear. > > I suggest trying Oz's PO test viewer (there is a download link in a jira comment). Personally I felt having the music keep playing and then fade out and in when you arrive was more enjoyable (you can consider it in-flight entertainment). This also might tie in well with any improvements to the progress bar screen no longer being a blank page as was discussed in one of Oz's user group meetings. > > > Oz Linden wrote: > On the other hand, testing in the current Development viewer [Second Life 3.2.4 (245662)], when I started from a parcel with a stream and TP'ed to a new region&parcel without one, I got a sudden cutoff when the TP screen came up but the stream restarted when the screen dropped and then cut off quickly (presumably because new parcel properties had arrived). That's arguably not as good as a fade after teleport. One of the in-progress changes to the teleport/log in screen would involve playing video+audio on that login screen, which should not be fighting with background audio. - Richard ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/520/#review1090 ----------------------------------------------------------- On Nov. 23, 2011, 5:59 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/520/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2011, 5:59 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Audio fading in has been added for when a music stream starts. Audio fading out has been added for when there is a change in the music stream that is playing. > > Two dead files have been eliminated. > > An existing bug in how music was not being paused correctly has been fixed. > > When you are teleporting you will hear the music stream from the place you are leaving. This is a change in behavior; previously the music stream was stopped when the teleport progress bar was being displayed. > > This code change affects several areas where music is started or stopped. The new code has evolved significantly, so please look for things that might not "make sense." > > > This addresses bug STORM-591. > http://jira.secondlife.com/browse/STORM-591 > > > Diffs > ----- > > doc/contributions.txt 8b455c1b7a5e > indra/newview/lloverlaybar.h 8b455c1b7a5e > indra/newview/lloverlaybar.cpp 8b455c1b7a5e > indra/newview/llpanelnearbymedia.h 8b455c1b7a5e > indra/newview/llpanelnearbymedia.cpp 8b455c1b7a5e > indra/newview/llvieweraudio.h 8b455c1b7a5e > indra/newview/llvieweraudio.cpp 8b455c1b7a5e > indra/newview/llviewermedia.cpp 8b455c1b7a5e > indra/newview/llviewerparcelmgr.cpp 8b455c1b7a5e > > Diff: http://codereview.secondlife.com/r/520/diff > > > Testing > ------- > > See the massive test plan in the jira. > > > Thanks, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111128/7bc0bc43/attachment.htm From marinekelley at gmail.com Mon Nov 28 14:20:38 2011 From: marinekelley at gmail.com (Marine Kelley) Date: Mon, 28 Nov 2011 23:20:38 +0100 Subject: [opensource-dev] Latest commits break the deferred engine and alpha textures ? Message-ID: Hello all, I have just pulled the latest commits (up to "22037 (1343609b39cf) merge changes for vmrg-193") and built it, and here is what I observe when I try it out : - I can't activate the deferred renderer anymore, even if Lighting & Shadows is checked in the preferences, with Sun/Moon/Projectors, ambient occlusion and all. - Alpha textures are black where they should be transparent - A lot of textures are missing, simply grey or white, all of them are supposed to be fully alpha (no visible pixels), like the sides of prim hair for example Anybody else sees that ? Or is it just me ? Thanks, Marine From tigrospottystripes at gmail.com Mon Nov 28 14:42:26 2011 From: tigrospottystripes at gmail.com (Tigro Spottystripes) Date: Mon, 28 Nov 2011 20:42:26 -0200 Subject: [opensource-dev] User input solicited picking a number... In-Reply-To: <4ECA7BAD.9090605@lindenlab.com> References: <4EC66B4D.4040106@lindenlab.com> <4ECA7BAD.9090605@lindenlab.com> Message-ID: Why does it need to be hardcoded instead of being a setting? On Mon, Nov 21, 2011 at 2:26 PM, Oz Linden (Scott Lawrence) < oz at lindenlab.com> wrote: > On 2011-11-18 9:27, Oz Linden (Scott Lawrence) wrote: > > > The current test implementation has a pair of debug variables for > controlling the fade time: AudioMusicFadeIn and AudioMusicFadeOut are the > number of seconds that each fade takes. In the test version above, these > default to 5 seconds. > > > I've been experimenting a bit with this, and I rather like 3 in and 2 > out... > > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111128/1936ada2/attachment.htm From sl-dev at theblob.org Mon Nov 28 16:29:49 2011 From: sl-dev at theblob.org (Sophira Crystal) Date: Tue, 29 Nov 2011 00:29:49 +0000 Subject: [opensource-dev] User input solicited picking a number... In-Reply-To: References: <4EC66B4D.4040106@lindenlab.com> <4ECA7BAD.9090605@lindenlab.com> Message-ID: On Mon, Nov 28, 2011 at 10:42 PM, Tigro Spottystripes wrote: > Why does it need to be hardcoded instead of being a setting? According to the original post, because "the additional testing complexity of having variables is not worth the flexibility". (I kind of wish it was a setting too, but apparently this is settled, so it's probably not worth going into.) - Sophie. From tigrospottystripes at gmail.com Tue Nov 29 05:11:54 2011 From: tigrospottystripes at gmail.com (Tigro Spottystripes) Date: Tue, 29 Nov 2011 11:11:54 -0200 Subject: [opensource-dev] User input solicited picking a number... In-Reply-To: References: <4EC66B4D.4040106@lindenlab.com> <4ECA7BAD.9090605@lindenlab.com> Message-ID: Oh, sorry, dunno how i missed that bit On Mon, Nov 28, 2011 at 10:29 PM, Sophira Crystal wrote: > On Mon, Nov 28, 2011 at 10:42 PM, Tigro Spottystripes > wrote: > > Why does it need to be hardcoded instead of being a setting? > > According to the original post, because "the additional testing > complexity of having variables is not worth the flexibility". > > (I kind of wish it was a setting too, but apparently this is settled, > so it's probably not worth going into.) > > - Sophie. > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111129/a2e5a700/attachment.htm From dave at meadowlakearts.com Tue Nov 29 16:30:50 2011 From: dave at meadowlakearts.com (Dave Booth) Date: Tue, 29 Nov 2011 18:30:50 -0600 Subject: [opensource-dev] Is the build machine stuck? In-Reply-To: References: Message-ID: <4ED5793A.9010104@meadowlakearts.com> On 11/19/2011 9:26 PM, Cincia Singh wrote: > I have seen it saying "in progress" for 2 days now. Is it not finishing? > Both Snowstorm and the shining fixes web page for the OpenGL builds. > It's doing it again. 245787 has been showing in progress for over 24h. From dave at meadowlakearts.com Tue Nov 29 16:42:29 2011 From: dave at meadowlakearts.com (Dave Booth) Date: Tue, 29 Nov 2011 18:42:29 -0600 Subject: [opensource-dev] Is the build machine stuck? In-Reply-To: <4ED5793A.9010104@meadowlakearts.com> References: <4ED5793A.9010104@meadowlakearts.com> Message-ID: <4ED57BF5.3080302@meadowlakearts.com> On 11/29/2011 6:30 PM, Dave Booth wrote: > On 11/19/2011 9:26 PM, Cincia Singh wrote: >> I have seen it saying "in progress" for 2 days now. Is it not finishing? >> Both Snowstorm and the shining fixes web page for the OpenGL builds. >> > > It's doing it again. 245787 has been showing in progress for over 24h. And this breaks the quicklink from the wiki to the latest build too. That still points to Wednesdays 245711. From oz at lindenlab.com Wed Nov 30 07:08:30 2011 From: oz at lindenlab.com (Oz Linden (Scott Lawrence)) Date: Wed, 30 Nov 2011 10:08:30 -0500 Subject: [opensource-dev] Is the build machine stuck? In-Reply-To: <4ED5793A.9010104@meadowlakearts.com> References: <4ED5793A.9010104@meadowlakearts.com> Message-ID: <4ED646EE.7070108@lindenlab.com> On 2011-11-29 19:30, Dave Booth wrote: > On 11/19/2011 9:26 PM, Cincia Singh wrote: >> I have seen it saying "in progress" for 2 days now. Is it not finishing? >> Both Snowstorm and the shining fixes web page for the OpenGL builds. >> > It's doing it again. 245787 has been showing in progress for over 24h. One of the builds timed out - I restarted it and things seem to be ok now.