[opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

Ima Mechanique Ima.Mechanique at blueyonder.co.uk
Fri Nov 18 13:36:53 PST 2011



> On Nov. 18, 2011, 6:06 a.m., Lance Corrimal wrote:
> > Built it into dolphin 3.2 beta, tested it. found a few issues:
> > - main menu option Build/Upload/Script does nothing at all
> > - saving a script that you open from your inventory to disk only works after you edit the script
> > - saving a script to disk does not add .lsl to the filename by default
> >
> 
> Ima Mechanique wrote:
>     Thanks for the feedback.
>     - The Build => Upload => Script entry shouldn't be there, I'll correct the code. It's a follow up project, which I haven't completed yet.
>     - Saving only works after editing. This is normal behaviour for scripts, I was doubtful of doing it this way, but did so to maintain consistency. If there is a consensus to alter this behaviour I would happily agree to do so.
>     - Hmm, .lsl should be added by default, I'll look into this.
> 
> Kelly Washington wrote:
>     Unless opening the script from file automatically saves (uploads and compiles) the script then it makes more sense for the save button to be enabled as soon as the script is loaded. No need to wait for an edit to enable the save.

@Kelly. No it doesn't upload and save, that would be the job for the Build => Upload => Script entry that I'm also working on separately. So far as my own testing, uploading a file into the window does automatically enable the save to inventory button. The saving that Lance mentioned is for saving to disc, which is not automatically enabled, currently, unless the script's state is not clean.


- Ima


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/516/#review1076
-----------------------------------------------------------


On Nov. 18, 2011, 1:21 p.m., Ima Mechanique wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/516/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2011, 1:21 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Changes to allow opened script window to save/load to/from files on the users computer.
> 
> 
> This addresses bug https://jira.secondlife.com/browse/storm-1708.
>     http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt a1319d553db9 
>   indra/newview/llfilepicker.h a1319d553db9 
>   indra/newview/llfilepicker.cpp a1319d553db9 
>   indra/newview/llfloaternamedesc.h a1319d553db9 
>   indra/newview/llfloaternamedesc.cpp a1319d553db9 
>   indra/newview/llpreviewscript.h a1319d553db9 
>   indra/newview/llpreviewscript.cpp a1319d553db9 
>   indra/newview/llviewerfloaterreg.cpp a1319d553db9 
>   indra/newview/llviewermenufile.cpp a1319d553db9 
>   indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 
> 
> Diff: http://codereview.secondlife.com/r/516/diff
> 
> 
> Testing
> -------
> 
> Successfully opened and saved scripts from/to local files.
> 
> 
> Thanks,
> 
> Ima
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111118/d0b8a38d/attachment.htm 


More information about the opensource-dev mailing list