[opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased

Jonathan Yap jhwelch at gmail.com
Wed Nov 23 08:41:39 PST 2011



> On Nov. 23, 2011, 8:18 a.m., Richard Nelson wrote:
> > Quick comment regarding behavior...we really should not play any audio during the teleport blackout as it is disconcerting to feel like you are still in an area (hearing the audio) but not be able to see or interact with anything.  Everything else sounds great.

The reason I changed the behavior when the teleport progress bar was showing was to keep the state engine logic simple -- it activates when there is change in your current parcel music URL.

Otherwise you have to deal with various cases as exceptions to how the state engine processes stream transitions.

If you force-fade the current stream when the teleport progress bar appears and the teleport fails you'll have to fade the stream back in.  I am not sure if there are other edge cases that might appear.

I suggest trying Oz's PO test viewer (there is a download link in a jira comment).  Personally I felt having the music keep playing and then fade out and in when you arrive was more enjoyable (you can consider it in-flight entertainment).  This also might tie in well with any improvements to the progress bar screen no longer being a blank page as was discussed in one of Oz's user group meetings.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/520/#review1090
-----------------------------------------------------------


On Nov. 23, 2011, 5:59 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/520/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2011, 5:59 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Audio fading in has been added for when a music stream starts.  Audio fading out has been added for when there is a change in the music stream that is playing.
> 
> Two dead files have been eliminated.
> 
> An existing bug in how music was not being paused correctly has been fixed.
> 
> When you are teleporting you will hear the music stream from the place you are leaving.  This is a change in behavior; previously the music stream was stopped when the teleport progress bar was being displayed.
> 
> This code change affects several areas where music is started or stopped.  The new code has evolved significantly, so please look for things that might not "make sense."
> 
> 
> This addresses bug STORM-591.
>     http://jira.secondlife.com/browse/STORM-591
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 8b455c1b7a5e 
>   indra/newview/lloverlaybar.h 8b455c1b7a5e 
>   indra/newview/lloverlaybar.cpp 8b455c1b7a5e 
>   indra/newview/llpanelnearbymedia.h 8b455c1b7a5e 
>   indra/newview/llpanelnearbymedia.cpp 8b455c1b7a5e 
>   indra/newview/llvieweraudio.h 8b455c1b7a5e 
>   indra/newview/llvieweraudio.cpp 8b455c1b7a5e 
>   indra/newview/llviewermedia.cpp 8b455c1b7a5e 
>   indra/newview/llviewerparcelmgr.cpp 8b455c1b7a5e 
> 
> Diff: http://codereview.secondlife.com/r/520/diff
> 
> 
> Testing
> -------
> 
> See the massive test plan in the jira.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/33140d7e/attachment.htm 


More information about the opensource-dev mailing list