[opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

[Kadah Coba]

> On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote:
> > found another glitch:
> > I'm developing scripts in eclipse with lslforge. When I "compile" a script in eclipse and then load it using this patch, tabstops are converted into IDunnoWhat (it shows as little squares in the script editor).
> >
> 
> Ima Mechanique wrote:
>     I'm not familiar with lslforge, but I'll look into it. Are you sure they're valid tabs? I ask because it handles tabs from LSL Editor without a problem.
> 
> Ima Mechanique wrote:
>     Looks like this is a bug I've introduced recently, as it is also affecting my LSL Editor created files now. :-(
>     Trying to track it down, as soon as I can work out how to go back to a specific revision in Hg.
> 
> Ima Mechanique wrote:
>     Damn.  SL's text editing windows do not like tabs. When copy/pasting the tabs are converted to spaces, but not when inserting text. I'll look at finding a way around this.

I don't remember any in-viewer text input ever liking \t particulary. It might be best, or at least easier or safer, to just convert them to spaces on import.


- Kadah


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/516/#review1082
-----------------------------------------------------------


On Nov. 22, 2011, 5:17 p.m., Ima Mechanique wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/516/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2011, 5:17 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Changes to allow opened script window to save/load to/from files on the users computer.
> 
> 
> This addresses bug https://jira.secondlife.com/browse/storm-1708.
>     http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt a1319d553db9 
>   indra/llui/lltexteditor.h a1319d553db9 
>   indra/llui/lltexteditor.cpp a1319d553db9 
>   indra/newview/llfilepicker.h a1319d553db9 
>   indra/newview/llfilepicker.cpp a1319d553db9 
>   indra/newview/llfloaternamedesc.h a1319d553db9 
>   indra/newview/llfloaternamedesc.cpp a1319d553db9 
>   indra/newview/llpreviewscript.h a1319d553db9 
>   indra/newview/llpreviewscript.cpp a1319d553db9 
>   indra/newview/llviewerfloaterreg.cpp a1319d553db9 
>   indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 
> 
> Diff: http://codereview.secondlife.com/r/516/diff
> 
> 
> Testing
> -------
> 
> Successfully opened and saved scripts from/to local files.
> 
> 
> Thanks,
> 
> Ima
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/639536f3/attachment.htm