[opensource-dev] Review Request: Texture Picker: Making the preview "widget" a little more flexible.

[Richard Nelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/474/#review1041
-----------------------------------------------------------


Please do not use localization strings to parameterize a widget.  Better to use a place holder <view> and then call getChildView on it and use the rect of that view for displaying the texture preview.

- Richard


On Oct. 4, 2011, 7:26 a.m., Vaalith Jinn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/474/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2011, 7:26 a.m.)
> 
> 
> Review request for Viewer and Richard Nelson.
> 
> 
> Summary
> -------
> 
> Update: would appreciate a LL yes or no to this, as it's one of the issues that's holding back STORM-64.
> 
> 
> Texture picker's preview box was never a real widget. It had no XUI presence so the XUI designers had no control over it.
> Also, it's height depended on the it's parent floater's min size which meant that increasing the min size distorted the preview box,
> which must be at a 1:1 ratio.
> 
> I have modified the code in a way that
> a) makes the preview box no longer reliant on any of the floater's own parameters.
> b) gives the XUI designers three parameters that affect the preview box specifically: left, top, and size.
> (size is both the size from left to right, and from top to bottom, keeping it locked to 1:1)
> 
> The changes are only noticeable to coders and xui designers, not the users.
> note: It is still not a real widget and it still lacks a follow, layout, delta and any other widget specific abilities.
> 
> 
> Diffs
> -----
> 
>   indra/newview/lltexturectrl.cpp d36e49ee2651 
>   indra/newview/skins/default/xui/en/floater_texture_ctrl.xml d36e49ee2651 
> 
> Diff: http://codereview.secondlife.com/r/474/diff
> 
> 
> Testing
> -------
> 
> The box seems to behave exactly as it did before.
> Changing the indicated left, top, and size values in the appropriate xml file does affect the relevant properties. 
> 
> 
> Thanks,
> 
> Vaalith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111004/591a3194/attachment.htm