[opensource-dev] Review Request: STORM-959 Syntax highlighting for LSL multi-line comments.

[Boroondas Gupte]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/498/#review1055
-----------------------------------------------------------


Looks good as far as I can tell. Can we unit-test this somehow, though?


indra/llui/llkeywords.cpp
<http://codereview.secondlife.com/r/498/#comment1061>

    Code duplication. Could be worth factoring out an (inlined) compare function to be called with mToken in isHead and with mDelimiter in isTail.



indra/llui/llkeywords.cpp
<http://codereview.secondlife.com/r/498/#comment1059>

    Any reason to keep this line commented out instead of removing it entirely?



indra/llui/llkeywords.cpp
<http://codereview.secondlife.com/r/498/#comment1060>

    While we're here, this comment should start with 'If', not 'Is'


- Boroondas


On Oct. 15, 2011, 9:55 p.m., Ima Mechanique wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/498/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2011, 9:55 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Adding syntax highlighting for LSL multi-line comments.
> This has been sitting on my hard drive for months. I've redone the diff against current tip.
> 
> 
> This addresses bug STORM-959.
>     http://jira.secondlife.com/browse/STORM-959
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 871963a3c7b9 
>   indra/llui/llkeywords.h 871963a3c7b9 
>   indra/llui/llkeywords.cpp 871963a3c7b9 
>   indra/newview/app_settings/keywords.ini 871963a3c7b9 
> 
> Diff: http://codereview.secondlife.com/r/498/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ima
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111016/1ea95308/attachment-0001.htm