[opensource-dev] Review Request: VWR-27184: Hide "Library" landmark accordion when NoInventoryLibrary is set to TRUE

Jonathan Yap jhwelch at gmail.com
Mon Oct 17 03:38:04 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/499/#review1056
-----------------------------------------------------------



indra/newview/skins/default/xui/en/panel_landmarks.xml
<http://codereview.secondlife.com/r/499/#comment1062>

    Am I missing the place in the code where there is a corresponding setVisible call since the default now seems to be not visible?


- Jonathan


On Oct. 17, 2011, 3:23 a.m., Lance Corrimal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/499/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2011, 3:23 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> When the user hides the library by setting the debug setting "NoInventoryLibrary" to TRUE, the Library accordion in the landmark panel stays and duplicates the "My Inventory" accordion. This patch fixes that.
> 
> 
> This addresses bug VWR-27184.
>     http://jira.secondlife.com/browse/VWR-27184
> 
> 
> Diffs
> -----
> 
>   indra/newview/llpanellandmarks.cpp 871963a3c7b9 
>   indra/newview/skins/default/xui/en/panel_landmarks.xml 871963a3c7b9 
> 
> Diff: http://codereview.secondlife.com/r/499/diff
> 
> 
> Testing
> -------
> 
> using this patch in Dolphin Viewer 3 since 3.0.11 without problems.
> 
> 
> Thanks,
> 
> Lance
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111017/af894aad/attachment.htm 


More information about the opensource-dev mailing list