[opensource-dev] Review Request: STORM-959 Syntax highlighting for LSL multi-line comments.
Oz Linden
oz at lindenlab.com
Tue Oct 18 08:47:23 PDT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/498/#review1058
-----------------------------------------------------------
indra/llui/llkeywords.h
<http://codereview.secondlife.com/r/498/#comment1064>
Doxygen comments for the usage of these would be good.
Per the coding standard, it should be a typedef:
https://wiki.secondlife.com/wiki/Coding_Standard#Enums
indra/llui/llkeywords.h
<http://codereview.secondlife.com/r/498/#comment1065>
getLength2 is not descriptive.... name it in a way that reflects the difference in what it does (and if making that clear requires renaming getLength, that's fine)
- Oz
On Oct. 16, 2011, 12:45 p.m., Ima Mechanique wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/498/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2011, 12:45 p.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> Adding syntax highlighting for LSL multi-line comments.
> This has been sitting on my hard drive for months. I've redone the diff against current tip.
>
>
> This addresses bug STORM-959.
> http://jira.secondlife.com/browse/STORM-959
>
>
> Diffs
> -----
>
> doc/contributions.txt 871963a3c7b9
> indra/llui/llkeywords.h 871963a3c7b9
> indra/llui/llkeywords.cpp 871963a3c7b9
> indra/newview/app_settings/keywords.ini 871963a3c7b9
>
> Diff: http://codereview.secondlife.com/r/498/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ima
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111018/0139616c/attachment.htm
More information about the opensource-dev
mailing list