[opensource-dev] Review Request: storm-1622: fix wind eddies

[Oz Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/503/
-----------------------------------------------------------

Review request for Viewer.


Summary
-------

The implementation in the viewer of the local wind eddies was too closely coupled to that of the Classic Clouds, so that when the clouds were removed in v2.8 the local wind eddies were broken.

This change removes that coupling (along with a few vestigial bits of the classic clouds) and restores the wind eddies.

It turned out that there was also some debug code for visualizing the wind, so I attached that to the Develop>Render Metadata menu (Wind Vectors), adjusting it so that it displays the vectors 25 meters above the avatar (attaching screenshots to the jira issue).  Thanks are due to Runitai Linden for help with this part.


This addresses bug storm-1622.
    http://jira.secondlife.com/browse/storm-1622


Diffs
-----

  indra/newview/llglsandbox.cpp 913d90c3225b 
  indra/newview/llviewermenu.cpp 913d90c3225b 
  indra/newview/llwind.h 913d90c3225b 
  indra/newview/llwind.cpp 913d90c3225b 
  indra/newview/pipeline.h 913d90c3225b 
  indra/newview/pipeline.cpp 913d90c3225b 
  indra/newview/skins/default/xui/en/menu_viewer.xml 913d90c3225b 

Diff: http://codereview.secondlife.com/r/503/diff


Testing
-------

Tested with particles that are sensitive to wind, and the excellent demonstration site linked in the jira issue.


Thanks,

Oz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111019/d1d86672/attachment.htm