[opensource-dev] Review Request: STORM-1653 Group notices sent by muted residents are still displayed

Jonathan Yap jhwelch at gmail.com
Wed Oct 26 11:10:23 PDT 2011



> On Oct. 26, 2011, 10:22 a.m., Oz Linden wrote:
> > indra/newview/llviewermessage.cpp, line 2462
> > <http://codereview.secondlife.com/r/508/diff/1/?file=7298#file7298line2462>
> >
> >     I don't think you can get a cache miss on a legacy name fetch, but in any case something should be logged here (I'd say at warning level).
> >

Done.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/508/#review1061
-----------------------------------------------------------


On Oct. 26, 2011, 11:09 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/508/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2011, 11:09 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> When I mute a resident, group notices from that resident are still being displayed to me.
> 
> 
> This addresses bug STORM-1653.
>     http://jira.secondlife.com/browse/STORM-1653
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt c42575f2cde8 
>   indra/newview/llviewermessage.cpp c42575f2cde8 
> 
> Diff: http://codereview.secondlife.com/r/508/diff
> 
> 
> Testing
> -------
> 
> See test plan in jira.
> 
> Even with an empty name cache I still get an AgentID back.  It is not clear to me if I might not when there is a cache miss and the backend systems servicing the name to ID request are heavily loaded.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111026/b074057b/attachment.htm 


More information about the opensource-dev mailing list