[opensource-dev] Review Request: STORM-1105 "Traffic: 0" shown for two cases (traffic actually 0, and waiting for data)

[Vadim ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/509/#review1070
-----------------------------------------------------------

Ship it!


- Vadim


On Oct. 28, 2011, 4:34 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/509/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2011, 4:34 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> 
> In the past, the daily computation for "traffic" has failed to compute - see SVC-6142 - which results in showing "Traffic: 0" for parcels that have actually had visitors.
> 
> However, even if that has been addressed (and we believe it has), the viewer logic shows "Traffic: 0" for two cases:
> 
>     * Waiting for data from the server
>     * Traffic actually is 0
> 
> Ideally, the viewer would distinguish these, e.g. showing "(waiting for data)" or some such, so that it is clear that the 0 is not an actual result in those cases.
> 
> This should be relatively easy to plumb into indra/newview/llviewerparcelmgr.cpp and indra/newview/llfloaterland.cpp
> 
> 
> This addresses bug STORM-1105.
>     http://jira.secondlife.com/browse/STORM-1105
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 8b455c1b7a5e 
>   indra/newview/llfloaterland.cpp 8b455c1b7a5e 
>   indra/newview/llviewerparcelmgr.h 8b455c1b7a5e 
>   indra/newview/llviewerparcelmgr.cpp 8b455c1b7a5e 
>   indra/newview/skins/default/xui/en/floater_about_land.xml 8b455c1b7a5e 
> 
> Diff: http://codereview.secondlife.com/r/509/diff
> 
> 
> Testing
> -------
> 
> Opened About Land repeatedly, saw Loading... briefly before a numerical value for Traffic appeared.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111031/036109dd/attachment.htm