[opensource-dev] Review Request: STORM-64: Local Bitmaps 2.0 implementation.

Tankmaster Finesmith jaeger_Reg at hotmail.com
Sun Sep 4 11:21:59 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/347/#review1011
-----------------------------------------------------------


Looks good in my initial test.  I have pushed this patch to Firestorm to get more feedback from the users.  

I modified the XML slightly to:
1) give more room between the radio button elements for future translations (other languages often need more room)
2) added tool tips to each selection to give more clarity
3) changed "Local" to "Computer"
4) moved the radio buttons down by 4 pixels to better align in the center of the bar (might be a FS only issue)

You can see my commit at:
 http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/32a826ff98e8
You can also pull our XML file to do a diff on from:
 http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/file/32a826ff98e8/indra/newview/skins/default/xui/en/floater_texture_ctrl.xml

You are welcome to pick up any or all of these changes

- Tankmaster


On Sept. 4, 2011, 8:22 a.m., Vaalith Jinn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/347/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2011, 8:22 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Local Bitmaps is a mechanism to locally load images into the viewer, track them and optionally (per each image)
> have it check if the image has been overwritten locally and if so - update it in the viewer and inworld.
> 
> This change affects the texture picker - adding radio checks that let the user choose between the "Inventory" (regular inventory) and "Local" tabs (list of locally added files).
> 
> * Only tested this myself, as opposed to the previous implementation which has been live for, uh, a year,
> this one is completely new, written mostly from scratch and uses different mechanisms
> 
> ** This is strictly a review/alpha version, but i'd appreciate feedback on it before i finalize it.
> 
> 
> This addresses bug STORM-64.
>     http://jira.secondlife.com/browse/STORM-64
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 8da01486a36a 
>   indra/newview/CMakeLists.txt 8da01486a36a 
>   indra/newview/lllocalbitmaps.h PRE-CREATION 
>   indra/newview/lllocalbitmaps.cpp PRE-CREATION 
>   indra/newview/lltexturectrl.h 8da01486a36a 
>   indra/newview/lltexturectrl.cpp 8da01486a36a 
>   indra/newview/llviewertexturelist.h 8da01486a36a 
>   indra/newview/llwearable.h 8da01486a36a 
>   indra/newview/llwearable.cpp 8da01486a36a 
>   indra/newview/skins/default/xui/en/floater_texture_ctrl.xml 8da01486a36a 
> 
> Diff: http://codereview.secondlife.com/r/347/diff
> 
> 
> Testing
> -------
> 
> Texture/Sculptmap/Avatar Layer show.
> Texture/Sculptmap/Avatar Layer update.
> Multiple sculpties update.
> 
> 
> Thanks,
> 
> Vaalith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110904/06c9b033/attachment.htm 


More information about the opensource-dev mailing list