[opensource-dev] Review Request: STORM-1578, STORM-1589: Away improvements

[Oz Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/473/
-----------------------------------------------------------

Review request for Viewer.


Summary
-------

Remove the viewer side automatic logout after extended away time.
Note, however, that the server still logs you out after 30 minutes
away: see SVC 7251.
Allow more time (10 seconds vs 2 seconds) after initiating Away status
during which mouse movements do not remove the Away status.


This addresses bug storm-1578.
    http://jira.secondlife.com/browse/storm-1578


Diffs
-----

  indra/newview/app_settings/settings.xml ffa9260a0b27 
  indra/newview/llagent.h ffa9260a0b27 
  indra/newview/llagent.cpp ffa9260a0b27 
  indra/newview/llappviewer.cpp ffa9260a0b27 
  indra/newview/llviewerjoystick.cpp ffa9260a0b27 
  indra/newview/llviewerwindow.cpp ffa9260a0b27 

Diff: http://codereview.secondlife.com/r/473/diff


Testing
-------

I've done local testing with these changes.

For some reason I can't figure out, adding just these changes to the then-current viewer-development tip increased the likelihood (to something very close to 100%) of crashing due to problems with multi-threaded curl use.   There is a separate proposed fix for that (see STORM-1562), and integrating that proposed fix eliminated the problem and allowed me to test these changes.


Thanks,

Oz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110914/4e715b42/attachment.htm