[opensource-dev] Review Request: STORM-1577 Convert chat translation to third party paid translation services (take 2)

Seth ProductEngine slitovchuk at productengine.com
Thu Sep 15 08:04:03 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/466/#review1027
-----------------------------------------------------------



indra/newview/llfloatertranslationsettings.cpp
<http://codereview.secondlife.com/r/466/#comment1042>

    Probably keystroke callback causes a bug with disabling the 'OK' button after successfull key verification upon moving the input cursor in line editor without actually editing the valid key.



indra/newview/llfloatertranslationsettings.cpp
<http://codereview.secondlife.com/r/466/#comment1043>

    Same problem as above.



indra/newview/tests/lltranslate_test.cpp
<http://codereview.secondlife.com/r/466/#comment1041>

    Tests 6 and 7 look exactly the same. Should do something different perhaps.


- Seth


On Sept. 12, 2011, 5:28 p.m., Vadim ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/466/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2011, 5:28 p.m.)
> 
> 
> Review request for Viewer and Seth ProductEngine.
> 
> 
> Summary
> -------
> 
> Replaced deprecated Google Translate v1 API with Google Translate v2 and Bing Translate APIs.
> 
> Changes after https://codereview.secondlife.com/r/464/:
> * New translation preferences floater layout that supports API key verification.
> * Unit tests.
> 
> 
> This addresses bug STORM-1577.
>     http://jira.secondlife.com/browse/STORM-1577
> 
> 
> Diffs
> -----
> 
>   indra/newview/CMakeLists.txt 8da01486a36a 
>   indra/newview/app_settings/settings.xml 8da01486a36a 
>   indra/newview/llfloaterpreference.h 8da01486a36a 
>   indra/newview/llfloaterpreference.cpp 8da01486a36a 
>   indra/newview/llfloatertranslationsettings.h PRE-CREATION 
>   indra/newview/llfloatertranslationsettings.cpp PRE-CREATION 
>   indra/newview/lltranslate.h 8da01486a36a 
>   indra/newview/lltranslate.cpp 8da01486a36a 
>   indra/newview/llviewerfloaterreg.cpp 8da01486a36a 
>   indra/newview/llviewermessage.cpp 8da01486a36a 
>   indra/newview/skins/default/xui/en/floater_translation_settings.xml PRE-CREATION 
>   indra/newview/skins/default/xui/en/panel_preferences_chat.xml 8da01486a36a 
>   indra/newview/skins/default/xui/en/strings.xml 8da01486a36a 
>   indra/newview/tests/lltranslate_test.cpp PRE-CREATION 
> 
> Diff: http://codereview.secondlife.com/r/466/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vadim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110915/39eab510/attachment.htm 


More information about the opensource-dev mailing list