[opensource-dev] Review Request: STORM-1577 Convert chat translation to third party paid translation services (take 2)

[Seth ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/466/#review1029
-----------------------------------------------------------

Ship it!


Looks good to me.

- Seth


On Sept. 15, 2011, 2:57 p.m., Vadim ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/466/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2011, 2:57 p.m.)
> 
> 
> Review request for Viewer and Seth ProductEngine.
> 
> 
> Summary
> -------
> 
> Replaced deprecated Google Translate v1 API with Google Translate v2 and Bing Translate APIs.
> 
> Changes after https://codereview.secondlife.com/r/464/:
> * New translation preferences floater layout that supports API key verification.
> * Unit tests.
> 
> 
> This addresses bug STORM-1577.
>     http://jira.secondlife.com/browse/STORM-1577
> 
> 
> Diffs
> -----
> 
>   indra/newview/CMakeLists.txt 8da01486a36a 
>   indra/newview/app_settings/settings.xml 8da01486a36a 
>   indra/newview/llfloaterpreference.h 8da01486a36a 
>   indra/newview/llfloaterpreference.cpp 8da01486a36a 
>   indra/newview/llfloatertranslationsettings.h PRE-CREATION 
>   indra/newview/llfloatertranslationsettings.cpp PRE-CREATION 
>   indra/newview/lltranslate.h 8da01486a36a 
>   indra/newview/lltranslate.cpp 8da01486a36a 
>   indra/newview/llviewerfloaterreg.cpp 8da01486a36a 
>   indra/newview/llviewermessage.cpp 8da01486a36a 
>   indra/newview/skins/default/xui/en/floater_translation_settings.xml PRE-CREATION 
>   indra/newview/skins/default/xui/en/panel_preferences_chat.xml 8da01486a36a 
>   indra/newview/skins/default/xui/en/strings.xml 8da01486a36a 
>   indra/newview/tests/lltranslate_test.cpp PRE-CREATION 
> 
> Diff: http://codereview.secondlife.com/r/466/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vadim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110916/6e582bfe/attachment.htm