[opensource-dev] Review Request: Enable legacy viewer C++ tests in indra/test.

Log Linden log at lindenlab.com
Mon Sep 19 12:23:14 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/479/
-----------------------------------------------------------

Review request for Viewer and Nat Goodspeed.


Summary
-------

As part of the Linden Lab automation hackathon, I finally had time to re-enable the tests located in the indra/test directory. These tests are currently not being built or run as part of a standard viewer build and haven't at least since we switched over from subversion. I copied over a few tests from the corresponding server test repository and also fixed some tests that had been rendered unbuildable by various code changes to the viewer. These tests can be disabled from running (but not building) by disabling the standard LL_TESTS cmake configuration variable.

llevents_tut.cpp proved to be an interesting challenge to get to pass on our Linux build servers.  With the Debian Lenny version of the gcc build toolchain, if an exception is located in a different dynamic library (.so) file as the code that is causing the exception, the exception will not be caught. My workaround was borrowed from the llmessage unit tests and expanded upon to allow the monitoring of the string from the caught exception.


Diffs
-----

  indra/test/llevents_tut.cpp 656d988266e8 
  indra/test/llapp_tut.cpp PRE-CREATION 
  indra/CMakeLists.txt 656d988266e8 
  indra/test/CMakeLists.txt 656d988266e8 
  indra/test/io.cpp 656d988266e8 
  indra/test/llhttpclient_tut.cpp 656d988266e8 
  indra/test/lliohttpserver_tut.cpp 656d988266e8 
  indra/test/llsd_new_tut.cpp 656d988266e8 
  indra/test/llsdmessagebuilder_tut.cpp 656d988266e8 
  indra/test/lltemplatemessagebuilder_tut.cpp 656d988266e8 

Diff: http://codereview.secondlife.com/r/479/diff


Testing
-------

I built and ran this code on recent versions of all three platforms with no error. When it failed to build in teamcity, I also built it on a lenny system by hand until I had fixed the exception handling issue, then ran all of the tests 100 times in a row on the same lenny machine with no test failures. The tests have run successfully in Teamcity for each revision since the fix for the exception handling code. 


Thanks,

Log

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110919/063cbbd3/attachment.htm 


More information about the opensource-dev mailing list