[opensource-dev] Review Request: STORM-1828 Sometimes the file character/new archetype.xml is not produced. Sometimes it is present after the viewer is closed. Sometimes it is present and can't be made to fail.

Oz Linden oz at lindenlab.com
Sun Apr 1 04:55:47 PDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/570/#review1206
-----------------------------------------------------------

Ship it!


Ship It!

- Oz Linden


On March 27, 2012, 11:53 a.m., Nicky Perian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/570/
> -----------------------------------------------------------
> 
> (Updated March 27, 2012, 11:53 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> -------
> 
> Sometimes the file character/new archetype.xml is not produced. Sometimes it is present after the viewer is closed. Sometimes it is present and can't be made to fail.
> 
> Intermittent write to character/new archetype.xml from Develop->Avatar->
> Character Tests->Apperance To XML. Add explicit outfile.close() method
> before returning to caller. Add llinfos for file location as a troubleshooting
> aid.
> 
> 
> This addresses bug STORM-1828.
>     http://jira.secondlife.com/browse/STORM-1828
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 6943d3e9deb7 
>   indra/newview/llvoavatar.cpp 6943d3e9deb7 
> 
> Diff: http://codereview.secondlife.com/r/570/diff/diff
> 
> 
> Testing
> -------
> 
> First checked that the patch did no harm.
> Second seems more stable after running with the patch applied.
> 
> 
> Thanks,
> 
> Nicky Perian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120401/d45a7eea/attachment-0001.htm 


More information about the opensource-dev mailing list