[opensource-dev] Review Request: STORM-1828 Sometimes the file character/new archetype.xml is not produced. Sometimes it is present after the viewer is closed. Sometimes it is present and can't be made to fail.

Nicky Perian nickyperian at yahoo.com
Tue Apr 3 18:37:19 PDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/570/
-----------------------------------------------------------

(Updated April 3, 2012, 6:37 p.m.)


Review request for Viewer and Oz Linden.


Description
-------

Sometimes the file character/new archetype.xml is not produced. Sometimes it is present after the viewer is closed. Sometimes it is present and can't be made to fail.

Intermittent write to character/new archetype.xml from Develop->Avatar->
Character Tests->Apperance To XML. Add explicit outfile.close() method
before returning to caller. Add llinfos for file location as a troubleshooting
aid.


This addresses bug STORM-1828.
    http://jira.secondlife.com/browse/STORM-1828


Diffs (updated)
-----

  doc/contributions.txt 6943d3e9deb7 
  indra/newview/llvoavatar.cpp 6943d3e9deb7 

Diff: http://codereview.secondlife.com/r/570/diff/diff


Testing (updated)
-------

First checked that the patch did no harm.
Second seems more stable after running with the patch applied.
*****
Tested the file write in a development and installed configurations. Repeated Develop->Avatar->
Character Tests->Apperance To XML several times while watching the time file time stamp.
No failures were noted. 


Thanks,

Nicky Perian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120404/dcfe21f1/attachment.htm 


More information about the opensource-dev mailing list