[opensource-dev] Review Request: STORM-1453: Prevent unintended 10L sale

Kadah Coba kadah.coba at gmail.com
Fri Apr 6 11:16:48 PDT 2012



> On April 6, 2012, 9:03 a.m., Oz Linden wrote:
> > indra/newview/llpanelpermissions.cpp, lines 486-487
> > <http://codereview.secondlife.com/r/365/diff/5/?file=6730#file6730line486>
> >
> >     make the comments match the code

For what its worth, I've made the comments more verbose.


- Kadah


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review910
-----------------------------------------------------------


On July 22, 2011, 11:47 a.m., Kadah Coba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> -----------------------------------------------------------
> 
> (Updated July 22, 2011, 11:47 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> -------
> 
> This change makes it so setting an object for sale or modifying the price or sale type requires explicitly applying the changes. Default behavior before this patch is all sale info is committed to sim on change. After this patch the sale info will only get set or modified after hitting a "mark for sale" button. There is no change to removing an object from sale, unchecking "For sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/storm-1453
> 
> 
> This addresses bug STORM-1453.
>     http://jira.secondlife.com/browse/STORM-1453
> 
> 
> Diffs
> -----
> 
>   indra/newview/llpanelpermissions.cpp UNKNOWN 
>   indra/newview/llsidepaneltaskinfo.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/365/diff/diff
> 
> 
> Testing
> -------
> 
> (I had stuff here but Review Board kept deleting it every time I tried to save.)
> 
> 
> Thanks,
> 
> Kadah Coba
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120406/cb853542/attachment.htm 


More information about the opensource-dev mailing list