[opensource-dev] Review Request: Remove requests for unused and non-existant ParcelMediaURLFilterList cap

[Kadah Coba]

> On April 17, 2012, 10:42 a.m., Kadah Coba wrote:
> > Ship It!

Looks good. But when I was looking over this for STORM-1843, I noticed that the calling function, LLViewerParcelMgr::processParcelProperties, would have to have been getting triggered by a server responce to have produced the issue (which I myself have gotten many times). So there is still the larger question of what would be causing so many ParcelProperties responses.
There is also a lot of related and unused old code behind "ParcelMediaURLFilter" that could be scrubbed as well.


- Kadah


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/576/#review1212
-----------------------------------------------------------


On April 17, 2012, 7:33 a.m., Oz Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/576/
> -----------------------------------------------------------
> 
> (Updated April 17, 2012, 7:33 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> -------
> 
> Removed the requests and the associated callbacks
> 
> 
> This addresses bug storm-1838.
> 
> 
> Diffs
> -----
> 
>   indra/newview/llviewerparcelmgr.h acfb0781d850 
>   indra/newview/llviewerparcelmgr.cpp acfb0781d850 
>   indra/newview/llviewerregion.cpp acfb0781d850 
> 
> Diff: http://codereview.secondlife.com/r/576/diff/diff
> 
> 
> Testing
> -------
> 
> Ran the resulting test viewer with no apparent ill effect.
> 
> 
> Thanks,
> 
> Oz Linden
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120417/0b02b226/attachment.htm