[opensource-dev] Review Request: STORM-1893: 'share' function (in friends-list) doesn't bring up the residents' IM window when it's minimized

Oz Linden oz at lindenlab.com
Thu Aug 16 07:46:15 PDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/589/#review1245
-----------------------------------------------------------



indra/newview/llavataractions.cpp
<http://codereview.secondlife.com/r/589/#comment1138>

    Shouldn't this check for a null return?


- Oz Linden


On July 2, 2012, 3:59 p.m., MartinRJ Fayray wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/589/
> -----------------------------------------------------------
> 
> (Updated July 2, 2012, 3:59 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> -------
> 
> Repository is here: https://bitbucket.org/MartinRJ/storm-1893
> 
> I just added two calls to show() and setVisible() in LLAvatarActions::share to bring the IM window to front even when it's minimized.
> 
> 
> This addresses bug STORM-1893.
>     https://jira.secondlife.com/browse/STORM-1893
> 
> 
> Diffs
> -----
> 
>   indra/newview/llavataractions.cpp 4d9106153407 
> 
> Diff: http://codereview.secondlife.com/r/589/diff/diff
> 
> 
> Testing
> -------
> 
> Please see the test plan in the Jira.
> 
> 
> Thanks,
> 
> MartinRJ Fayray
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120816/ac6e9429/attachment.htm 


More information about the opensource-dev mailing list