[opensource-dev] Review Request: STORM-1793 1) Treat all mini-map altitudes above 1020 m as the same height 2) Improve z-level accuracy
Oz Linden
oz at lindenlab.com
Mon Feb 6 10:33:18 PST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/545/#review1163
-----------------------------------------------------------
Ship it!
indra/newview/llworld.cpp
<http://codereview.secondlife.com/r/545/#comment1111>
When wrapping conditions across lines, I find it more clear to put the operators on the left:
if ( condition1
&& condition2
...
- Oz Linden
On Feb. 3, 2012, 8:51 a.m., Jonathan Yap wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/545/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2012, 8:51 a.m.)
>
>
> Review request for Viewer.
>
>
> Description
> -------
>
> The SL simulator has recently been fixed so that the CoarseLocationUpdate message properly returns 255 for all altitudes above 1020 meters.
>
> The code for the mini-map, in drawing the agent locations for equal, above or below needs to take this into account. It currently does not.
>
> The routine that returns who is nearby can be enhanced to scan the character list and use that position data. This gives an accurate z-level value, even when above 1020m.
>
> In the case where the relative Z value between you and another avatar is unknown display an X on the mini-map.
>
>
> This addresses bug STORM-1793.
> http://jira.secondlife.com/browse/STORM-1793
>
>
> Diffs
> -----
>
> doc/contributions.txt 0010858de5a1
> indra/newview/llnetmap.cpp 0010858de5a1
> indra/newview/llworld.cpp 0010858de5a1
> indra/newview/llworldmapview.h 0010858de5a1
> indra/newview/llworldmapview.cpp 0010858de5a1
>
> Diff: http://codereview.secondlife.com/r/545/diff/diff
>
>
> Testing
> -------
>
> See test plan in jira
>
>
> Thanks,
>
> Jonathan Yap
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120206/306ee543/attachment-0001.htm
More information about the opensource-dev
mailing list