[opensource-dev] Review Request: STORM-1807 Play animation floater 2nd play button active while animation is playing

[Jonathan Yap]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/552/
-----------------------------------------------------------

(Updated Feb. 18, 2012, 5:24 a.m.)


Review request for Viewer.


Changes
-------

Fix possible compiling issue on Linux


Description
-------

Part 1
Open your inventory's Animations folder
Double click on an animation
Click on Play Inworld: Play Inworld is replaced by a Stop button

Observed behavior: It is still possible to click on Play Locally, which also is replaced by a Stop button. Clicking on either Stop works and resets the floater back to having both Play buttons showing.

Expected behavior: When one of the play buttons is clicked the other should be disabled.


Part 2
1 .To reproduce, get any non looping animation. ie, one that plays once and then stops.
2. Right click in inventory and select play in world.
3. The animation dialog appears with play locally and play in world buttons.
4. When the animation is playing, the play in world button changes to a stop button, which makes it stop playing.
Now here's the problem:
5. When the animation finishes of it's own accord, the button still says stop. To play it again, you have to click the redundant stop button to make it change back to Play in World, then click that to play again.

Expected behaviour, is that when an animation finishes, the stop button should change back of it's own accord. 


This addresses bug STORM-1807.
    http://jira.secondlife.com/browse/STORM-1807


Diffs (updated)
-----

  doc/contributions.txt 0a41a8750048 
  indra/newview/llinventorybridge.cpp 0a41a8750048 
  indra/newview/llpreviewanim.h 0a41a8750048 
  indra/newview/llpreviewanim.cpp 0a41a8750048 
  indra/newview/skins/default/xui/en/floater_preview_animation.xml 0a41a8750048 

Diff: http://codereview.secondlife.com/r/552/diff/diff


Testing
-------

See test plan in jira.


Thanks,

Jonathan Yap

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120218/bba97e8c/attachment-0001.htm