[opensource-dev] Review Request: STORM-1808 Indicate ability to build

Jonathan Yap jhwelch at gmail.com
Sun Feb 19 13:22:36 PST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/553/
-----------------------------------------------------------

(Updated Feb. 19, 2012, 1:22 p.m.)


Review request for Viewer.


Changes
-------

Fix wrong name in XML file.


Description
-------

When standing in a parcel it would be helpful to have a graphical indication in the UI if you are able to build/rez.

The icon in the (mini) location bar shows parcel properties, not what is available to you as parcel owner or as a member of a group that has rezzing enabled as one of your group roles.

Suggested solution: Gray out the build button if it is present on the toolbar, just like the Speak button is grayed out if voice is not available.


This addresses bug STORM-1808.
    http://jira.secondlife.com/browse/STORM-1808


Diffs (updated)
-----

  doc/contributions.txt 0a41a8750048 
  indra/newview/app_settings/commands.xml 0a41a8750048 
  indra/newview/llagent.cpp 0a41a8750048 
  indra/newview/lltoolmgr.h 0a41a8750048 
  indra/newview/lltoolmgr.cpp 0a41a8750048 

Diff: http://codereview.secondlife.com/r/553/diff/diff


Testing
-------

See test plan in jira.

I also searched the xml files to be sure no other calls to LLAgent::isActionAllowed were being made.


Thanks,

Jonathan Yap

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120219/3d90d719/attachment.htm 


More information about the opensource-dev mailing list