[opensource-dev] Review Request: VWR-28087: When I upload a texture, the "preview as" dropdown in the preview window is hidden under the texture

Jonathan Yap jhwelch at gmail.com
Thu Jan 12 01:31:09 PST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/532/#review1137
-----------------------------------------------------------



indra/newview/skins/default/xui/en/floater_image_preview.xml
<http://codereview.secondlife.com/r/532/#comment1102>

    Why are you changing this by 25 when in the other two locations you are only increasing by 20?


- Jonathan Yap


On Jan. 12, 2012, 12:23 a.m., Lance Corrimal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/532/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2012, 12:23 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> -------
> 
> At some point in the last 8 months the height of image previews in the upload preview floater was increased by 20, without adapting the actual floater, leading to VWR-28087.
> This small patch fixes that by adapting the preview floater to the new height.
> 
> 
> This addresses bug VWR-28087.
>     http://jira.secondlife.com/browse/VWR-28087
> 
> 
> Diffs
> -----
> 
>   indra/newview/skins/default/xui/en/floater_image_preview.xml 4982ab91ef6a 
> 
> Diff: http://codereview.secondlife.com/r/532/diff/diff
> 
> 
> Testing
> -------
> 
> tested with release viewer 3.2.5 and my own TPV, works fine.
> 
> 
> Thanks,
> 
> Lance Corrimal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120112/7d209123/attachment.htm 


More information about the opensource-dev mailing list