[opensource-dev] Review Request: STORM-1793 Viewer needs to treat all mini-map altitudes above 1020 m as the same height

[Jonathan Yap]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/534/
-----------------------------------------------------------

Review request for Viewer.


Description
-------

The SL simulator has recently been fixed so that the CoarseLocationUpdate message properly returns 255 for all altitudes above 1020 meters.

The code for the mini-map, in drawing the agent locations for equal, above or below needs to take this into account. It currently does not.

LLNetMap::globalPosToView() computes a relative position:

LLVector3d relative_pos_global = global_pos - gAgentCamera.getCameraPositionGlobal();

The Z value needs to take the global camera pos, and slam anything above 1020 to be 1020, and all our problems will be solved.

Also, new artwork, an X, needs to be displayed for the case of avatar B and your camera position being at or above 1020m, where the relative height positions are unknown.


This addresses bug STORM-1793.
    http://jira.secondlife.com/browse/STORM-1793


Diffs
-----

  doc/contributions.txt 4982ab91ef6a 
  indra/newview/llnetmap.cpp 4982ab91ef6a 
  indra/newview/llworldmapview.h 4982ab91ef6a 
  indra/newview/llworldmapview.cpp 4982ab91ef6a 
  indra/newview/skins/default/textures/map_avatar_unknown_32.tga 4982ab91ef6a 

Diff: http://codereview.secondlife.com/r/534/diff/diff


Testing
-------

See test plan in jira


Thanks,

Jonathan Yap

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120116/c2a7309e/attachment.htm