[opensource-dev] Review Request: STORM-1795 Ad-hoc messages are received even when "Only friends and groups can call or IM me"
Jonathan Yap
jhwelch at gmail.com
Fri Jan 20 11:27:40 PST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/536/
-----------------------------------------------------------
(Updated Jan. 20, 2012, 11:27 a.m.)
Review request for Viewer.
Changes
-------
Fix misspelled variable name.
Description
-------
With avatar A: check on Preferences->Privacy->Only friends and groups can call or IM me
Get together with:
Avatar B (not a friend of A)
Avatar C (a friend of A)
Using avatar B establish an ad-hoc chat with A and C and write a message
Observed result: Avatar A and C receive the message
Expected result: Only avatar C receives the message
This addresses bug STORM-1795.
http://jira.secondlife.com/browse/STORM-1795
Diffs (updated)
-----
doc/contributions.txt 4982ab91ef6a
indra/newview/llimview.cpp 4982ab91ef6a
Diff: http://codereview.secondlife.com/r/536/diff/diff
Testing
-------
Created a 3-way ad-hoc session per Description. Avatar C does not receive the message, but does get an ad-hoc session icon, even when B initiates the ad-hoc session. I think this is correct behavior because C may change their preferences to allow messages from everyone. You do not want to reject the session (that was handled by a different jira recently for blocked residents), only suppress messages.
Thanks,
Jonathan Yap
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120120/fc293364/attachment.htm
More information about the opensource-dev
mailing list