[opensource-dev] Review Request: STORM-1795 Ad-hoc messages are received even when "Only friends and groups can call or IM me"

Jonathan Yap jhwelch at gmail.com
Mon Jan 23 14:45:34 PST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/536/
-----------------------------------------------------------

(Updated Jan. 23, 2012, 2:45 p.m.)


Review request for Viewer.


Changes
-------

Slight reformatting/logic change.  I think this is a good compromise between my too-wordy multi-line if statement and Oz's compact everything into one if statement approach.  This is readable and doesn't waste space.


Description
-------

With avatar A: check on Preferences->Privacy->Only friends and groups can call or IM me

Get together with:
Avatar B (not a friend of A)
Avatar C (a friend of A)

Using avatar B establish an ad-hoc chat with A and C and write a message

Observed result: Avatar A and C receive the message
Expected result: Only avatar C receives the message


This addresses bug STORM-1795.
    http://jira.secondlife.com/browse/STORM-1795


Diffs (updated)
-----

  doc/contributions.txt 4982ab91ef6a 
  indra/newview/llimview.cpp 4982ab91ef6a 

Diff: http://codereview.secondlife.com/r/536/diff/diff


Testing
-------

See test plan in jira


Thanks,

Jonathan Yap

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120123/477d6936/attachment.htm 


More information about the opensource-dev mailing list