[opensource-dev] Review Request: STORM-1878: Blocking an avatar does not derender worn lights

[MartinRJ Fayray]

> On June 18, 2012, 12:02 p.m., David Parks wrote:
> > No issues with the code so far, but from inspection I don't think this code will block lights for an avatar that is already muted -- it only blocks lights at the moment you mute another avatar.  You'll need to add a check to LLPipeline::setLight that verifies the object is not on the mute list before inserting the object onto gPipeline.mLights.

Lights from an avatar that is already muted were blocked before, already. The adressed issue was that you had to teleport away and back to get rid of the lights.
I can't 100% tell that I'd really understand the magic behind, but that already worked before.
With this fix, the lights disappear instantly (without the need to teleport away/then back).


- MartinRJ


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/583/#review1230
-----------------------------------------------------------


On June 18, 2012, 11:04 a.m., MartinRJ Fayray wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/583/
> -----------------------------------------------------------
> 
> (Updated June 18, 2012, 11:04 a.m.)
> 
> 
> Review request for Viewer and David Parks.
> 
> 
> Description
> -------
> 
> An avatar currently gets derendered/invisible when the user blocks it.
> The local lights attached to that avatar have to become erased too.
> Repository: https://bitbucket.org/MartinRJ/storm-1878
> 
> 
> This addresses bug STORM-1878.
>     https://jira.secondlife.com/browse/STORM-1878
> 
> 
> Diffs
> -----
> 
>   indra/newview/llmutelist.cpp 29143d1fc6fa 
>   indra/newview/pipeline.h 29143d1fc6fa 
>   indra/newview/pipeline.cpp 29143d1fc6fa 
> 
> Diff: http://codereview.secondlife.com/r/583/diff/diff
> 
> 
> Testing
> -------
> 
> Tested with 1-6 local attached lights on the target avatar.
> Blocking/muting the avatar also disabled the attached lights in all tests successfully.
> 
> 
> Thanks,
> 
> MartinRJ Fayray
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120618/fe7ffe8a/attachment.htm