[opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

[Jonathan Yap]

> On None, Tobias Roth wrote:
> > Ship It!

Please add the viewer version you are working from to the Branch field and STORM-468 to the Bugs field in this review request.

In addition to the objections LL has posted I found two bugs when I worked on this code in January.

Have both of these issues been resolved?

There are two significant problems with this code:
1) Agent A starts to align 500 cubes and clicks on the ground, deselecting them all.
The alignment finishes, but Agent B, who has been watching, does not see any change to the 500 cubes until Agent A moves them slightly.

2) An internal variable that keeps track of an alignment in progress is not always reset, or it maybe the alignment thread is not closed properly. This results in no longer being able to use the align function.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/543/#review1155
-----------------------------------------------------------


On March 2, 2012, 12:30 a.m., Tobias Roth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/543/
> -----------------------------------------------------------
> 
> (Updated March 2, 2012, 12:30 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> -------
> 
> Qarls Aligning tool ported over from Nirans Viewer for code review
> 
> 
> Diffs
> -----
> 
>   indra/newview/llfloatertools.cpp b91d07f8fad9 
>   indra/newview/qtoolalign.h PRE-CREATION 
>   indra/newview/qtoolalign.cpp PRE-CREATION 
>   indra/newview/skins/default/xui/de/floater_tools.xml b91d07f8fad9 
>   indra/newview/skins/default/xui/en/floater_tools.xml b91d07f8fad9 
> 
> Diff: http://codereview.secondlife.com/r/543/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tobias Roth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120621/325576ec/attachment.htm