[opensource-dev] Review Request: STORM-1818: Fix for viewer crash when entering chars other than [a-z0-9-_. ] into the grid-selection combo.

Lance Corrimal Lance.Corrimal at eregion.de
Sat Mar 24 11:20:13 PDT 2012



> On March 24, 2012, 8:08 a.m., Lance Corrimal wrote:
> > I would like to point out that having all those linden-internal grids in there is utterly useless unless you are inside the linden lab network. How about adding a proper grid manager that supports actually accessible grids instead?
> 
> MartinRJ Fayray wrote:
>     @Lance this is only a review of my crash fix, no public discussion. It is only about this severe bug (abnormal program termination). This is not a public user group meeting where we discuss features, please bear in mind that you just demanded me - a volunteer contributor - to add a proper grid manager:
>     "How about adding a proper grid manager"?
>     The answer is: no! Of course not!

I didn't "demand" anything from you, I was just suggesting something. Calm down a bit.


- Lance


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/563/#review1179
-----------------------------------------------------------


On March 24, 2012, 5:33 a.m., MartinRJ Fayray wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/563/
> -----------------------------------------------------------
> 
> (Updated March 24, 2012, 5:33 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> -------
> 
> FIX FOR STORM-1818 (https://jira.secondlife.com/browse/storm-1818) "Abnormal program termination when I enter an URL to the grid selection combobox (login-screen) and press enter."
> 
> Repository with fix: https://bitbucket.org/MartinRJ/storm-1818/
> 
> About:
> When entering a malformed grid dns address, the viewer needs to catch the malformed address. Currently it throws an error in a subroutine of the grid-address-handling (llviewernetwork.cpp, function 'addGrid') and crashes without warning due to a thrown error ("throw LLInvalidGridName(grid);").
> 
> This fix adds code to:
> notifications.xml (a warning message text/notification: "IllegalGridName"),
> llviewernetwork.h (a function which checks whether a given grid exists, by name (string): bool getGridExists),
> llpanellogin.cpp (an include for llviewernetwork.h, and a check against an invalid grid dns address in function onSelectServer).
> 
> Todo: Maybe edit the notification message, and update the language files.
> 
> 
> This addresses bug STORM-1818.
>     http://jira.secondlife.com/browse/STORM-1818
> 
> 
> Diffs
> -----
> 
>   indra/newview/llpanellogin.cpp acfb0781d850 
>   indra/newview/llviewernetwork.h acfb0781d850 
>   indra/newview/skins/default/xui/en/notifications.xml acfb0781d850 
> 
> Diff: http://codereview.secondlife.com/r/563/diff/diff
> 
> 
> Testing
> -------
> 
> Test plan: Insert a malformed grid dns address (e.g. http://grid.francogrid.org:8002 which works with some TPVs) into the grid selection combo on the login screen.
> Expected behaviour: a popup shows up, informing about the malformed address, and the grid selection combo swaps back to the default grid (Agni).
> 
> 
> Thanks,
> 
> MartinRJ Fayray
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120324/d0ae8bd4/attachment-0001.htm 


More information about the opensource-dev mailing list