[opensource-dev] Review Request: STORM-1812 Music stream does not always restart after teleporting

[Jonathan Yap]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/556/
-----------------------------------------------------------

(Updated May 31, 2012, 4:03 a.m.)


Review request for Viewer.


Changes
-------

Added callback for teleport start and reworked the logic slightly, which should fix timing issues.


Description
-------

The music stream does not restart if you teleport within the same parcel.


This addresses bug STORM-1812.
    http://jira.secondlife.com/browse/STORM-1812


Diffs (updated)
-----

  doc/contributions.txt 0a41a8750048 
  indra/newview/llpanelnearbymedia.cpp 0a41a8750048 
  indra/newview/llvieweraudio.h 0a41a8750048 
  indra/newview/llvieweraudio.cpp 0a41a8750048 
  indra/newview/llviewermessage.h 0a41a8750048 
  indra/newview/llviewermessage.cpp 0a41a8750048 
  indra/newview/llviewerparcelmgr.h 0a41a8750048 
  indra/newview/llviewerparcelmgr.cpp 0a41a8750048 

Diff: http://codereview.secondlife.com/r/556/diff/diff


Testing
-------

See Test Plan in jira.

During early investigation and testing of this fix there were times the play button became grayed out.  I have not been able to reproduce this condition recently.


Thanks,

Jonathan Yap

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120531/967fc505/attachment.htm