[opensource-dev] Review Request: Fix for STORM-1854.
Log Linden
log at lindenlab.com
Fri Nov 30 17:17:45 PST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/609/
-----------------------------------------------------------
Review request for Viewer.
Description
-------
This is a fix for STORM-1854. It prevents an assert failure that happens during viewer startup on linux systems with a sufficiently new version of the fontconfig library (I think fontconfig 1.9). It should not impact mac or windows because those platforms do not use llwindowsdl.cpp file, which was the only file changed.
This addresses bug STORM-1854.
http://jira.secondlife.com/browse/STORM-1854
Diffs
-----
indra/llwindow/llwindowsdl.cpp UNKNOWN
Diff: http://codereview.secondlife.com/r/609/diff/
Testing
-------
This change builds successfully on all three platforms (Teamcity). I have verified that the startup error no longer occurs on Ubuntu 12.10. Ideally we would test that Linux systems with older versions of fontconfig can also still start the viewer, but I don't have easy access to one of those.
Thanks,
Log Linden
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20121201/8f250d6b/attachment.htm
More information about the opensource-dev
mailing list