[opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

[MartinRJ Fayray]

> On Sept. 11, 2012, 3:24 a.m., Lance Corrimal wrote:
> > Tested it in a viewer-development based build. Works fine for scripts in my inv as well as for scripts in objects.
> > One thing though, hitting enter when entering the line number shgould be enough, clicking the ok button is a bit of a pain.

I wanted to keep the design close to the 'search' function. I know you are right about the Enter key, and I am missing that feature in the Search box, as well.
It would be cool if we could add that to both, the 'search' and the 'goto' window. Let's talk at the next UG meeting with Oz about that.
Thank you much for testing this / and your feedback.


- MartinRJ


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/596/#review1251
-----------------------------------------------------------


On Sept. 11, 2012, 2:39 a.m., MartinRJ Fayray wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/596/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2012, 2:39 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> -------
> 
> Repository is here: https://bitbucket.org/MartinRJ/bug-59
> 
> I more or less cloned the search-function and modified the floater via xml (new file: floater_goto_line.xml) to fit for a 'go to line' floater.
> Also I added a callback to prevalidate the input in the 'go to line' line-editor, so that only numbers can be entered into it.
> 
> 
> This addresses bug BUG-59.
>     https://jira.secondlife.com/browse/BUG-59
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 7ae099f5a764 
>   indra/newview/llpreviewscript.h 7ae099f5a764 
>   indra/newview/llpreviewscript.cpp 7ae099f5a764 
>   indra/newview/skins/default/xui/en/floater_goto_line.xml PRE-CREATION 
>   indra/newview/skins/default/xui/en/panel_script_ed.xml 7ae099f5a764 
> 
> Diff: http://codereview.secondlife.com/r/596/diff/diff
> 
> 
> Testing
> -------
> 
> Tested on my local PC with a modded "3.3.4-release3" version.
> Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go to line', enter a number less than 300 into the 'Go to' - field. Expected result: the cursor jumps to the entered line number (column 0).
> Repeat the test with a script inside an object's content.
> 
> 
> Thanks,
> 
> MartinRJ Fayray
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120912/e680334c/attachment.htm