[opensource-dev] Review Request: Added a UI field to display group count in the groups floater, plus code to update it. This adresses BUG-81.
Lance Corrimal
Lance.Corrimal at eregion.de
Thu Sep 13 23:36:59 PDT 2012
> On Sept. 13, 2012, 11:23 a.m., Oz Linden wrote:
> > indra/newview/skins/default/xui/en/panel_people.xml, line 451
> > <http://codereview.secondlife.com/r/598/diff/1/?file=7969#file7969line451>
> >
> > We think in would be clearer to use a message like:
> >
> > You belong to [COUNT] groups, and can join [REMAINING] more.
> >
> > where REMAINING is the maximum minus COUNT.
>
> Lance Corrimal wrote:
> I have a new version in https://bitbucket.org/LanceCorrimal/storm-1910/changeset/275e5ab93bfa but for some reason CR does not let me upload a diff...
Latest version: http://dolphinsource.eregion.de/storm-1910/changeset/72f674a51acc/
Why can't I update the diff in this CR request anymore?
- Lance
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/598/#review1257
-----------------------------------------------------------
On Sept. 13, 2012, 2:04 p.m., Lance Corrimal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/598/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2012, 2:04 p.m.)
>
>
> Review request for Viewer.
>
>
> Description
> -------
>
> This patch adds the number of groups you're in to the bottom of the group list.
>
>
> This addresses bug BUG-81.
> http://jira.secondlife.com/browse/BUG-81
>
>
> Diffs
> -----
>
> indra/newview/llpanelpeople.cpp 40296d1901e6
> indra/newview/skins/default/xui/en/panel_people.xml 40296d1901e6
>
> Diff: http://codereview.secondlife.com/r/598/diff/
>
>
> Testing
> -------
>
> Testing done in the latest dolphin viewer beta, and in a recent viewer-development fork. The actual implementation has been in Marine Kelleys RLV for a while, and has been adapted with her permission.
>
>
> Thanks,
>
> Lance Corrimal
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120914/7a738f57/attachment-0001.htm
More information about the opensource-dev
mailing list