[opensource-dev] BUG-1610: Current development source does not build with glibc 2.17

[Cinder Roxley]

Here's a better fix than the other one I posted earlier… Don't use 
extern "C".

------------START-------------

diff --git a/indra/lscript/lscript_compile/indra.l 
b/indra/lscript/lscript_compile/indra.l
--- a/indra/lscript/lscript_compile/indra.l
+++ b/indra/lscript/lscript_compile/indra.l
@@ -61,11 +61,9 @@

  #define ECHO do { } while (0)

-#if defined(__cplusplus)
-extern "C" { int yylex( void ); }
-extern "C" { int yyparse( void ); }
-extern "C" { int yyerror(const char *fmt, ...); }
-#endif
+int yylex( void );
+int yyparse( void );
+int yyerror(const char *fmt, ...);

  %}

diff --git a/indra/lscript/lscript_compile/indra.y 
b/indra/lscript/lscript_compile/indra.y
--- a/indra/lscript/lscript_compile/indra.y
+++ b/indra/lscript/lscript_compile/indra.y
@@ -2,10 +2,6 @@
  	#include "linden_common.h"
  	#include "lscript_tree.h"

-    #ifdef __cplusplus
-    extern "C" {
-    #endif
-
  	int yylex(void);
  	int yyparse( void );
  	int yyerror(const char *fmt, ...);
@@ -19,10 +15,6 @@
  	#pragma warning (disable : 4702) // warning C4702: unreachable code
  	#pragma warning( disable : 4065 )	// warning: switch statement 
contains 'default' but no 'case' labels
  	#endif
-
-    #ifdef __cplusplus
-    }
-    #endif
  %}

  %union

--------------END---------------
Kind regards,
Cinder Roxley

> On 9 Feb 2013, at 12:40, Lance Corrimal wrote:
>
>> This is where I'm stuck now:
>>
>>
>> [  363s] /home/abuild/rpmbuild/BUILD/viewer-development/build-linux-
>> i686/lscript/lscript_compile/indra.y.hpp:176: error: previous 
>> declaration of
>> 'int yyparse()' with 'C++' linkage
>> [  363s] /home/abuild/rpmbuild/BUILD/viewer-
>> development/indra/lscript/lscript_compile/indra.l:61: error: 
>> conflicts with
>> new declaration with 'C' linkage
>>
>>
>>
>> any ideas?
>>
>>
>> cheers,
>> LC
>>
>>
>> Am Samstag, 9. Februar 2013, 13:56:56 schrieb Lance Corrimal:
>>> Am Samstag, 9. Februar 2013, 04:41:10 schrieb Nicky Perian:
>>>> Would you mark BUG-1610 as a duplicate of OPEN-164?
>>>
>>> definitely not. the problem that I had is because glibc 2.17 brings 
>>> the
>>> siginfo_t definition by itself... definitely something else.
>>>
>>> What I'd think suitable would be a "meta bug" that says "Current 
>>> source
>>> fails to build on newer linux distributions" that would depend on 
>>> BOTH
>>> open-164 and bug-1610 and possibly others.
>>>
>>>
>>> besides, I found two more build breakages on openSUSE 12.3 by now...
>>> One might be fixable by just adding the right build requirement tho.
>>>
>>> cheers,
>>> LC
>>>
>>>>> ________________________________
>>>>>
>>>>> From: Lance Corrimal <Lance.Corrimal at eregion.de>
>>>>>
>>>>> To: opensource-dev at lists.secondlife.com
>>>>> Sent: Saturday, February 9, 2013 5:00 AM
>>>>> Subject: Re: [opensource-dev] BUG-1610: Current development source 
>>>>> does
>>>>> not
>>>>> build with glibc 2.17
>>>>>
>>>>> Thanks... I haven't even gotten that far, my build died way 
>>>>> earlier, with
>>>>> a
>>>>> conflicting declaration for siginfo_t, but I got that tackled now.
>>>>>
>>>>>
>>>>> cheers,
>>>>> LC
>>>>>
>>>>> Am Samstag, 9. Februar 2013, 02:34:09 schrieb Nicky Perian:
>>>>>> https://bitbucket.org/NickyP/kokua-3.4.4/commits/22012aa8388a38fb657113
>>>>>> b0
>>>>>> db3 effcfdaa3a8d9
>>>>>>
>>>>>>> ________________________________
>>>>>>>
>>>>>>> From: Lance Corrimal <Lance.Corrimal at eregion.de>
>>>>>>>
>>>>>>> To: opensource-dev at lists.secondlife.com
>>>>>>> Sent: Saturday, February 9, 2013 4:13 AM
>>>>>>> Subject: [opensource-dev] BUG-1610: Current development source 
>>>>>>> does
>>>>>>> not
>>>>>>> build with glibc 2.17
>>>>>>>
>>>>>>> hi,
>>>>>>>
>>>>>>> does anyone have anything for me about fixing up the source to 
>>>>>>> build
>>>>>>> with
>>>>>>> glibc 2.17? I'm getting ready for openSUSE 12.3 here, and that 
>>>>>>> uses
>>>>>>> the
>>>>>>> newer glibc...
>>>>>>>
>>>>>>> for details, see BUG-1610
>>>>>>>
>>>>>>> cheers,
>>>>>>>
>>>>>>> LC
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Policies and (un)subscribe information available here:
>>>>>>> http://wiki.secondlife.com/wiki/OpenSource-Dev
>>>>>>> Please read the policies before posting to keep unmoderated 
>>>>>>> posting
>>>>>>> privileges
>>>>>
>>>>> _______________________________________________
>>>>> Policies and (un)subscribe information available here:
>>>>> http://wiki.secondlife.com/wiki/OpenSource-Dev
>>>>> Please read the policies before posting to keep unmoderated 
>>>>> posting
>>>>> privileges
>>>
>>> _______________________________________________
>>> Policies and (un)subscribe information available here:
>>> http://wiki.secondlife.com/wiki/OpenSource-Dev
>>> Please read the policies before posting to keep unmoderated posting
>>> privileges
>> _______________________________________________
>> Policies and (un)subscribe information available here:
>> http://wiki.secondlife.com/wiki/OpenSource-Dev
>> Please read the policies before posting to keep unmoderated posting 
>> privileges
>
> [yacc-hacc.diff]