[opensource-dev] Review Request: BUG-840: Viewer 3.4.2 (Beta) breaks almost every sliding door script in SL

[MartinRJ Fayray]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/616/#review1299
-----------------------------------------------------------


I just noticed that my fix re-introduces MAINT-2275 Child prims are "left behind" by animated, moving (physical) linksets. I'm looking for a solution.

- MartinRJ Fayray


On Feb. 15, 2013, 1:54 a.m., MartinRJ Fayray wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/616/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2013, 1:54 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> -------
> 
> Fixes missing childprim- position/rotation-updates when the avatar was 20+m away and didn't have the object in view when it was changed.
> 
> 
> Repository: https://bitbucket.org/MartinRJ/bug-840
> 
> 
> This addresses bug BUG-840.
>     https://jira.secondlife.com/browse/BUG-840
> 
> 
> Diffs
> -----
> 
>   indra/newview/lldrawable.cpp fbbee98b7512 
> 
> Diff: http://codereview.secondlife.com/r/616/diff/
> 
> 
> Testing
> -------
> 
> Create an object with two prims, add a script with a listener on PUBLIC_CHANNEL and make it change the relative position of the child prim in the listen-event.
> 
> Move the avatar 20+ m away from the test object, and look in the opposite direction, so that the object is not in view.
> 
> Shout something in public chat so that the child prim changes its relative position.
> 
> Turn around so that the test object is in view again.
> 
> Expected result: the prims visibly changed.
> 
> Without this fix, the child prim would not update its position (or rotation).
> 
> 
> Thanks,
> 
> MartinRJ Fayray
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20130215/d0e88082/attachment.htm