[opensource-dev] Review Request: BUG-1709: Tiny prims do not rescale properly at very high viewer framerates

[Martin Fürholz]

Hello Aleric,

I’m sorry you don’t understand this fix at all.

In short: other cases like the one you mentioned

>still fail to reach the final scale

will be treated in other parts of the code and are parts of other if/else conditions.

MartinRJ
From: Aleric Inglewood 
Sent: Monday, February 18, 2013 4:25 PM
To: MartinRJ Fayray ; Aleric Inglewood ; Viewer 
Subject: Re: [opensource-dev] Review Request: BUG-1709: Tiny prims do not rescale properly at very high viewer framerates

      This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/617/  


I don't understand this "fix" at ALL. It doesn't seem to make any sense :/... What you need is to set the final scale once the distance between destination and current become LESS than the minimum interpolation distance, because then interpolation will never update it anymore. This fix just makes condition true all the time for your test case at your frame rate, but will still fail to reach the final scale when you increase the frame rate (or when the destination scale is simply so close to the start scale that this condition is never true).

- Aleric



On February 17th, 2013, 7:02 p.m., MartinRJ Fayray wrote:

      Review request for Viewer.
      By MartinRJ Fayray.
      Updated Feb. 17, 2013, 7:02 p.m.

      Description 
At high framerates tiny prims get stuck upon interpolation when they are resized via script.
I fixed that by comparing the original scale versus the new target scale (instead of comparing the original scale versus the new interpolated target scale),
in lldrawable.cpp "updateXform" to decide whether a scale change requires an immediate rebuild or not. 

      Testing 
See test plan in Jira: https://jira.secondlife.com/browse/BUG-1709

Repository: https://bitbucket.org/MartinRJ/bug-1709 

      Bugs: BUG-1709 
      Diffs 
        a.. indra/newview/lldrawable.cpp (fbbee98b7512) 
      View Diff
     



--------------------------------------------------------------------------------
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20130218/71bbd1db/attachment.htm