[opensource-dev] Review Request: OPEN-159 / Faster, nicer Depth of Field

Tofu Buzzard c at yotes.com
Fri Jan 11 14:03:49 PST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/615/#review1295
-----------------------------------------------------------



indra/llrender/llpostprocess.cpp
<http://codereview.secondlife.com/r/615/#comment1191>

    Ah, yes.  I added this assert to mark this function as broken because it ate some of my time just unobviously doing nothing.


- Tofu Buzzard


On Jan. 11, 2013, 2 p.m., Tofu Buzzard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/615/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2013, 2 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> -------
> 
> This turns on bilinear filtering of the composited screen buffer used as the colour source for the depth-of-field effect (and its downscaled version).
> This simply means that we can get away with around half as many samples for the same quality of bokeh effect.  The samples we do take express the desired radius more accurately too, so there aren't such glaring delineations in blurredness.
> 
> To celebrate being about twice as fast, I've also upped the maximum fatness of the bokeh effect for situations of extreme defocus.  So typical cases are around twice as fast, and the extreme bokeh situation is around the previous speed but with fatter highlights.
> 
> 
> This addresses bug OPEN-159.
>     http://jira.secondlife.com/browse/OPEN-159
> 
> 
> Diffs
> -----
> 
>   indra/llrender/llpostprocess.cpp UNKNOWN 
>   indra/newview/app_settings/settings.xml UNKNOWN 
>   indra/newview/app_settings/shaders/class1/deferred/postDeferredF.glsl UNKNOWN 
>   indra/newview/pipeline.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/615/diff/
> 
> 
> Testing
> -------
> 
> Been running like this for a while myself...
> 
> 
> Thanks,
> 
> Tofu Buzzard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20130111/6ed8b5f4/attachment.htm 


More information about the opensource-dev mailing list