[sldev] VWR-1396

Nicholaz Beresford nicholaz at blueflash.cc
Tue Jun 26 15:38:30 PDT 2007


I just saw the patch on 1396 (didn't even apply it, was
just looking at the .patch), so I'm not hoping I'm making
a fool of myself but ...

If you enclose the code in an "if (mCurrentOperatingp)"
to check for null pointers, what about the line above that?
"mCurrentOperatingp->deleteData();" wouldn't
when mCurrentOperatingp still crash if it is null?


Nick


Index: linked_lists.h
===================================================================
--- linked_lists.h	(revision 64028)
+++ linked_lists.h	(working copy)
@@ -908,9 +908,12 @@
  		mCurrentp = mCurrentOperatingp->mNextp;

  		mCurrentOperatingp->deleteData();   <<<--- ????
+		if(mCurrentOperatingp)
+		{
+			if (mCurrentOperatingp->mDatap)
+				llerror("This is impossible!", 0);
+			delete mCurrentOperatingp;
+		}
  		mCurrentOperatingp = mCurrentp;
  		mCount--;
  	}


-- 
Second Life from the inside out:
http://nicholaz-beresford.blogspot.com/


More information about the SLDev mailing list