[sldev] Patch submission guidelines?

[Callum Lerwick]

Not to pick on anyone specifically, but this really should go in a patch
submission guide and/or coding standard somewhere.

Could people pleeeeease base their patches in the same directory as the
project tree? :) This is generally considered standard practice. Going
one level in is also acceptable. Going any farther in to the tree makes
it unclear where the patch is supposed to go. It makes it hard on those
of us using automated patch management tools. (Like RPM packaging...)

Like so:

$ diff -ur linden linden.patched
diff -ur linden/indra/llimagej2coj/llimagej2coj.cpp
linden.patched/indra/llimagej2coj/llimagej2coj.cpp
--- linden/indra/llimagej2coj/llimagej2coj.cpp  2007-03-05
13:14:34.000000000 -0600
+++ linden.patched/indra/llimagej2coj/llimagej2coj.cpp  2007-03-07
18:21:39.000000000 -0600
@@ -122,46 +122,61 @@
 
        /* decode the stream and fill the image structure */
        image = opj_decode(dinfo, cio);
-       if(!image)
-       {
-               fprintf(stderr, "ERROR -> j2k_to_image: failed to decode
image!\n");
[...snip...]

I for one would greatly appreciate this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.secondlife.com/pipermail/sldev/attachments/20070307/21f32a9f/attachment-0001.pgp