[sldev] Continuing to play with the code...

Alan Grimes agrimes at speakeasy.net
Thu May 17 22:25:09 PDT 2007


I've been continuing to play with the code...

I've noticed a few more instances where there is some blatant type
confusion, for example there are at least two examples of a variable
declared as bool being sent the -- operator! =P Apparently there was
some design confusion between bool and integer types.

In llselectmgr.cpp I had a real SAY WHAAAT moment:

{
		glLoadIdentity();
		glMultMatrixd(gGLModelView);
}

(Around line 5259)

Why not just glLoadMatrix() it???

I see the same thing in llviewerjoint.cpp line 139

in llviewerdisply.cpp, line 686, there is a redundant loadIdentity,
(this one can be removed because the newly loaded identity matrix is
immediately overwritten by the next function). same notation for
llselectmgr.cpp line 4853.

also lldrawpoolwater.cpp line 248 by line 253, it seems the load
identity is redundant.


kdevelop rules. ;)

I can also generate a class inheritance diagram but I don't know how to
export it. =(


-- 
Opera: Sing it loud! :o(  )>-<


More information about the SLDev mailing list