[sldev] BOOL patch, and test results.

Strife Onizuka blindwanderer at gmail.com
Sat May 19 04:31:02 PDT 2007


All but the last change to indra/lscript/lscript_library/lscript_library.cpp
is bogus.
The first part of indra/lscript/lscript_compile/indra.l is bogus.

Wouldn't it just be easier to just do a compile time define for BOOL, TRUE
and FALSE (and mod the include where they are defined).

On 5/16/07, Paul TBBle Hampson <Paul.Hampson at pobox.com> wrote:
>
> On Wed, May 16, 2007 at 09:30:16PM -0400, Alan Grimes wrote:
> >>> Note 3: All instances of BOOL should be replaced with bool in all
> >>> functions, methods, and global data objects without hesitation or
> delay.
>
> >> Patch or GTFO. :)
>
> > Here it is.
>
> > While I have no intention of maintaining this patch separately from the
> > mainline, it does indeed work.
>
> > Changes:
>
> > - TRUE and FALSE have been removed and replaced with true and false as
> > per "The C++ Programming Language" by Bjarne Stroustrup
>
> > - Many usages of BOOL have been removed. (About half the work remains)
>
> > - Duplicate code has been removed, there were at least two instances of
> > trivial methods being implemented once for bool and again for BOOL.
>
> The change to indra/llcommon/llsdserialize.cpp is bogus.
> The change to indra/llcommon/llpreprocessor.h is bogus.
>
> For the changes to indra/lscript/lscript_library/lscript_library.cpp,
> you're changing documentaition of LScript functions. I _suspect_ this
> is bogus, but haven't looked at other documentation to be sure regarding
> case-sensitivity.
>
> The first hunk of indra/lscript/lscript_compile/indra.l's changes
> is bogus, it's a change to the LScript parser's input language. This
> implies the above documentation change is consistent but bogus. (Is
> LScript case-sensitive?)
>
> The second hunk of indra/lscript/lscript_compile/indra.l is bogus, but
> it's bogus because the original code was assigning FALSE to a U64
> instead of 0, so it's now assigngin false to a U64.
>
> That's what I got from the first 10k lines of the patch.
>
> It might be easier to review if you do the patch module by module,
> starting with newview and working back up towards llcommon.
>
> > - Declaration/implementation conflicts have been fixed. The compiler was
> > accepting conflicts between S32 declarations and BOOL implementations
> > because they were the same type. These have been fixed in this release.
>
> > - Linux build patches are included.
>
> Also, it'd be handy to have it without the Linux build fixes, since
> I've already gotten a working patchset for building.
>
> --
> -----------------------------------------------------------
> Paul "TBBle" Hampson, B.Sc, LPI, MCSE
> On-hiatus Asian Studies student, ANU
> The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361)
> Paul.Hampson at Pobox.com
>
> Of course Pacman didn't influence us as kids. If it did,
> we'd be running around in darkened rooms, popping pills and
> listening to repetitive music.
> -- Kristian Wilson, Nintendo, Inc, 1989
>
> License: http://creativecommons.org/licenses/by/2.1/au/
> -----------------------------------------------------------
>
> _______________________________________________
> Click here to unsubscribe or manage your list subscription:
> /index.html
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/sldev/attachments/20070519/9bf17707/attachment.htm


More information about the SLDev mailing list