[sldev] Reviewing/Fixing the Particle System

[Argent Stonecutter]

>     if (0.f == psd.mMaxAge || psd.mMaxAge > 60.f)    // don't llclamp!
> (zero equals indefinite => 60s)
>     {
>         psd.mMaxAge = 60.f;
>     }

I'm with Strife here. "Zero" means indefinite as in "this particle  
system never terminates while in view". It doesn't mean "60 seconds".

It doesn't matter if the particle system code was rewritten in 1.15  
or not, if it doesn't implement what was previously documented that's  
a bug... this is not behavior that can be changed. There are millions  
of particle systems in second life that this would completely break,  
PLUS coming up with workarounds for this restriction if it was  
implemented would cause more sim and network lag.

I have been following your other code changes, and most of them look  
good to me. It looks like the real problems are the memory and  
particle system leaks you located, not the indefinite particle system  
lifetimes.