[sldev] [PATCH] Re: CPUSlow

[Paul TBBle Hampson]

On Wed, May 30, 2007 at 10:16:09AM -0700, Dzonatas wrote:
> https://jira.secondlife.com/browse/VWR-962

This patch only implements CPUID under GCC, which of course only works
on i386 or AMD64 platforms.

rdtsc usage is incorrect for AMD64 platforms (See comments in the patch
attached to VWR-940 for details of that issue) The MSVC-based asm code
for it gets it right, it's only your GCC variant that's wrong.

And of course, PROCESSOR_FREQUENCY_MEASURE_AVAILABLE is only defined for
LL_WINDOWS (Which is bizarre, they should have just used LL_WINDOWS
there to make other platform implementations easier, since the code will
differ)

I can see how this patch would allow building under gcc on win32, but I
really can't see how you could have shown this working under unix,
unless you changed the definition of
PROCESSOR_FREQUENCY_MEASURE_AVAILABLE, and supplied Sleep() and
QueryPerformanceCounter() methods, and just left them out of the patch?

I've also attached these comments to the bug.

It'd be nice if I could just CC the comments to the bug, rather than
having to cut and paste them into the web interface. Or is that just
me failing to RTFM?

-- 
-----------------------------------------------------------
Paul "TBBle" Hampson, B.Sc, LPI, MCSE
On-hiatus Asian Studies student, ANU
The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361)
Paul.Hampson at Pobox.com

Of course Pacman didn't influence us as kids. If it did,
we'd be running around in darkened rooms, popping pills and
listening to repetitive music.
 -- Kristian Wilson, Nintendo, Inc, 1989

License: http://creativecommons.org/licenses/by/2.1/au/
-----------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.secondlife.com/pipermail/sldev/attachments/20070531/fa6e40c1/attachment.pgp