[sldev] [VIEWER] Dead code removal

Nicholaz Beresford nicholaz at blueflash.cc
Tue Sep 4 06:26:51 PDT 2007


Dirk Moerenhout wrote:
> Is it ok to submit a patch for this? I've split my particles stuff in
> pieces and the first part of it now is an extensive dead code removal
> patch (only for particle related dead code off course). It helps speed
> up code as it removes CPU and memory taxing pieces and it also makes
> the code easier to understand and read.

If you have the patch already anyway, why not submit it?  I've done
this with source cleanups in the past, some have been accepted, others
not.  But if you don't submit, they can't decide.

It may be different if you had to decide upfront if you invest
effort, but now you seem to have it ...

Besides, submitting has the benefit that others could use it.  I for
example would be interested in applying dead code removal to my builds
(as well as your other improvements of course :-)).

Or just post the stuff here ...


 > Remember -- "a" and "b" can come from the server code which shares a
 > lot of code with the viewer. Be careful when submitting patches that
 > removes classes like that, since it may still be required for the sim.

I don't think the risk is too high that particle related stuff will
affect the server side, but anyway, the Lindens will find out when
they apply it :-)



Nick


More information about the SLDev mailing list