[sldev] Re: [VIEWER] 64 bit status and open source components (David Fries)

Bryan O'Sullivan bos at lindenlab.com
Fri Sep 14 09:41:54 PDT 2007


Argent Stonecutter wrote:

> If this is generally usable for more than just amd64, I hope the Lindens 
> pick it up as well, because that always bugged me.

I haven't seen a patch that I recall, but I did a bunch of work a month 
or two ago to ensure that the viewer builds cleanly using system 
includes and libraries, by setting just a single flag when running scons.

>> --- indra/newview/llviewerparcelmgr.cpp    18 Jul 2007 00:32:05 
>> -0000    1.12
>> +++ indra/newview/llviewerparcelmgr.cpp    18 Jul 2007 00:33:07 
>> -0000    1.5.2.6
>> @@ -181,7 +181,7 @@ LLViewerParcelMgr::~LLViewerParcelMgr()
>>      mCollisionSegments = NULL;
>>
>>      // weird, this crashes if I use an array delete on it!
>> -    delete sPackedOverlay;
>> +    delete[] sPackedOverlay;
>>      sPackedOverlay = NULL;

I don't know where that came from, but I made just this sort of change 
in our internal code a while ago.  There had been a longstanding 
mismatch between an array constructor and this destructor.  So you can 
consider this change "upstreamed" as of a month or two back :-)

	<b


More information about the SLDev mailing list