[sldev] SL viewer 1.20.15 crashing in llmediaimplllmozlib.cpp

[Mike Monkowski]

Marine,
     I get the same behavior.  Your analysis is pretty close.  It 
crashes  in eventIn.getStringValue2() because that value is not set in 
the event passed by 
LLEmbeddedBrowserWindowEmitter<LLEmbeddedBrowserWindowObserver>::update(), 
  which is in llmozlib2-vc80 in my case, since I'm using VS2005. 
eventIn.getStringValue() has the target URL, so the event has been 
initialized, but the particular field associated with getStringValue2 
has not.

I could trace this deeper inside llmozlib2-vc80, but my guess is that 
it's just an outdated version of the library that's being distributed. 
This has happened before.  The official release uses llmozlib2 since 
VS2003 is still the official build platform.  I would predict that those 
who build with VS2003 do not get the crash.

So add this to the JIRA issue if you've opened one.  If you haven't, now 
would be a good time. :-)

Mike


Marine Kelley wrote:
> Hello all,
> 
> For hours now I've been hunting a crash that occurs when clicking on a 
> link on the login page. Other crashes in the same flavor are occurring 
> in-world when using the All tab of the Search window (especially when 
> clicking on Page 2 or so, but that's another story I think). Thinking it 
> may come from my own code after patching, I've spent time trying to 
> figure it out, to no avail.
> 
> Just tried the freshly-compiled-after-downloading-source from the 
> "source downloads" page, and having the same crash. No change made to 
> that code whatsoever. It seems to come from this method :
> 
> void LLMediaImplLLMozLib::onClickLinkHref( const EventType& eventIn )
> {
>     LLMediaEvent event( this, eventIn.getStringValue(), 
> eventIn.getStringValue2() );
>     mEventEmitter.update( &LLMediaObserver::onClickLinkHref, event );
> }
> 
> where eventIn seems to be uninitialized, leading to a null pointer 
> evaluation.
> 
> The same action does work perfectly in the binary downloaded from the SL 
> download page. So I wonder where the difference is coming from.
> 
> Anyone has an idea and/or experienced this too ?
> 
> Thanks !
> 
> Marine